Repository navigation
[No QA] Don't inject SENTRY_RELEASE into every chunk - #100175
Merged
roryabraham merged 3 commits intoSep 6, 2026
Merged
roryabraham merged 3 commits into
roryabraham merged 3 commits into
Conversation
Contributor
Reviewer Checklist
Screenshots/VideosCleanShot.2026-09-06.at.10.02.34.1.mp4Android: HybridAppN/A Android: mWeb ChromeN/A iOS: HybridAppN/A iOS: mWeb SafariN/A MacOS: Chrome / SafariN/A |
suneox
approved these changes
Sep 6, 2026
roryabraham
approved these changes
Sep 6, 2026
Contributor
|
🚧 roryabraham has triggered a test Expensify/App build. You can view the workflow run here. |
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Contributor
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
43 tasks done
Contributor
|
🚀 Deployed to staging by https://github.com/roryabraham in version: 9.4.73-0 🚀
|
Contributor
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.4.73-3 🚀
Bundle Size Analysis (Sentry): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Stops the Sentry rsbuild plugin from injecting
SENTRY_RELEASEinto every JS chunk (release.inject: falseinconfig/rsbuild/rsbuild.common.ts). The SDK only uses the injected value as a fallback -setupSentry.tsalready passesreleasetoSentry.initexplicitly. Without this, every version bump changed the contenthash of every chunk and invalidated the entire long-term browser cache.Fixed Issues
$ #100203
Tests
npm run buildgrep -rl "SENTRY_RELEASE" dist/*.jsSENTRY_RELEASEsnippet.package.json(e.g. patch bump), runnpm run buildagain into a separate directory, and compare chunk filenames with the previous build.Offline tests
QA Steps
No QA
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.