Skip to content

[No QA] Docs updates for E/A#99217 Export step added to grouped export instructions - #100233

Merged
stephanieelliott merged 1 commit into
mainfrom
claude-docsGroupedExportStep
Sep 23, 2026
Merged

stephanieelliott merged 1 commit into
mainfrom
claude-docsGroupedExportStep

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Explanation of Change

Docs follow-up to #99217, which changed how the Export entry behaves in the Search bulk-action dropdown.

Before that PR, whenever a selection offered only one export option, the Export row collapsed and that single option was shown directly at the top level of the dropdown. A group selection on the Spend page is exactly that case — it offers only Current view — so Export Expenses and Reports told members to select Current view straight from the selection dropdown.

After the PR, Export no longer collapses. When other bulk actions sit alongside it, the export options are nested one level deeper behind an Export row. When Export is the only available action, the options still open directly, now under a plain Export heading.

This PR updates the three places in that article that told members to select Current view without first selecting Export:

  • Export grouped expenses — added a step for selecting Export, noting that the options are already listed when Export is the only available action.
  • FAQ, Can I keep my groups when I export? — now says Export > Current view.
  • FAQ, Can I customize the columns in the CSV export? — now says Export > Current view.

No other help article needed a change. How to Export Expenses, How to Export Reports, and the Export as CSV and Export your current filtered view sections of this same article already described selecting Export before choosing a template, so the PR only makes them more accurate.

Labels were checked against the live UI on a dev build of the branch: the selection button reads 1 selected, the dropdown row reads Export, and the option reads Current view.

Fixed Issues

$
PROPOSAL:

There is no GitHub issue for this docs update. It follows the behavior change in #99217.

Tests

// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review". Please describe what tests you performed that validate your changes worked.

  • Verify that no errors appear in the JS console

Offline tests

N/A — this PR only changes Markdown in docs/articles. There is no app behavior to test offline.

QA Steps

// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review". Please describe what QA needs to do to validate your changes and what areas they need to test for regressions.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@ZhenjaHorbach, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying @MelvinBot mark this PR as ready for review.

Co-authored-by: Yauheni Horbach <ZhenjaHorbach@users.noreply.github.com>
@MelvinBot
MelvinBot requested a review from a team September 2, 2026 23:08
@MelvinBot MelvinBot added the HelpDot Apply this label if the issue relates to ExpensifyHelp label Sep 2, 2026
@stephanieelliott
stephanieelliott marked this pull request as ready for review September 22, 2026 06:46
@melvin-bot

melvin-bot Bot commented Sep 22, 2026 •

Copy link
Copy Markdown

Concierge reviewer checklist:

  • I have verified the accuracy of the article
    • The article is within a hub that makes sense, and the navigation is correct
    • All processes, screenshots, and examples align with current product behavior.
    • All links within the doc have been verified for correct destination and functionality.
  • I have verified the readability of the article
    • The article's language is clear, concise, and free of jargon.
    • The grammar, spelling, and punctuation are correct.
    • The article contains at least one image, or that an image is not necessary
  • I have verified the formatting of the article
    • The article has consistent formatting (headings, bullet points, etc.) with other HelpDot articles and that aligns with the HelpDot formatting standards.
    • The article has proper text spacing and breaks for readability.
  • I have verified the article has the appropriate tone and style
    • The article's tone is professional, friendly, and suitable for the target audience.
    • The article's tone, terminology, and voice are consistent throughout.
  • I have verified the overall quality of the article
    • The article is not missing any information, nor does it contain redundant information.
    • The article fully addresses user needs.
  • I have verified that all requested improvements have been addressed

For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member?

cc @greg-schroeder

@melvin-bot
melvin-bot Bot requested review from greg-schroeder and removed request for a team September 22, 2026 06:46
@melvin-bot

melvin-bot Bot commented Sep 22, 2026

Copy link
Copy Markdown

@greg-schroeder Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@@ -65,7 +65,8 @@ When you group expenses on the **Spend** page, you can export the grouped result
3. Click **Apply**.
4. Check the box next to the groups you want to export, or use the top checkbox to select all.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Step formatting: This numbered step mixes an action with conditional branching logic ("If Export is the only action available... skip to the next step"), which violates the Step Formatting Standard (steps must be sequential, clear, and action-oriented — HELP_AUTHORING_GUIDELINES.md Section 5) and the Deterministic Writing Rule. Move the conditional out of the numbered step into a separate note, e.g.:

Suggested change
4. Check the box next to the groups you want to export, or use the top checkbox to select all.
6. Select **Export**.

Then add a note after the list: "> Note: If Export is the only available action, the export options appear directly under an Export heading. In that case, skip this step and go straight to Current view."

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 743c63a49f

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

## Can I keep my groups when I export?

Yes. Group your expenses using **Display** > **Group by**, select the groups, then choose **Current view**. The exported file keeps each group as its own section with the expenses listed below their group header, using the columns currently shown on the page.
Yes. Group your expenses using **Display** > **Group by**, select the groups, then choose **Export** > **Current view**. The exported file keeps each group as its own section with the expenses listed below their group header, using the columns currently shown on the page.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Document the direct export path in the FAQ

When a grouped search uses Select all, useSearchBulkActions deliberately displays Current view directly beneath a noninteractive Export heading rather than providing an Export row (src/hooks/useSearchBulkActions.ts:2138-2150; covered by useSearchBulkActionsExportTest.ts:1208-1230). This FAQ now unconditionally tells users to choose Export > Current view, so users following this path will look for a control that does not exist. Preserve the sole-action exception described in the detailed steps above; the generic instruction added at line 121 needs the same qualification.

Useful? React with 👍 / 👎.

@github-actions

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment
This is a small, focused documentation follow-up to Expensify/App PR 99217. It updates three places in Search-and-Download-Expenses.md where the article previously told members to select Current view directly. Because the Export row no longer collapses in the Search bulk-action dropdown, the changes correctly insert an explicit Export selection before Current view. The changes are accurate to the current UI and consistent with the rest of the article.

Scores Summary

  • Readability: 8/10 - Steps are sequential, action-oriented, and correctly renumbered. The only weak point is the new step 6, which packs the action plus a conditional into a single numbered line, making it a bit dense to scan.
  • AI Readiness: 9/10 - Uses UI-exact, full labels (Export, Current view) and reinforces the existing task-based structure. No headings, metadata, or scope were changed by this diff, so retrieval quality is preserved. Not scored higher only because the diff adds no new searchable phrasing.
  • Style Compliance: 9/10 - UI labels are bolded, in Sentence case, and unquoted per the Button Naming Standards. The Export > Current view nesting matches the existing Display > Group by convention already used in the file.

Key Findings

  • Correct fix: adding Export before Current view accurately reflects the post-99217 dropdown behavior in all three locations (step list plus two FAQ answers).
  • Consistency: the > separator for nested selections matches existing usage in the same article, so the change reads naturally.
  • Minor readability nit: in the new step 6, consider a standard hyphen or en dash with surrounding spaces, or splitting the conditional into its own sentence, since the em dash with no spaces crowds the instruction.
  • No governance violations found in the changed lines. No heading, metadata (internalScope), or cross-linking rules are implicated by this diff.

Recommendations

  • Optional polish for step 6: keep 'Select Export.' as the step and move the 'If Export is the only action available...' note to its own line.
  • No blocking issues; the changes are ready to merge from a documentation-quality standpoint.

Files Reviewed

  • docs/articles/new-expensify/reports-and-expenses/Search-and-Download-Expenses.md - Accurate, compliant update. One minor readability suggestion on the new step 6.

Note: This PR was small enough that all feedback is captured in this summary; the single suggestion above covers the only actionable item.

@stephanieelliott
stephanieelliott merged commit d8fe44b into main Sep 23, 2026
20 of 23 checks passed
@stephanieelliott
stephanieelliott deleted the claude-docsGroupedExportStep branch September 23, 2026 00:16
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.4.92-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@izarutskaya

Copy link
Copy Markdown

@ZhenjaHorbach Can I check it off the list if no need QA?

N/A — this PR only changes Markdown in docs/articles. There is no app behavior to test offline.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/lakchote in version: 9.4.92-8 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@stephanieelliott stephanieelliott changed the title Docs updates for E/A#99217 Export step added to grouped export instructions [No QA] Docs updates for E/A#99217 Export step added to grouped export instructions Sep 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants