Repository navigation
[No QA] Docs updates for E/A#99217 Export step added to grouped export instructions - #100233
Conversation
Co-authored-by: Yauheni Horbach <ZhenjaHorbach@users.noreply.github.com>
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? |
|
@greg-schroeder Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
| @@ -65,7 +65,8 @@ When you group expenses on the **Spend** page, you can export the grouped result | |||
| 3. Click **Apply**. | |||
| 4. Check the box next to the groups you want to export, or use the top checkbox to select all. | |||
There was a problem hiding this comment.
Step formatting: This numbered step mixes an action with conditional branching logic ("If Export is the only action available... skip to the next step"), which violates the Step Formatting Standard (steps must be sequential, clear, and action-oriented — HELP_AUTHORING_GUIDELINES.md Section 5) and the Deterministic Writing Rule. Move the conditional out of the numbered step into a separate note, e.g.:
| 4. Check the box next to the groups you want to export, or use the top checkbox to select all. | |
| 6. Select **Export**. |
Then add a note after the list: "> Note: If Export is the only available action, the export options appear directly under an Export heading. In that case, skip this step and go straight to Current view."
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 743c63a49f
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| ## Can I keep my groups when I export? | ||
|
|
||
| Yes. Group your expenses using **Display** > **Group by**, select the groups, then choose **Current view**. The exported file keeps each group as its own section with the expenses listed below their group header, using the columns currently shown on the page. | ||
| Yes. Group your expenses using **Display** > **Group by**, select the groups, then choose **Export** > **Current view**. The exported file keeps each group as its own section with the expenses listed below their group header, using the columns currently shown on the page. |
There was a problem hiding this comment.
Document the direct export path in the FAQ
When a grouped search uses Select all, useSearchBulkActions deliberately displays Current view directly beneath a noninteractive Export heading rather than providing an Export row (src/hooks/useSearchBulkActions.ts:2138-2150; covered by useSearchBulkActionsExportTest.ts:1208-1230). This FAQ now unconditionally tells users to choose Export > Current view, so users following this path will look for a control that does not exist. Preserve the sole-action exception described in the detailed steps above; the generic instruction added at line 121 needs the same qualification.
Useful? React with 👍 / 👎.
|
HelpDot Documentation Review Overall Assessment Scores Summary
Key Findings
Recommendations
Files Reviewed
Note: This PR was small enough that all feedback is captured in this summary; the single suggestion above covers the only actionable item. |
|
🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.4.92-0 🚀
|
|
@ZhenjaHorbach Can I check it off the list if no need QA?
|
|
🚀 Deployed to production by https://github.com/lakchote in version: 9.4.92-8 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Docs follow-up to #99217, which changed how the Export entry behaves in the Search bulk-action dropdown.
Before that PR, whenever a selection offered only one export option, the Export row collapsed and that single option was shown directly at the top level of the dropdown. A group selection on the Spend page is exactly that case — it offers only Current view — so Export Expenses and Reports told members to select Current view straight from the selection dropdown.
After the PR, Export no longer collapses. When other bulk actions sit alongside it, the export options are nested one level deeper behind an Export row. When Export is the only available action, the options still open directly, now under a plain Export heading.
This PR updates the three places in that article that told members to select Current view without first selecting Export:
No other help article needed a change. How to Export Expenses, How to Export Reports, and the Export as CSV and Export your current filtered view sections of this same article already described selecting Export before choosing a template, so the PR only makes them more accurate.
Labels were checked against the live UI on a dev build of the branch: the selection button reads 1 selected, the dropdown row reads Export, and the option reads Current view.
Fixed Issues
$
PROPOSAL:
There is no GitHub issue for this docs update. It follows the behavior change in #99217.
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review". Please describe what tests you performed that validate your changes worked.
Offline tests
N/A — this PR only changes Markdown in
docs/articles. There is no app behavior to test offline.QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review". Please describe what QA needs to do to validate your changes and what areas they need to test for regressions.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
@ZhenjaHorbach, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.