Repository navigation
Conversation
…Reports list Co-authored-by: Mukhriddin Shakhriyorov <mukhrr@users.noreply.github.com>
53 tasks done
Contributor
|
A preview of your ExpensifyHelp changes have been deployed to https://e4361531.helpdot.pages.dev ⚡️ Updated articles: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Help site updates for #99124, which renders the message This report was rejected. on the expense report preview in the workspace chat, and makes the same message visible on the Reports list to every report participant (not only the report owner).
None of the help site articles described this message, so a submitter had no documented way to tell a rejected report apart from a plain draft. Three articles change:
docs/articles/new-expensify/reports-and-expenses/Approve-Expenses.md— adds a Where the rejected report message appears section under the reject-a-report workflow, covering both places the message shows, who sees it, when it clears, and why a report rejected to a previous approver does not show it. Also notes that the rejection reason is posted as a comment.docs/articles/new-expensify/reports-and-expenses/Create-and-Submit-Reports.md— adds a submitter-facing FAQ, How do I know if my report was rejected?, since the submitter is the person who sees the message and has to resubmit manually.docs/articles/new-expensify/reports-and-expenses/Getting-Started-with-the-Spend-Page.md— lists the message among what a report preview can show.All UI labels used here were verified against the live app on web: the Spend tab and its Reports sub-section, the More button, the Reject menu item, the Reject report modal and confirm button, the Rejection reason field, and the exact message text
This report was rejected.The rejected report's status badge reads Draft, which matches the existing wording in these articles.Docs-only change — no code, copy, or behavior changes.
Fixed Issues
$
PROPOSAL:
Docs follow-up for #99124, the PR for #96996. No separate issue — this PR only updates help site articles.
Tests
// TODO: The human co-author must fill out the tests they ran before marking this PR as "ready for review".
This PR changes Markdown files under
docs/articlesonly, so there is nothing to test in the app. To review the content:This report was rejected.Offline tests
QA Steps
// TODO: The human co-author must fill out the QA steps before marking this PR as "ready for review".
No QA needed — this PR changes help site Markdown only and does not ship any app behavior.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
@mukhrr, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.