Skip to content

[No QA] Docs updates for E/A#99124 rejected report message in report preview - #100234

Closed
MelvinBot wants to merge 1 commit into
mainfrom
melvin-docs-99124-rejected-report-message
Closed

MelvinBot wants to merge 1 commit into
mainfrom
melvin-docs-99124-rejected-report-message

Conversation

@MelvinBot

@MelvinBot MelvinBot commented Sep 2, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

Help site updates for #99124, which renders the message This report was rejected. on the expense report preview in the workspace chat, and makes the same message visible on the Reports list to every report participant (not only the report owner).

None of the help site articles described this message, so a submitter had no documented way to tell a rejected report apart from a plain draft. Three articles change:

  • docs/articles/new-expensify/reports-and-expenses/Approve-Expenses.md — adds a Where the rejected report message appears section under the reject-a-report workflow, covering both places the message shows, who sees it, when it clears, and why a report rejected to a previous approver does not show it. Also notes that the rejection reason is posted as a comment.
  • docs/articles/new-expensify/reports-and-expenses/Create-and-Submit-Reports.md — adds a submitter-facing FAQ, How do I know if my report was rejected?, since the submitter is the person who sees the message and has to resubmit manually.
  • docs/articles/new-expensify/reports-and-expenses/Getting-Started-with-the-Spend-Page.md — lists the message among what a report preview can show.

All UI labels used here were verified against the live app on web: the Spend tab and its Reports sub-section, the More button, the Reject menu item, the Reject report modal and confirm button, the Rejection reason field, and the exact message text This report was rejected. The rejected report's status badge reads Draft, which matches the existing wording in these articles.

Docs-only change — no code, copy, or behavior changes.

Fixed Issues

$
PROPOSAL:

Docs follow-up for #99124, the PR for #96996. No separate issue — this PR only updates help site articles.

Tests

// TODO: The human co-author must fill out the tests they ran before marking this PR as "ready for review".

This PR changes Markdown files under docs/articles only, so there is nothing to test in the app. To review the content:

  1. Open the three changed articles and confirm each statement matches the current behavior in New Expensify.
  2. Confirm every UI label matches the app exactly: Spend > Reports, More, Reject, Reject report, Rejection reason, and the message This report was rejected.
  • Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: The human co-author must fill out the QA steps before marking this PR as "ready for review".

No QA needed — this PR changes help site Markdown only and does not ship any app behavior.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@mukhrr, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying @MelvinBot mark this PR as ready for review.

…Reports list

Co-authored-by: Mukhriddin Shakhriyorov <mukhrr@users.noreply.github.com>
@MelvinBot
MelvinBot requested a review from a team September 2, 2026 23:09
@MelvinBot MelvinBot added the HelpDot Apply this label if the issue relates to ExpensifyHelp label Sep 2, 2026
@github-actions github-actions Bot changed the title Docs updates for E/A#99124 rejected report message in report preview [No QA] Docs updates for E/A#99124 rejected report message in report preview Sep 2, 2026
@OSBotify

OSBotify commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants