Repository navigation
Update persistent window logic to not show for new users - #100236
carlosmiceli merged 7 commits into
Conversation
…t-session-marketing-window
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
@codex review |
|
Codex Review: Didn't find any major issues. Bravo. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-09-06.at.14.39.55.movAndroid: mWeb ChromeScreen.Recording.2026-09-06.at.14.35.58.moviOS: HybridAppScreen.Recording.2026-09-06.at.14.42.49.moviOS: mWeb SafariScreen.Recording.2026-09-06.at.14.44.41.movMacOS: Chrome / SafariScreen.Recording.2026-09-06.at.13.30.17.mp4 |
Screen.Recording.2026-09-06.at.14.51.28.mp4@KJ21-ENG Could you test the Copilot case? When I switch to an account that has Copilot enabled, the marketing window doesn’t appear. However, when I open the same account in another browser, the marketing window appears. |
|
@huult This same behavior came up in the original PR discussion. My reply then explained that we hid the window during Copilot access to avoid dismissing the announcement for the account owner, but noted that this was a product decision. That behavior predates this PR. However, I couldn’t find an explicit product confirmation in that discussion. Could we confirm whether the window should remain hidden while acting as a Copilot? If it should appear, we should also clarify whether the Copilot’s Dismiss or Try it out action should affect the account owner’s dismissal state. |
|
@KJ21-ENG I think we can proceed with this PR since we are already seeing this issue. We can discuss the other case separately, as it is an existing production issue and we don't want it to block this PR. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 carlosmiceli has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/carlosmiceli in version: 9.4.73-0 🚀
|
|
🤖 No help site changes are required for this PR, so I did not create a draft docs PR. Why: this PR only changes when the in-app product marketing window is allowed to render. It adds no new feature, setting, menu item, button, or user-facing workflow — and the product marketing window itself is not documented anywhere in What I checkedThe change: Net user-visible effect: a brand-new user no longer sees the promotional window during or after guided setup in their first authenticated session. It can appear in a later session. Dismissal and CTA behavior are unchanged, and no copy changed. Help site search: I searched all of Nothing in the help site describes the promotional window's timing, eligibility, or dismissal rules, so there is no existing article that has become inaccurate. If you'd still like an article written to document the in-app product announcement window (who sees it, when, and how dismissal works), reply with @KJ21-ENG, there is no linked help site PR to review because no docs changes were needed. Please confirm you agree with that call, or reply as above and I'll create one. |
|
Deploy Blocker #100500 was identified to be related to this PR. |
|
NAB / regression replied here. |
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.4.73-3 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Subscribe the product marketing window manager to onboarding state and remember, per account and per authenticated manager lifetime, when incomplete onboarding was observed. The window now fails closed while onboarding and account context hydrate, stays suppressed for the rest of a new user's first authenticated session, and remains eligible in a later session without recording a false dismissal. Focused tests cover admin and member audiences, same-session onboarding completion, remount eligibility, account switching, legacy onboarding values, and startup hydration.
Fixed Issues
$ #99389
PROPOSAL: #99389 (comment)
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Record_2026-09-05-00-16-21_40d2c9e2d8fb5b5aba3904834590021e.compressed.mp4
Android: mWeb Chrome
Record_2026-09-05-00-22-03.compressed.mp4
iOS: Native
Simulator.Screen.Recording.-.iPhone.17.-.2026-09-05.at.01.02.55.compressed.mp4
iOS: mWeb Safari
Simulator.Screen.Recording.-.iPhone.17.-.2026-09-05.at.01.06.16.compressed.mp4
MacOS: Chrome / Safari
Screen.Recording.2026-08-25.at.12.26.31.PM.compressed.mp4