Skip to content

Update persistent window logic to not show for new users - #100236

Merged
carlosmiceli merged 7 commits into
Expensify:mainfrom
KJ21-ENG:KJ21-ENG/99389-first-session-marketing-window
Sep 7, 2026
Merged

carlosmiceli merged 7 commits into
Expensify:mainfrom
KJ21-ENG:KJ21-ENG/99389-first-session-marketing-window

Conversation

@KJ21-ENG

@KJ21-ENG KJ21-ENG commented Sep 2, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

Subscribe the product marketing window manager to onboarding state and remember, per account and per authenticated manager lifetime, when incomplete onboarding was observed. The window now fails closed while onboarding and account context hydrate, stays suppressed for the rest of a new user's first authenticated session, and remains eligible in a later session without recording a false dismissal. Focused tests cover admin and member audiences, same-session onboarding completion, remount eligibility, account switching, legacy onboarding values, and startup hydration.

Fixed Issues

$ #99389
PROPOSAL: #99389 (comment)

Tests

  1. Verify that no errors appear in the JS console.
  2. Sign in as an eligible existing workspace admin whose onboarding is already complete and who has not dismissed the active product announcement.
  3. Verify the admin marketing window appears and its CTA and dismissal behavior still work.
  4. Create a fresh eligible admin account and complete guided setup without reloading or signing out.
  5. Verify the marketing window never appears during onboarding or after onboarding completes in that authenticated session.
  6. Navigate elsewhere and background and foreground the app without remounting the authenticated root. Verify the window remains hidden.
  7. Sign out and sign back in to the completed account, or restart the app. Verify the marketing window can appear in the subsequent authenticated session.
  8. Repeat steps 4 through 7 with a non-admin member that is eligible for the member campaign, including the Custom Agent beta when the active announcement requires it. Verify the member window is also suppressed only for the first session.
  9. While the manager is mounted, switch from an account that observed incomplete onboarding to another completed eligible account, then switch back. Verify the second account can show its window and the original account remains suppressed for its first session.
  10. From a completed eligible Copilot account, enter an owner account and verify the window is hidden while acting as a Copilot. Exit Copilot mode and verify the Copilot account's own window returns.
  11. Verify dismissing the window or completing its CTA still persists the active update key and prevents the window from returning.
  • Verify that no errors appear in the JS console

Offline tests

  1. Complete onboarding for a fresh eligible account and remain in the same authenticated session.
  2. Go offline after the onboarding state has hydrated.
  3. Navigate between app screens and background and foreground the app.
  4. Verify the product marketing window stays hidden and no console errors appear.
  5. Return online, sign out, and sign back in. Verify the completed account remains eligible for the campaign in the subsequent session.

QA Steps

  1. Verify that no errors appear in the JS console.
  2. Create a fresh eligible admin account and complete guided setup without reloading or signing out.
  3. Verify the marketing window does not appear during or after onboarding in that session.
  4. Sign out and sign back in, or restart the app. Verify the admin marketing window can appear in the subsequent session.
  5. Repeat with an eligible non-admin member and verify the member variant follows the same session boundary.
  6. Switch from the newly onboarded account to another completed eligible account, then switch back. Verify the completed account can show its window and the newly onboarded account remains suppressed.
  7. From a completed eligible Copilot account, enter an owner account and verify the window is hidden. Exit Copilot mode and verify the Copilot account's own window returns.
  8. Dismiss the visible window or complete its CTA. Verify the active campaign remains dismissed afterward.
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Record_2026-09-05-00-16-21_40d2c9e2d8fb5b5aba3904834590021e.compressed.mp4
Android: mWeb Chrome
Record_2026-09-05-00-22-03.compressed.mp4
iOS: Native
Simulator.Screen.Recording.-.iPhone.17.-.2026-09-05.at.01.02.55.compressed.mp4
iOS: mWeb Safari
Simulator.Screen.Recording.-.iPhone.17.-.2026-09-05.at.01.06.16.compressed.mp4
MacOS: Chrome / Safari
Screen.Recording.2026-08-25.at.12.26.31.PM.compressed.mp4

@melvin-bot

melvin-bot Bot commented Sep 4, 2026

Copy link
Copy Markdown

@huult Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 4, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-04T20:08:27.293482Z 2769279 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@KJ21-ENG

KJ21-ENG commented Sep 4, 2026

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Bravo.

Reviewed commit: 2769279225

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@huult

huult commented Sep 6, 2026 •

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Screen.Recording.2026-09-06.at.14.39.55.mov
Android: mWeb Chrome
Screen.Recording.2026-09-06.at.14.35.58.mov
iOS: HybridApp
Screen.Recording.2026-09-06.at.14.42.49.mov
iOS: mWeb Safari
Screen.Recording.2026-09-06.at.14.44.41.mov
MacOS: Chrome / Safari
Screen.Recording.2026-09-06.at.13.30.17.mp4

@huult

huult commented Sep 6, 2026

Copy link
Copy Markdown
Contributor
Screen.Recording.2026-09-06.at.14.51.28.mp4

@KJ21-ENG Could you test the Copilot case? When I switch to an account that has Copilot enabled, the marketing window doesn’t appear. However, when I open the same account in another browser, the marketing window appears.

@KJ21-ENG

KJ21-ENG commented Sep 6, 2026

Copy link
Copy Markdown
Contributor Author

@huult This same behavior came up in the original PR discussion. My reply then explained that we hid the window during Copilot access to avoid dismissing the announcement for the account owner, but noted that this was a product decision.

That behavior predates this PR. However, I couldn’t find an explicit product confirmation in that discussion.

Could we confirm whether the window should remain hidden while acting as a Copilot? If it should appear, we should also clarify whether the Copilot’s Dismiss or Try it out action should affect the account owner’s dismissal state.

@huult

huult commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

@KJ21-ENG I think we can proceed with this PR since we are already seeing this issue. We can discuss the other case separately, as it is an existing production issue and we don't want it to block this PR.

@huult huult left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@melvin-bot
melvin-bot Bot requested a review from mollfpr September 7, 2026 07:49
@carlosmiceli
carlosmiceli self-requested a review September 7, 2026 10:40
@carlosmiceli
carlosmiceli merged commit a6591b8 into Expensify:main Sep 7, 2026
36 of 39 checks passed
@OSBotify

OSBotify commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

🚧 carlosmiceli has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

OSBotify commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/carlosmiceli in version: 9.4.73-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 failure ❌

@MelvinBot

MelvinBot commented Sep 7, 2026 •

Copy link
Copy Markdown
Contributor

🤖 No help site changes are required for this PR, so I did not create a draft docs PR.

Why: this PR only changes when the in-app product marketing window is allowed to render. It adds no new feature, setting, menu item, button, or user-facing workflow — and the product marketing window itself is not documented anywhere in App/docs/articles.

What I checked

The change: src/components/ProductMarketingWindow/ProductMarketingWindowManager.tsx now subscribes to the onboarding NVP and to the current account ID. It records, per account and per manager lifetime, that incomplete onboarding was seen, then adds shouldSuppressForOnboardingSession to the existing hide conditions. The rest of the diff is unit tests in tests/unit/ProductMarketingWindowTest.tsx.

Net user-visible effect: a brand-new user no longer sees the promotional window during or after guided setup in their first authenticated session. It can appear in a later session. Dismissal and CTA behavior are unchanged, and no copy changed.

Help site search: I searched all of App/docs/articles for "marketing window", "product marketing", "product announcement", "product update", "announcement", "pop-up", "popup", and "what's new". The only related hit is Navigating-New-Expensify.md, which lists What's new as an item under Account settings for viewing product updates. That is a separate menu item, not this window, and the PR does not change it.

Nothing in the help site describes the promotional window's timing, eligibility, or dismissal rules, so there is no existing article that has become inaccurate.

If you'd still like an article written to document the in-app product announcement window (who sees it, when, and how dismissal works), reply with @MelvinBot create the docs PR anyway and tell me which section it belongs in — I'd suggest docs/articles/new-expensify/getting-started/. I'll build it against HELPSITE_NAMING_CONVENTIONS.md, HELP_AUTHORING_GUIDELINES.md, and TEMPLATE.md, apply the HelpDot label, and assign it to you.

@KJ21-ENG, there is no linked help site PR to review because no docs changes were needed. Please confirm you agree with that call, or reply as above and I'll create one.


view run · view recording

@mitarachim

Copy link
Copy Markdown

Deploy Blocker #100500 was identified to be related to this PR.

@KJ21-ENG

KJ21-ENG commented Sep 8, 2026

Copy link
Copy Markdown
Contributor Author

NAB / regression replied here.

@OSBotify

OSBotify commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/mountiny in version: 9.4.73-3 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants