Repository navigation
[No QA] Add policy vendors Onyx collection type - #100240
Conversation
|
@ChavdaSachin Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
@codex review Please independently review this Phase 1A-scoped change for correctness, contract compliance, regressions, and missing coverage. 🤖 Posted by Codex, an AI coding agent acting for @Beamanator. |
|
Codex Review: Didn't find any major issues. You're on a roll. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This comment was marked as duplicate.
This comment was marked as duplicate.
|
Codex Review: Didn't find any major issues. Nice work! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Sorry @ChavdaSachin i don't think we need a C+ on this one since it's pretty small |
|
@codex review Review-fix update at 🤖 Posted by Codex, an AI coding agent acting for @Beamanator. |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
|
🚧 francoisl has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
Codex Review: Didn't find any major issues. Bravo. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
🚀 Deployed to staging by https://github.com/francoisl in version: 9.4.73-0 🚀
|
|
🤖 Help site review: no changes required. No draft PR was created. This PR adds a typed Onyx collection contract and nothing a customer can see. There is no feature, screen, tab, setting, or button to document, so no article under Why I concluded thisWhat the diff does (all 5 files):
Why none of that is documentable:
When docs will be needed: once the vendor UI ships in the linked follow-up work — Phase 1B ( @Beamanator, no help site PR exists to review because this change is not customer-visible. If you disagree — for example if you expect the vendor UI from Phase 1B to land soon enough that you want the article drafted ahead of it — reply with |
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.4.73-3 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Problem: Phase 1A publishes a generic Auth-owned
policyVendors_{policyID}collection, but App needs a typed Onyx prefix and collection shape before its parallel vendor UI work can safely consume it.Implementation: add the
policyVendors_collection prefix and aPolicyVendorsrecord keyed by external ID. Each entry hasexternalID,name, derivedenabled, and optionalorigin;originis restricted to the existingPolicyConnectionNameunion. Onyx-state exports preserve matching fields while masking vendor names.Non-goals: no UI, actions, optimistic updates, connection-data reads, preference persistence, picker filtering, matching, violations, or lifecycle behavior. Those belong to the linked App/Phase 1B/Phase 2 work.
Related: Auth implementation PR #24216, tracker #678247, contract #678248, Phase 1A #650596, Phase 1B #670690, and Phase 2 #678249.
Fixed Issues
$ #98355
$ https://github.com/Expensify/Expensify/issues/650596
PROPOSAL: N/A — the agreed data contract is documented in https://github.com/Expensify/Expensify/issues/678248
Tests
npm run fmt— passed.npm run typecheck— passed.npx jest tests/unit/ExportOnyxStateTest.ts --runInBand— passed (30 tests).npm run lint-changed— passed.npm run spell-changed— passed.Manual verification
policyVendors_{policyID}.externalID,name,enabled, and an optional valid policy-connectionorigin.externalID,enabled, andoriginremain inspectable.Offline tests
Not applicable: this PR only declares a typed server-projected collection key and makes no offline mutation.
QA Steps
Not applicable: this is a no-UI typed Onyx contract change. Follow the manual verification after Auth PR #24216 is deployed and verify there are no JavaScript console errors.
🤖 Posted by Codex, an AI coding agent acting for @Beamanator.