Repository navigation
[No QA] Update AI Agent help docs - #100263
Conversation
Co-authored-by: Yuwen Memon <yuwenmemon@users.noreply.github.com>
|
A preview of your ExpensifyHelp changes have been deployed to https://547206bf.helpdot.pages.dev ⚡️ Updated articles: |
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? |
|
@strepanier03 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
| ## How to write instructions that reject expense reports | ||
|
|
||
| **Goal:** Sends an Outstanding (submitted) expense report back to the submitter with a user-facing rejection comment explaining why. | ||
| **Goal:** Sends an entire Outstanding (submitted) expense report back to the submitter with a user-facing rejection comment explaining why. |
There was a problem hiding this comment.
Terminology violation: Use Expensify's standard term "member" instead of "user". Consider "with a member-facing rejection comment" to match the required terminology (Member, not User) in HELP_AUTHORING_GUIDELINES.md.
|
|
||
| To react to this event, include phrases like: | ||
| - When a member's approver for reports over a set amount is changed | ||
| - When large expense reports from a specific employee will now go to a different approver |
There was a problem hiding this comment.
Terminology violation: Use "member" instead of "employee" to match Expensify's standard terminology (Member, not User/employee). Suggest "reports from a specific member".
|
|
||
| To react to this event, include phrases like: | ||
| - When the approval amount for a specific member is changed | ||
| - When the amount that sends an employee's reports to an extra approver is updated |
There was a problem hiding this comment.
Terminology violation: Use "member" instead of "employee" to match Expensify's standard terminology. Suggest "sends a member's reports to an extra approver".
|
HelpDot Documentation Review Overall Assessment Scores Summary
Key Findings
Recommendations
Files Reviewed
Note: This is a generated-content update; feedback is scoped to the diff only. |
|
🚀 Deployed to staging by https://github.com/strepanier03 in version: 9.4.73-0 🚀
|
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.4.73-3 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
These two help articles are generated from
Web-Expensify, not hand-written.lib/ReportActionDescriptions.phpandlib/AgentCapabilityDescriptions.phpare the same source of truth that builds the prompt text the agent itself sees, so when that text changes the public reference has to change with it or admins are told to write instructions against events and actions that no longer behave that way.This PR is the regenerated output of
php script/generateCustomAgentTriggers.phpandphp script/generateCustomAgentCapabilities.php, run againstExpensify/Web-Expensifyatmain(4ed6dc63503d0427da16cfc14ac8a50cf9c008de), written verbatim. No content was authored by hand.What moved since the last regeneration:
AI-Agent-Triggers.md (121 → 123 events)
AI-Agent-Capabilities.md (19 → 20 capabilities)
Fixed Issues
$
PROPOSAL:
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
These are two generated markdown help articles under
docs/articles/. No app code, no docs routing or config, and noredirects.csventry changed, so the App code test bundle (lint, typecheck, jest, storybook) does not apply. To re-verify the content, check outExpensify/Web-Expensifyatmainand re-run the two generator scripts — the output should match these files byte for byte.Offline tests
QA Steps
No QA — this changes help-site article content only. It ships no product behavior for QA to exercise.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari