Skip to content

[No QA] Move Sage Intacct vendor matching docs to main navetation - #100366

Merged
heyjennahay merged 3 commits into
mainfrom
helpsite-move-intacctvendormatch
Sep 4, 2026
Merged

heyjennahay merged 3 commits into
mainfrom
helpsite-move-intacctvendormatch

Conversation

@stephanieelliott

Copy link
Copy Markdown
Contributor

Moving Sage Intacct vendor matching docs from hidden folder to Sage Intacct folder in the main nav.

@stephanieelliott stephanieelliott self-assigned this Sep 4, 2026
@stephanieelliott
stephanieelliott requested a review from a team as a code owner September 4, 2026 02:25
@melvin-bot

melvin-bot Bot commented Sep 4, 2026

Copy link
Copy Markdown

Concierge reviewer checklist:

  • I have verified the accuracy of the article
    • The article is within a hub that makes sense, and the navigation is correct
    • All processes, screenshots, and examples align with current product behavior.
    • All links within the doc have been verified for correct destination and functionality.
  • I have verified the readability of the article
    • The article's language is clear, concise, and free of jargon.
    • The grammar, spelling, and punctuation are correct.
    • The article contains at least one image, or that an image is not necessary
  • I have verified the formatting of the article
    • The article has consistent formatting (headings, bullet points, etc.) with other HelpDot articles and that aligns with the HelpDot formatting standards.
    • The article has proper text spacing and breaks for readability.
  • I have verified the article has the appropriate tone and style
    • The article's tone is professional, friendly, and suitable for the target audience.
    • The article's tone, terminology, and voice are consistent throughout.
  • I have verified the overall quality of the article
    • The article is not missing any information, nor does it contain redundant information.
    • The article fully addresses user needs.
  • I have verified that all requested improvements have been addressed

For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member?

cc @Kel-Expensify

@melvin-bot
melvin-bot Bot requested review from Kel-Expensify and blimpich and removed request for a team September 4, 2026 02:26
@melvin-bot

melvin-bot Bot commented Sep 4, 2026

Copy link
Copy Markdown

@blimpich @Kel-Expensify One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

NOTE: It looks like docs/redirects.csv was modified in this PR. Please see this SO for special instructions on how to review changes to that file.

@stephanieelliott stephanieelliott added the HelpDot Apply this label if the issue relates to ExpensifyHelp label Sep 4, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review


P2 Badge Remove the unlisted indexing flags

When this article is published at its new main-navigation path, retaining these flags causes the shared layout to emit noindex, nofollow and excludes the page from the generated sitemap. Consequently, the newly public article remains undiscoverable through search engines and the Google-powered help search despite appearing in navigation; remove both flags when moving it out of Unlisted.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@github-actions

github-actions Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR moves Manage-Vendor-Matching-for-Intacct.md out of Unlisted/ into the main Sage Intacct navigation path (new-expensify/connections/sage-intacct/), renames it to ...-for-Sage-Intacct.md, and adds a redirect. The article content is unchanged (100% similarity), but because it now enters main navigation it must fully comply with governance. The content is genuinely strong and mostly compliant — but the frontmatter still carries noindex: true and sitemap: false, which is a blocking issue for a newly-navigable article.

Scores Summary

  • Readability: 9/10 — Clear, scannable, well-sequenced numbered steps, concise benefit-focused intro, and precise vendor-priority ordering.
  • AI Readiness: 8/10 — Excellent task-based headings, full "Sage Intacct" feature name throughout, complete YAML including internalScope, correct #/##-only hierarchy, and a "How to..." heading. Docked for the leftover noindex/sitemap flags that suppress retrieval/indexing.
  • Style Compliance: 8/10 — Consistent "Sage Intacct" (not "Intacct"), correct bold UI labels (Vendor, Credit Card Charges, Export, Default vendor), and compliant navigation phrasing. Minor inconsistency: some UI labels appear unbolded in prose/FAQ.

Key Findings

  • Blocking: Frontmatter retains noindex: true and sitemap: false. Sibling published articles (e.g., Connect-to-Sage-Intacct.md) do not carry these. Left as-is, the article stays out of search indexing and the sitemap despite living in main navigation — defeating the purpose of the move.
  • Redirect is correct: old Unlisted/Manage-Vendor-Matching-for-Intacct maps to the new path, matching the established pattern for the Rillet moves directly above it.
  • Filename and headings correctly use the full feature name "Sage Intacct" instead of the abbreviated "Intacct".
  • Strong compliance: single # title + exempt # FAQ, all ## headings task/question-based, no ###, complete metadata with internalScope, relative descriptive cross-link to Connect to Sage Intacct.
  • Minor: UI terms are bolded inconsistently — bolded in steps/body (Vendor, Default vendor) but plain in some FAQ/prose ("the Vendor field is optional", "the vendor Credit Card Misc", "the configured Default vendor"). "Credit Card Misc" is never bolded; confirm whether it is a literal UI label and bold it consistently if so.

Recommendations

  • Priority: Remove noindex: true and sitemap: false from the frontmatter so the newly-navigable article is indexed and appears in the sitemap, consistent with its siblings.
  • Bold UI labels consistently across body and FAQ (Vendor, Default vendor, Credit Card Misc if it is a literal UI value).
  • Confirm the referenced image asset resolves at the new path.

Files Reviewed

  • docs/articles/new-expensify/connections/sage-intacct/Manage-Vendor-Matching-for-Sage-Intacct.md — Strong content; must drop noindex/sitemap flags before publishing to navigation.
  • docs/redirects.csv — Correct redirect added; format matches existing entries.

Note: Detailed line-by-line feedback has been provided as inline comments.

@github-actions github-actions Bot changed the title Move Sage Intacct vendor matching docs to main navetation [No QA] Move Sage Intacct vendor matching docs to main navetation Sep 4, 2026
@OSBotify

OSBotify commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

A preview of your ExpensifyHelp changes have been deployed to https://dd62bae8.helpdot.pages.dev ⚡️

Updated articles:

@heyjennahay heyjennahay left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@heyjennahay
heyjennahay merged commit dd6a676 into main Sep 4, 2026
18 of 19 checks passed
@heyjennahay
heyjennahay deleted the helpsite-move-intacctvendormatch branch September 4, 2026 17:00
@OSBotify

OSBotify commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/heyjennahay in version: 9.4.73-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 failure ❌

@OSBotify

OSBotify commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/mountiny in version: 9.4.73-3 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants