Repository navigation
[No QA] Docs updates for E/A#100138 hidden approval workflows on externally managed workspaces - #100486
[No QA] Docs updates for E/A#100138 hidden approval workflows on externally managed workspaces#100486MelvinBot wants to merge 2 commits into
Conversation
…flow workspaces Co-authored-by: Sobit Neupane <sobitneupane@users.noreply.github.com>
|
@MelvinBot mark this PR as ready for review |
|
🤖 Done — this PR is now marked as ready for review. |
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? |
|
@sobitneupane @Kel-Expensify One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
HelpDot Documentation ReviewOverall AssessmentThis is a focused, docs-only PR that updates two workspace articles to reflect that the approval workflow UI is hidden on externally managed workspaces. Scores Summary
Key Findings
Recommendations
Files Reviewed
Note: Detailed line-by-line feedback has been provided as inline comments. |
|
|
||
| **Note:** Downloading requires an internet connection. If you're offline, you'll be prompted to reconnect before the download can start. | ||
|
|
||
| **Note:** If your workspace's approval workflow is set up and maintained by Expensify, the **Workflows** page shows the message "A custom approval workflow is enabled on this workspace" and the **More** menu is hidden, so neither **Download workflows** nor **Import workflows** is available. Reach out to your Account Manager or Concierge for the workflow details. [Learn why the approval workflows are hidden](/articles/new-expensify/workspaces/Add-Approvals#why-cant-i-see-the-approval-workflows-on-my-workspace). |
There was a problem hiding this comment.
Naming/style: Per HELPSITE_NAMING_CONVENTIONS.md, do not wrap UI text in quotation marks. The in-app message "A custom approval workflow is enabled on this workspace" is quoted inline here, but the parallel content in Add-Approvals.md renders the same message as a blockquote (>). For consistency and to follow the convention, present the message as a blockquote rather than in double quotes.
|
@stephanieelliott I don't see links to review the changes? |
|
@stephanieelliott just following up, I didn't see links to review the changes |
|
@MelvinBot, run |
Co-authored-by: Stephanie Elliott <stephanieelliott@users.noreply.github.com>
|
A preview of your ExpensifyHelp changes have been deployed to https://d9e68255.helpdot.pages.dev ⚡️ Updated articles: |
|
✅ Why it hadn't run, and how I triggered itThe original run on this branch (34115571461, 2026-09-07) was cancelled, not failed. The workflow uses a shared My token doesn't have One side effect: the build's "Ensure PR title has [No QA] prefix" step applies to docs-only PRs, so it renamed this PR to [No QA] Docs updates for E/A#100138 …. That's the workflow's own behavior, not something I changed. |
|
Oop, @Kel-Expensify looks like the job to generate the links didn't run! They're there now :) |
|
Consolidating to #101958 to avoid conflicts |
…nsify/workspaces
Explanation of Change
Help site follow-up for #100138, which hides the approval workflow UI on a workspace whose approval mode is a Dynamic External Workflow with Hide People Table Columns set. Two help articles described behavior that no longer holds on those workspaces, so both are updated. Docs-only change — no product code is touched.
docs/articles/new-expensify/workspaces/Add-Approvals.mdAdds an FAQ entry, Why can't I see the approval workflows on my workspace?, covering what an admin actually sees on an affected workspace: the Approvals toggle stays, the message "A custom approval workflow is enabled on this workspace…" replaces the workflow list, and the approval workflow cards, the search field, the Add approval workflow row, and the More menu (Import workflows and Download workflows) are all gone. It states that this applies to every role including Workspace Admins, People Admins, and the workspace owner, that a direct link to an approvals page shows a not-found page, and that the fix is to reach out to your Account Manager or Concierge. It also notes that workspaces without an Account Manager see the Concierge-only wording, since the app has both variants of that message. The article's
keywordsgain the phrases someone would actually search when the UI disappears.The FAQ placement is deliberate — this is a "why is my UI different" question, not a task, and the article's own guidance for building approval workflows is unchanged for every other workspace.
docs/articles/new-expensify/workspaces/Workspace-Workflows.mdThe "How to download your workflow configuration" section told admins who can manage workflows that they will see the More menu. That is now wrong on an affected workspace, where the whole menu is hidden rather than rendering download-only. A note records the exception, points to the Account Manager or Concierge for the workflow details, and cross-links the new FAQ entry.
Wording notes for the reviewer
Add-Approvals.mdalready uses "custom approval workflow" for the per-member Control-plan workflows you build yourself, and the in-app message uses the same phrase for the externally managed workflow. The new FAQ entry quotes the message verbatim so readers can match what is on their screen, and leads with "a workflow that Expensify sets up and maintains for you" to separate the two. Tell me if you would rather the articles avoid quoting the message.Not documented, on purpose: the PR notes that
Members.csvis still reachable at Members > Download CSV and thatpolicy.employeeListstill ships the approver fields to the client. That is an open engineering gap, not customer guidance, so it stays out of the help site.Fixed Issues
$ #98491
PROPOSAL:
Tests
// TODO: The human co-author must fill out the tests they ran before marking this PR as "ready for review".
This is a docs-only change with no product code, so there is nothing to exercise in the app. What I did verify:
npm run spell-changed— 2 files checked, 0 issues.#why-cant-i-see-the-approval-workflows-on-my-workspacematches the slug style already used for an apostrophe FAQ heading elsewhere in the docs (Create-an-Expense.md).What I could not verify: the rendered help site pages and the cross-link resolving on a HelpDot build.
Offline tests
Not applicable. These are help site markdown articles with no runtime behavior and no network dependency.
QA Steps
// TODO: The human co-author must fill out the QA steps before marking this PR as "ready for review", or add "[No QA]" to the title.
Docs-only change — no app behavior changes. If QA does review it, the check is that the two articles render and the cross-link from Workspace Workflows lands on the new FAQ entry in Add Approvals.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
@sobitneupane, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.