Skip to content

[No QA] Docs updates for E/A#99420 category default tax rates in Expense defaults - #100489

Open
MelvinBot wants to merge 7 commits into
mainfrom
claude-docsCategoryTaxDefaults
Open

MelvinBot wants to merge 7 commits into
mainfrom
claude-docsCategoryTaxDefaults

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Explanation of Change

Help site updates for the category tax defaults added in #99420.

That PR lets a Workspace Admin create an expense default that matches on a Category and sets a default Tax rate, alongside the existing merchant-matching rules. Nothing on the help site described this, so the new capability was undocumented.

Fixed Issues

$ Docs follow-up for #99420

What changed

New article — docs/articles/new-expensify/workspaces/Set-a-default-tax-rate-for-a-category.md

Covers the one workflow end to end:

  • Who can do it (Workspace Admin, Control plan, Rules enabled, Taxes enabled with at least one rate).
  • Creating the rule: Rules > Expense defaults > Add rule > Apply expense defaults > Category, then Category and Tax.
  • Selecting several categories at once creates one rule per category.
  • Editing, deleting, and bulk deleting rules listed under Categories as Category is "[category name]".
  • Behavior after saving: applies to new expenses only, falls back to the workspace default when deleted, removed when its category or tax rate is deleted, survives a category rename.
  • FAQ for the locked Category option (Turn on taxes first), the Taxes are not enabled empty state, the missing None option, the two validation errors, and auditor read-only access.

Updated — Workspace-Rules.md

  • The Default tax rate bullet under Category Rules now notes the rate can also be managed from the Expense defaults tab and links to the new article. Both paths write the same rule.

Updated — Workspace-Merchant-Rules.md

  • Added the extra chooser step for the tabbed Rules page (Add rule > Apply expense defaults > Merchant).
  • Corrected Save Rule to Save rule to match the UI.
  • Added a pointer to the new article for the category-matching rule type.

Rollout note for the reviewer

The tabbed Rules page is behind the rulesRevamp beta. A live check of the current UI on web confirms the Rules page still shows Expenses, Merchant, and Agent rules sections with an Add merchant rule button — no tabs and no Add rule button. So the new steps use the same conditional phrasing already used in Import-Merchant-Rules.md ("If the Rules page shows tabs…") rather than replacing the current instructions. Once the beta is fully rolled out, the conditional wording in all three articles can be dropped.

Label and copy sources

All UI strings were taken from src/languages/en.ts on the merged PR: tab Expense defaults, button Add rule, chooser Apply expense defaults / What should this rule match on? / Merchant / Category, section headings Categories / Merchants / Merchant types, modals Turn on taxes first and Category rules apply going forward, empty state Taxes are not enabled / Enable taxes, and errors Please select a category / Please select a tax rate.

Tests

Documentation only — no product code changed. npm run spell-changed passes on all three files (0 issues).

QA Steps

Verify the rendered article at /articles/new-expensify/workspaces/Set-a-default-tax-rate-for-a-category and confirm the cross-links from Workspace Rules and Merchant Rules resolve.

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I verified any copy / text that was added is grammatically correct in English and adheres to proper capitalization guidelines

@Krishna2323, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying @MelvinBot mark this PR as ready for review.

Adds a help article for setting a category's default tax rate from the Expense defaults tab, and cross-links it from Workspace Rules and Merchant Rules.

Co-authored-by: Krishna <Krishna2323@users.noreply.github.com>
@MelvinBot MelvinBot added the HelpDot Apply this label if the issue relates to ExpensifyHelp label Sep 7, 2026
truph01 pushed a commit to truph01/App that referenced this pull request Sep 28, 2026
@stephanieelliott
stephanieelliott marked this pull request as ready for review September 28, 2026 04:29
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ⚠️ Failed 2026-09-28T05:00:32.981557Z da01156 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR adds a new article, Set a default tax rate for a category, and wires it into two existing Rules articles (Workspace Merchant Rules and Workspace Rules) via cross-links. The changes are high quality overall: the new article is well-scoped to a single workflow, follows the required structure, and the edits to existing files are small, correct, and improve consistency. Assessment below is based only on the added/modified lines in the diff.

Scores Summary

  • Readability: 9/10 - Clear, concise, benefit-focused intro; sequential and action-oriented steps; strong scannability. Merchant Rules step 3 now bundles a full alternate navigation path into one numbered step, which is a touch dense.
  • AI Readiness: 9/10 - Complete YAML frontmatter with a precise internalScope, keywords reflecting real search intent, exactly one # title plus # FAQ, ##-only hierarchy, and task/question-based headings throughout. Includes multiple full "How to..." headings with the feature name.
  • Style Compliance: 9/10 - Exact UI labels, buttons/tabs bolded in Sentence case, unified web/mobile navigation phrasing per convention, and descriptive cross-link anchors. Notably fixes the prior `Select Save Rule` to `Click Save rule`.

Key Findings

  • Strengths: The new article solves one workflow cleanly (category default tax rate), correctly excludes adjacent workflows (creating tax rates, Merchant Rules, workspace/foreign-currency defaults) in internalScope, and cross-links them instead of absorbing them. FAQ entries all begin with question words and address real edge cases (locked options, missing rates, read-only auditor view).
  • Strengths: Screenshot placeholder uses the exact non-rendered HTML comment format with a specific, justified Purpose.
  • Strengths: Edits to Merchant Rules and Workspace Rules reinforce the primary workflow with descriptive anchor text and correct casing; the Save Rule -> Save rule fix aligns with the button naming standard.
  • Minor: Merchant Rules step 3 embeds a conditional alternate path (tabs -> Expense defaults -> Add rule -> Apply expense defaults -> Merchant) inside a single numbered step. This is navigation rather than an inline link, so it is acceptable, but consider splitting the conditional path out of the numbered flow for cleaner procedural clarity.
  • Minor: Several steps in the new article are conditional ("If the Rules page shows tabs..."), reflecting a UI in transition. This is handled honestly, but will need pruning once the UI settles.

Recommendations

  • Optional: In Workspace Merchant Rules, move the alternate "Expense defaults tab" path out of numbered step 3 into a short conditional sentence after the step list to avoid interrupting procedural flow.
  • Optional: Once the Rules page tab layout is finalized, remove the "If the Rules page shows tabs / doesn't show tabs" conditionals to keep instructions deterministic.
  • No blocking issues. Structure, metadata, headings, and UI terminology all comply with the governance files.

Files Reviewed

  • docs/articles/new-expensify/workspaces/Set-a-default-tax-rate-for-a-category.md - New article; compliant structure, metadata, headings, and FAQ.
  • docs/articles/new-expensify/workspaces/Workspace-Merchant-Rules.md - Correct button casing fix and appropriate cross-link; minor density in step 3.
  • docs/articles/new-expensify/workspaces/Workspace-Rules.md - Clean single-line cross-link addition with descriptive anchor.

Note: Detailed line-by-line feedback has been provided as inline comments.


- To change the category or the tax rate, click the rule, update **Category** or **Tax**, then click **Save rule**. Changing the category moves the rate to the new category and removes the old rule.
- To remove a single rule, click the rule and then click **Delete rule**.
- To remove several rules at once, select their checkboxes and use the bulk delete action.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UI referencing violation: "use the bulk delete action" generalizes a UI element instead of naming it. Per HELPSITE_NAMING_CONVENTIONS.md (Core UI Referencing Rules / Prohibited Language), reference the exact UI control (e.g., the exact bold button/label the user clicks to delete the selected rules) rather than describing a generic "action".

1. In the navigation tabs (on the left on web, and at the bottom on mobile), click **Workspaces > [workspace name]**.
2. Click **Rules**.
3. In the **Merchant** section, click **Add merchant rule**.
3. In the **Merchant** section, click **Add merchant rule**. If the **Rules** page shows tabs instead, select the **Expense defaults** tab, click **Add rule**, select **Apply expense defaults**, then select **Merchant**.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Step formatting violation: This single numbered step now embeds an entire conditional alternate flow with multiple chained actions ("select the Expense defaults tab, click Add rule, select Apply expense defaults, then select Merchant"). Per HELP_AUTHORING_GUIDELINES.md Section 5, steps must be sequential, clear, and single-action. Move the alternate-path instructions out of the numbered step into a separate conditional sentence/short sequence after the list so the primary flow stays scannable and deterministic.


1. In the navigation tabs (on the left on web, on the bottom on mobile), click **Workspaces > [workspace name]**.
2. Click **Rules**.
3. If the **Rules** page shows tabs, select the **Expense defaults** tab.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deterministic/step-formatting concern: Numbered step 3 is conditional ("If the Rules page shows tabs, select the Expense defaults tab."), and the procedure documents two divergent UI states (see also the alternate path at line 50). Per HELP_AUTHORING_GUIDELINES.md Section 5 and the Deterministic Writing Rule in HELPSITE_NAMING_CONVENTIONS.md, numbered steps should be non-conditional and single-action. Consider stating the applicable UI variant up front (or splitting the two flows) so the numbered sequence stays deterministic rather than embedding an "if" branch inside a step.

stephanieelliott and others added 4 commits September 27, 2026 18:34
Co-authored-by: Krishna <Krishna2323@users.noreply.github.com>
…into claude-docsCategoryTaxDefaults

Co-authored-by: Krishna <Krishna2323@users.noreply.github.com>
@MelvinBot

Copy link
Copy Markdown
Contributor Author

Fixed the failing spellcheck check. cspell flagged a typo in Workspace-Merchant-Rules.md line 50: "atches" should be "matches". I pushed the fix in e308905.

Check independent approval is also failing. It needs a reviewer's approval, not a code change.


view run

@github-actions github-actions Bot changed the title Docs updates for E/A#99420 category default tax rates in Expense defaults [No QA] Docs updates for E/A#99420 category default tax rates in Expense defaults Sep 28, 2026
@OSBotify

This comment has been minimized.

@OSBotify

This comment has been minimized.

@OSBotify

Copy link
Copy Markdown
Contributor

A preview of your ExpensifyHelp changes have been deployed to https://31f0f83a.helpdot.pages.dev ⚡️

Updated articles:

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants