Repository navigation
[Payment due @situchan] Hide unread markers on read reports - #100562
Conversation
aedf1af to
50b756f
Compare
…read-markers # Conflicts: # src/hooks/useUnreadMarker.ts # src/pages/inbox/report/ReportActionsList.tsx
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safarithis.branch.mov |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 98d3973177
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
garrettmknight
left a comment
There was a problem hiding this comment.
Very excited for this one!
situchan
left a comment
There was a problem hiding this comment.
Please check automated review comments.
And can you please attach video to see how this works?
This comment has been minimized.
This comment has been minimized.
|
Please check if this is bug or expected: "Mark as unread" from LHN shows no divider when the NetSuite export is the only action from another user
main: "New" divider above "exported to NetSuite". main.movthis.branch.movAs this is non-critical and this PR is now narrowed to NetSuite only, I won't block on this. |
|
@deetergp please merge main and fix Oxlint |
|
@justinpersaud Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@situchan Done! |
|
@MelvinBot why did you add @justinpersaud? @mollfpr is already the internal reviewer… |
|
The
You’re right: |
|
@mollfpr All you! |
|
Bump @mollfpr |
|
🚧 mollfpr has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/mollfpr in version: 9.5.41-0 🚀
|
|
No help site update needed — this PR fixes automatic unread indicators for payment and NetSuite export messages without adding a workflow or making any existing article sentence incorrect. |
|
🚀 Deployed to production by https://github.com/marcaaron in version: 9.5.41-2 🚀
Bundle Size Analysis (Sentry): |
|
🤖 Payment issue created: #107319 |
Explanation of Change
This PR changes when two system messages show a “New” line:
Other integrations keep working as before. This PR no longer changes how chats are marked read or unread, how messages load, how scrolling works, or the library that displays the message list. Choosing “Mark as unread” on a message still works as before.
The Auth change that tells the App who should be notified is already merged: https://github.com/Expensify/Auth/pull/24311.
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/677837
PROPOSAL: N/A
Tests
Passed locally in desktop Chrome with submitter A and payer B. For the NetSuite test, we added an export message locally without sending data to NetSuite.
Offline tests
These steps have not been tested manually yet. Automated tests passed for messages received while offline.
QA Steps
Repeat the Tests section on staging on each supported platform. Use a workspace with automatic reimbursement enabled, and switch to another chat before the payment completes.
AI Tests
ReportActionsUtilsTest,useUnreadMarkerTest,UnreadIndicatorsTest,useMarkAsReadTest,ReportTest, andReportUtilsTest(2 skipped).PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Checklist notes: Chrome testing is complete; Safari, mobile, offline, high-traffic, and accessibility testing remain pending. This PR adds no app text, assets, form inputs, new code patterns, or generic components. It does not change how messages are edited or sent. No separate input-error test applies. Testing from links while signed in and signed out, and another manual test after the final merge, have not been completed for this smaller version.
Screenshots/Videos
Earlier recording, before the scope reduction:
https://github.com/user-attachments/assets/4117ea82-2e2c-4d7c-abe6-4c1a2c2151a0
Android: Native
Testing pending.
Android: mWeb Chrome
Testing pending.
iOS: Native
Testing pending.
iOS: mWeb Safari
Testing pending.
MacOS: Chrome / Safari
Chrome: payment, NetSuite export, and ordinary-comment flows verified locally. Updated recording pending.
Safari: testing pending.