Repository navigation
Conversation
Seatbelt-Operation: s08-159f3a24-00c6c5f-sign-1
|
@ikevin127 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Reviewer Checklist
|
ikevin127
left a comment
There was a problem hiding this comment.
🟢 LGTM - No blocking findings during review. The change is correct, minimal, and behavior neutral.
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 blimpich has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/blimpich in version: 9.4.82-0 🚀
|
|
No help site changes are required for this PR. I did not create a docs PR. This change removes a TypeScript type assertion and its now-unused Why nothing in
|
|
🚀 Deployed to staging by https://github.com/blimpich in version: 9.4.86-0 🚀
|
|
🤖 No help site changes are required for this PR, so I did not create a docs PR. Why: the whole diff is a TypeScript type cleanup with no runtime or user-facing change. It drops the Nothing under If you expected a user-visible change here (for example, a routing fix a member would notice), tell me what it is and I'll scope the docs update. @KJ21-ENG, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR |
|
🚀 Deployed to staging by https://github.com/blimpich in version: 9.4.89-0 🚀
|
|
🚀 Deployed to production by https://github.com/luacmartins in version: 9.4.89-0 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
This removes an unnecessary type assertion from dynamic-route screen detection. The configured path is already a
string, and the existingSet<string>accepts it directly, so the optional lookup, empty-path guard, exact membership test, and navigation behavior stay unchanged.The only changed file is
src/libs/Navigation/helpers/dynamicRoutesUtils/isDynamicRouteScreen.ts.Fixed Issues
$ #94739
PROPOSAL: #94739 (comment)
Tests
On macOS, open Chrome.
Sign in.
Go to Settings > Profile > Personal details > Home address > Country.
Verify the Country screen opens.
Verify the URL ends in
/country.Refresh the page.
Use Back.
Verify navigation returns to Home address.
Verify there is no unexpected fullscreen or routing state.
Open a regular Settings screen.
Refresh the page.
Use Back.
Verify refresh and Back behavior remain normal.
Check the JavaScript console for errors.
Note: These steps are recommended and have not been performed.
Verify that no errors appear in the JS console
Offline tests
Not applicable. This cleanup changes no requests or offline handling; offline testing was not performed.
QA Steps
Same as test steps.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
26.Home_2026-09-13_05-11-07.mp4