Repository navigation
Fix - Company cards - Broken card feed connection RHP spins forever with no error when the feed has a feed-level error #100687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
3775879
d472a96
5e2e062
5d79654
0b6d804
33fc246
a345db2
786b6dd
972e185
502374f
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,6 +3,7 @@ import type {AddPersonalPlaidCardParams, ImportPlaidAccountsParams, OpenPlaidBan | |
| import type OpenPlaidCompanyCardLoginParams from '@libs/API/parameters/OpenPlaidCompanyCardLoginParams'; | ||
| import {READ_COMMANDS, WRITE_COMMANDS} from '@libs/API/types'; | ||
| import {getCardFeedWithoutDomainID} from '@libs/CardUtils'; | ||
| import {getMicroSecondOnyxErrorWithTranslationKey} from '@libs/ErrorUtils'; | ||
| import getPlaidLinkTokenParameters from '@libs/getPlaidLinkTokenParameters'; | ||
|
|
||
| import CONST from '@src/CONST'; | ||
|
|
@@ -151,6 +152,7 @@ function importPlaidAccounts( | |
| plaidAccounts: string, | ||
| plaidAccessToken: string | undefined, | ||
| domainAccountID?: number, | ||
| isRepairingFeed = false, | ||
| ) { | ||
| const parameters: ImportPlaidAccountsParams = { | ||
| publicToken, | ||
|
|
@@ -178,7 +180,7 @@ function importPlaidAccounts( | |
| { | ||
| onyxMethod: Onyx.METHOD.MERGE, | ||
| key: ONYXKEYS.ASSIGN_CARD, | ||
| value: {isRefreshing: null}, | ||
| value: {isRefreshing: null, ...(isRepairingFeed ? {errors: getMicroSecondOnyxErrorWithTranslationKey('common.genericErrorMessage')} : {})}, | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
The new Useful? React with 👍 / 👎.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Race predates the PR: i |
||
| }, | ||
| ], | ||
| }; | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MelvinBot
startCardFeedRefreshdoesn't havesetNavigationActionToMicrotaskQueue. Is it safe removal? Which PR introduced this to fix what bug?