Skip to content

Add Tax rate and Tax code columns to the workspace Taxes table - #100710

Merged
JS00001 merged 15 commits into
Expensify:mainfrom
Krishna2323:krishna2323/issue/100587
Sep 24, 2026
Merged

JS00001 merged 15 commits into
Expensify:mainfrom
Krishna2323:krishna2323/issue/100587

Conversation

@Krishna2323

@Krishna2323 Krishna2323 commented Sep 9, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

Fixed Issues

$ #100587
PROPOSAL:

Tests

  1. Control workspace, wide screen: Verify the table shows Name, Tax rate, Tax code, Enabled, and the caret. Rate values should be in Tax rate, not under the name.
  2. Default indicators: Set workspace and foreign currency defaults. Verify the matching rows show "Workspace currency default" / "Foreign currency default" under the name, and "Default" when both apply. No rate should appear under the name.
  3. Sort by Tax rate: With 9% and 10%, verify ascending puts 9% before 10%, and clicking again reverses it.
  4. Sort by Tax code: Verify alphabetical sorting, with code-less rates last in both directions.
  5. Sort by Name / Enabled: Verify both still work as before.
  6. Search: Search by tax code, name, and rate value. Verify each returns the matching rate.
  7. Tax code gating: On Collect, verify Tax code is hidden. On Control with no customized codes, verify it's also hidden.
  8. Narrow layout: Resize to mobile/tablet or use native. Verify the stacked layout shows 10% • Workspace currency default under the name, with no Tax rate / Tax code columns or alignment issues.
  9. Column widths: Add a rate with a long name/code. Verify columns fit their content, the rate doesn't truncate, and horizontal scrolling is used when needed.
  10. Regression: Toggle a rate, select rows, use bulk Delete / Enable / Disable, open the edit page, and verify offline pending/error states still work.
  • Verify that no errors appear in the JS console

Offline tests

  • Same as tests

QA Steps

  • Same as tests

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
android_hybrid.mp4
Android: mWeb Chrome
android_mWeb.mp4
iOS: Native
ios_hybrid.mp4
iOS: mWeb Safari
ios_mWeb.mp4
MacOS: Chrome / Safari
web_chrome.mp4

Signed-off-by: krishna2323 <belivethatkg@gmail.com>
@codecov

codecov Bot commented Sep 9, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
src/components/Table/Table.tsx 91.24% <100.00%> (+0.06%) ⬆️
src/components/Table/TableSemanticContainer.tsx 100.00% <100.00%> (ø)
src/components/Table/middlewares/sorting.ts 96.29% <85.71%> (+0.14%) ⬆️
.../components/Tables/WorkspaceMembersTable/index.tsx 53.33% <0.00%> (+15.23%) ⬆️
src/components/Table/compareOptionalValues.ts 0.00% <0.00%> (ø)
...les/WorkspaceTaxesTable/WorkspaceTaxesTableRow.tsx 0.00% <0.00%> (ø)
src/pages/workspace/taxes/WorkspaceTaxesPage.tsx 0.00% <0.00%> (ø)
...rc/components/Tables/WorkspaceTaxesTable/index.tsx 0.00% <0.00%> (ø)
... and 88 files with indirect coverage changes

@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

🚧 shawnborton has triggered a test Expensify/App build. You can view the workflow run here.

@JS00001

JS00001 commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

@Expensify/design I think this one is ready for a gander

@JS00001

JS00001 commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Oh, you beat me to it lol

@github-actions

This comment has been minimized.

@shawnborton

Copy link
Copy Markdown
Contributor

For the default row:
CleanShot 2026-09-09 at 15 30 44@2x

Should we do something more like Workspaces list?
CleanShot 2026-09-09 at 15 31 11@2x

cc @Expensify/design for thoughts

@shawnborton

Copy link
Copy Markdown
Contributor

Otherwise tests well and looks good to me 👍

@dannymcclain

Copy link
Copy Markdown
Contributor

For the default row
Should we do something more like Workspaces list?

I quite like that idea! It might get us into a bit of a sticky situation in this case when there's both a workspace currency default and foreign currency default though:

CleanShot 2026-09-09 at 08 37 10@2x

Thoughts about how to handle that?

@shawnborton

Copy link
Copy Markdown
Contributor

Ah I did not know those existed. Let's stick with the current implementation then 👍

@Krishna2323

Copy link
Copy Markdown
Contributor Author

@JS00001, who'll review this?

@JS00001

JS00001 commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Situ reviewed other table PRs, so they can probably help out here. @situchan wanna review?

@situchan

situchan commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Situ reviewed other table PRs, so they can probably help out here. @situchan wanna review?

yes thanks

@Krishna2323
Krishna2323 marked this pull request as ready for review September 10, 2026 06:06
@Krishna2323
Krishna2323 requested review from a team as code owners September 10, 2026 06:06
@melvin-bot
melvin-bot Bot requested review from situchan and removed request for a team September 10, 2026 06:06
@melvin-bot

melvin-bot Bot commented Sep 10, 2026

Copy link
Copy Markdown

@situchan Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot requested review from flaviadefaria and removed request for a team September 10, 2026 06:06

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e2ae5776ae

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
@Krishna2323

Copy link
Copy Markdown
Contributor Author

@situchan friendly bump

@situchan

Copy link
Copy Markdown
Contributor

Reviewing today

@Krishna2323

Copy link
Copy Markdown
Contributor Author

@situchan all review comments addressed.

@situchan

Copy link
Copy Markdown
Contributor

Conflicts

Comment on lines +141 to +144

const isItemInSearch: IsItemInSearchCallback<WorkspaceTaxTableRowData> = (item, searchValue) => {
const results = tokenizedSearch([item], searchValue, (option) => [option.name, option.alternateText]);
const searchableFields = [item.name, item.taxRateValue, ...(shouldSearchTaxCode ? [item.taxCode] : [])];
const results = tokenizedSearch([item], searchValue, () => searchableFields);

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: searching the taxes list by the default indicator no longer works

bug.mov

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@MelvinBot

Copy link
Copy Markdown
Contributor

🤖 Code review — 3 regressions worth fixing, plus a few things to confirm. TypeScript passes (npx tsc --noEmit); I did not run Jest.


1. Search no longer matches the default indicator

Before, alternateText was "10% • Workspace currency default" and was a search field. Now the searchable set is name + rate (+ code on wide), so typing default, workspace, or foreign into Find tax rate returns nothing where it used to filter to the default rates.

src/components/Tables/WorkspaceTaxesTable/index.tsx:143 — add item.defaultLabel to searchableFields.

2. Search results change when the window is resized

shouldSearchTaxCode is layout-dependent, so a search on a tax code silently empties when you drag the window from wide to medium, and refills on the way back. The row data is the same either way — gate what you render, not what you search.

index.tsx:140

3. Page and table disagree on the breakpoint

The page computes the flag with !shouldUseNarrowLayout (WorkspaceTaxesPage.tsx:211), but the table and row gate on shouldUseNarrowLayout || isMediumScreenWidth (index.tsx:54, WorkspaceTaxesTableRow.tsx:68).

At medium widths taxCode stays in columns while nothing renders it, so semanticColumnCount overcounts and TableDisplaySettingsTrigger lists a hidden sort column. Both are latent today (semantics are off on narrow, and the trigger is suppressed by narrowLayoutSortColumn), but either gate changing turns this into a visible bug. Drop the layout term from the page and let the table own it.


Lower severity — worth a look

toggleColumnSorting lost its functional update. sorting.ts:140 now reads activeSorting from the render closure, so two toggles dispatched in one React batch collapse into one. You can keep the fix and the safety by resolving inside the updater:

setUserSorting((previousSorting) => {
    const resolved = resolveActiveSorting(shouldUseNarrowTableLayout, narrowLayoutSortColumn, previousSorting, columnKeys, initialSortColumn);
    return {columnKey: columnKey ?? resolved.columnKey, order: resolved.order === 'asc' ? 'desc' : 'asc'};
});

Fallback hard-codes order: 'asc'. sorting.ts:107 — if the user is on Tax code descending and the column disappears, the sort silently becomes Name ascending, and jumps back to Tax code descending if the column returns. Confirm that double flip is intended. Also note columnKeys includes non-sortable keys like actions, so the guard won't catch a bogus updateSorting({columnKey: 'actions'}).

compareTaxRateValues returns 0 for anything unparseable. index.tsx:39 — Number.parseFloat('10,5%') is 10, so 10,5% ties with 10%. Unparseable values compare equal to everything, so they scatter through the list instead of grouping at one end. compareOptionalValues deliberately pins missing values last; the rate comparator could do the same.

shouldUseDynamicColumns now forces the wrapper on native. TableSemanticContainer.tsx:70 adds a flex1/minHeight: 0 View around the header/body run on Android, iOS, and narrow web — for the Members table too, not just Taxes. Native never crosses the measurement breakpoint (canMeasureText() is false), so the remount this guards against can't happen there. Consider shouldUseDynamicColumns && canMeasureText(), and either way re-check the Members table's empty state and list height on native.

Tax code is blank for integration-imported rates. isTaxCodeCustomized is only true once a code has been renamed (PolicyUtils.ts:3456; the create flow has no code field). On a Control workspace connected to QBO/Xero/NetSuite, renaming one code turns the column on for the whole table while every imported rate shows an empty cell. It matches WorkspaceEditTaxPage.tsx:90 so it is at least consistent — flagging because the column is new surface area.

columnKeys is a fresh array each render. Table.tsx:299 — harmless today since useSorting doesn't memoize on it, but it would quietly defeat any memoization added there later.

Checked and clean
  • The WorkspaceMembersTable extraction into compareOptionalValues is behavior-identical to the four inlined blocks it replaces, including the "missing values last in both directions" rule and the name tie-break.
  • Narrow-layout name supporting text (10% • Workspace currency default) matches the old alternateText exactly.
  • Wide-layout cell count matches columns.length in both the code-shown and code-hidden cases.
  • workspace.taxes.taxRate and workspace.taxes.taxCode both exist; no new copy was added.
  • Row height is fixed at variables.tableRowHeight, so dropping the rate out of the name cell doesn't change row heights.

The branch is currently conflicting with main (mergeStateStatus: DIRTY), which is what situchan flagged.

Signed-off-by: krishna2323 <belivethatkg@gmail.com>
… indicator

Signed-off-by: krishna2323 <belivethatkg@gmail.com>
@Krishna2323

Copy link
Copy Markdown
Contributor Author

@situchan friendly bump

Comment on lines +106 to +110
// A column that stops being rendered (e.g. a conditional column loses its last value) can leave the table sorted
// by a key no header shows an arrow for. Falling back to the initial column keeps the sort visible and correct.
if (userSorting.columnKey && !columnKeys.includes(userSorting.columnKey)) {
return {columnKey: initialSortColumn, order: 'asc'};
}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The list re-orders to Name ascending. Not happening on staging.
The same thing happens on categories table

  1. Workspace with multi-level tags → Tags, browser wider than 1024px.
  2. Click the Tag count header to sort by it.
  3. Drag the window below 1024px.
Screen.Recording.2026-09-24.at.1.25.58.PM.mov

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@melvin-bot
melvin-bot Bot requested a review from JS00001 September 24, 2026 12:58
@MelvinBot

Copy link
Copy Markdown
Contributor

🤖 Re-reviewed at 474d89c. All three regressions from my last pass are fixed. Two things left that I'd fix before merge, plus some minor notes. TypeScript passes (npx tsc --noEmit); I could not run Jest or ESLint in this environment.


1. shouldUseDynamicColumns forces the wrapper on native, where the remount it guards against can't happen

TableSemanticContainer.tsx:70

The fix itself is right — on web, onLayout falls away below the breakpoint and the tree used to swap, remounting the body and wiping the search string. But canMeasureText() is false on native (measureTextWidth/index.native.ts:9), so isDynamicSizingEnabled is never true there (Table.tsx:379) and onLayout/scrollWidth are always undefined at every width. There is no tree swap to protect against on iOS/Android — yet the condition now adds a permanent flex1/minHeight: 0 View around the header/body run for four tables: Taxes, Members, Expensify cards, and Company cards. The last three are outside this PR and have no native screenshots on it.

Gate it on the platform that actually needs it:

const shouldWrapTableRun = isEnabled || (shouldUseDynamicColumns && canMeasureText()) || onLayout !== undefined || scrollWidth !== undefined;

Related: the empty-body escape hatch at TableSemanticContainer.tsx:82 still requires isEnabled, which is false on narrow web and on native. So a dynamic-columns table whose header and body both render null now keeps the flex1 wrapper next to its empty-state view — exactly what that comment warns about. Not reachable today because all four tables pass a Table.ListHeader, so rendersBodyWhenEmpty is true. The canMeasureText() gate above closes the native half; the narrow-web half needs that guard to stop keying off isEnabled alone.

2. compareTaxRateValues isn't a valid comparator when a rate doesn't parse

WorkspaceTaxesTable/index.tsx:43

Returning 0 for any pair containing NaN makes an unparseable value compare equal to every rate, while the parseable ones still order among themselves — so 9% < 10% but garbage == 9% and garbage == 10%. That's non-transitive, and Array.prototype.sort is free to produce arbitrary output for a non-transitive comparator, so those rows can land in an order that isn't stable between renders. Separately, Number.parseFloat('10,5%') is 10, so 10,5% silently ties with 10%.

compareOptionalValues already has the right shape for this — pin unparseable values last in both directions instead of returning 0.


Minor — your call

The sorting fallback doesn't notify onSortingChange. sorting.ts:114 changes activeSorting without going through updateSorting, so onSortingChange never fires. WorkspaceRoomsPage persists sorting from that callback (WorkspaceRoomsPage.tsx:207); its columns are static so it can't trigger today, but any table that both persists sorting and has a conditional column will display one sort and store another.

The fallback hard-codes order: 'asc' and ignores initialSortOrder. sorting.ts:115 — latent, since no table passes initialSortOrder today.

columnKeys includes non-sortable keys like actions (Table.tsx:322), so the guard won't catch a bogus updateSorting({columnKey: 'actions'}).

No unit tests for the two riskiest new pieces. resolveActiveSorting's fallback and compareOptionalValues are now shared by every Table consumer (~25 tables), and the only new test covers the semantic wrapper. Three cheap cases on resolveActiveSorting would cover it: column disappears on wide → falls back; narrow keeps the user's sorting; columnKey: undefined after the third header press stays undefined.

Tax code is blank for integration-imported rates. isTaxCodeCustomized is true only once previousTaxCode is set (PolicyUtils.ts:3656) — i.e. the code has been renamed at least once. On a Control workspace connected to QBO/Xero/NetSuite, renaming a single code turns the column on for the whole table while every imported rate shows an empty cell. It matches WorkspaceEditTaxPage.tsx:90 exactly, so this is consistent — flagging only because the column is new surface area.

Re-verified as fixed / checked clean

Fixed since my last pass:

  • Search now matches the default indicator — defaultLabel is in searchableFields (index.tsx:143).
  • Search is layout-independent — the tax-code term is gated on shouldShowTaxCodeColumn, a pure data flag, so resizing never changes which rows a query matches.
  • Page and table agree on the breakpoint — WorkspaceTaxesPage.tsx:212 is now data-only, and the table owns the width gate. semanticColumnCount and the display-settings column list both line up as a result.
  • toggleColumnSorting flipping from activeSorting is correct, and my earlier note about it losing a functional update was wrong — updateSorting already resolved the updater against the render closure, so batching behavior is unchanged.
  • Conflicts with main are resolved (MERGEABLE).

Checked clean:

  • Wide-layout cell count matches columns.length in both the code-shown (5) and code-hidden (4) cases, with and without the selection checkbox.
  • Narrow layout renders 3 cells against 4 columns, which is harmless: the grid tracks are only applied when !shouldUseNarrowTableLayout (TableRow.tsx:175), the header renders only the title on narrow (TableHeader.tsx:145), and semantics are off there.
  • Splitting one alternateText string into separate search fields is behavior-identical: tokenizedSearch flattens all fields into one token pool, so multi-token queries spanning name + rate + default still match (tokenizedSearch.ts:18).
  • The narrow-layout early return in resolveActiveSorting correctly stops a resize from discarding the user's sort: sorting by Tax code desc on wide → forced to name/asc on narrow → restored to Tax code desc on the way back.
  • The three-press header cycle still resets cleanly — columnKey: undefined is falsy, so the new fallback doesn't re-sort a table the user deliberately unsorted.
  • The WorkspaceMembersTable extraction into compareOptionalValues is behavior-identical to the four inlined blocks it replaces, including "missing values last in both directions" and the name tie-break.
  • Narrow-layout name supporting text (10% • Workspace currency default) and the narrow accessibility label both match the old alternateText exactly.
  • Header labels are measured in useDynamicColumnWidths, so shouldFitContent on Tax rate can't truncate the header; enabled/actions carry numeric widths and land in the fixed budget correctly.
  • workspace.taxes.taxRate and workspace.taxes.taxCode both exist in en and es; no new copy.
  • No existing test references the taxes table row shape, so nothing breaks on the alternateText → taxRateValue/taxCode/defaultLabel rename.

Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
@Krishna2323
Krishna2323 requested a review from JS00001 September 24, 2026 16:34
@JS00001
JS00001 merged commit 18c24b9 into Expensify:main Sep 24, 2026
34 of 35 checks passed
@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions

Copy link
Copy Markdown
Contributor

🚧 JS00001 has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/JS00001 in version: 9.4.94-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

MelvinBot commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

Yes, this PR needs a help site update. I created a draft docs PR: Docs updates for E/A#100710 Document Tax rate and Tax code columns on Taxes page.

The change updates docs/articles/new-expensify/workspaces/Track-Taxes.md:

  • Adds What each column on the Taxes page shows. It covers the Name, Tax rate, Tax code, and Enabled columns, sorting, the Find tax rate search box, and the narrow-screen layout.
  • Adds an FAQ entry that explains when Tax code is hidden: on non-Control workspaces, when no rate has a code, and on smaller screens.
  • Corrects UI labels in the same article to match the live UI, for example Organize (was Reports) and Add rate (was Add Rate).

I checked the labels against en.ts and a live web session on a EUR Control workspace.

@Krishna2323, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR Ready for review


view run · view recording

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/Julesssss in version: 9.4.94-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants