Repository navigation
Add Tax rate and Tax code columns to the workspace Taxes table - #100710
Conversation
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
🚧 shawnborton has triggered a test Expensify/App build. You can view the workflow run here. |
|
@Expensify/design I think this one is ready for a gander |
|
Oh, you beat me to it lol |
This comment has been minimized.
This comment has been minimized.
|
Otherwise tests well and looks good to me 👍 |
|
Ah I did not know those existed. Let's stick with the current implementation then 👍 |
|
@JS00001, who'll review this? |
|
Situ reviewed other table PRs, so they can probably help out here. @situchan wanna review? |
yes thanks |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e2ae5776ae
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
|
@situchan friendly bump |
|
Reviewing today |
|
@situchan all review comments addressed. |
|
Conflicts |
|
|
||
| const isItemInSearch: IsItemInSearchCallback<WorkspaceTaxTableRowData> = (item, searchValue) => { | ||
| const results = tokenizedSearch([item], searchValue, (option) => [option.name, option.alternateText]); | ||
| const searchableFields = [item.name, item.taxRateValue, ...(shouldSearchTaxCode ? [item.taxCode] : [])]; | ||
| const results = tokenizedSearch([item], searchValue, () => searchableFields); |
There was a problem hiding this comment.
Bug: searching the taxes list by the default indicator no longer works
bug.mov
|
🤖 Code review — 3 regressions worth fixing, plus a few things to confirm. TypeScript passes ( 1. Search no longer matches the default indicatorBefore,
2. Search results change when the window is resized
3. Page and table disagree on the breakpointThe page computes the flag with At medium widths Lower severity — worth a look
setUserSorting((previousSorting) => {
const resolved = resolveActiveSorting(shouldUseNarrowTableLayout, narrowLayoutSortColumn, previousSorting, columnKeys, initialSortColumn);
return {columnKey: columnKey ?? resolved.columnKey, order: resolved.order === 'asc' ? 'desc' : 'asc'};
});Fallback hard-codes
Tax code is blank for integration-imported rates.
Checked and clean
The branch is currently conflicting with |
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
… indicator Signed-off-by: krishna2323 <belivethatkg@gmail.com>
|
@situchan friendly bump |
| // A column that stops being rendered (e.g. a conditional column loses its last value) can leave the table sorted | ||
| // by a key no header shows an arrow for. Falling back to the initial column keeps the sort visible and correct. | ||
| if (userSorting.columnKey && !columnKeys.includes(userSorting.columnKey)) { | ||
| return {columnKey: initialSortColumn, order: 'asc'}; | ||
| } |
There was a problem hiding this comment.
Bug: The list re-orders to Name ascending. Not happening on staging.
The same thing happens on categories table
- Workspace with multi-level tags → Tags, browser wider than 1024px.
- Click the Tag count header to sort by it.
- Drag the window below 1024px.
Screen.Recording.2026-09-24.at.1.25.58.PM.mov
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
|
🤖 Re-reviewed at 1.
|
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 JS00001 has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/JS00001 in version: 9.4.94-0 🚀
|
|
Yes, this PR needs a help site update. I created a draft docs PR: Docs updates for E/A#100710 Document Tax rate and Tax code columns on Taxes page. The change updates
I checked the labels against @Krishna2323, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR |
|
🚀 Deployed to production by https://github.com/Julesssss in version: 9.4.94-0 🚀
Bundle Size Analysis (Sentry): |



Explanation of Change
Fixed Issues
$ #100587
PROPOSAL:
Tests
Name,Tax rate,Tax code,Enabled, and the caret. Rate values should be inTax rate, not under the name.9%and10%, verify ascending puts9%before10%, and clicking again reverses it.Tax codeis hidden. On Control with no customized codes, verify it's also hidden.10% • Workspace currency defaultunder the name, with noTax rate/Tax codecolumns or alignment issues.Delete/Enable/Disable, open the edit page, and verify offline pending/error states still work.Offline tests
QA Steps
Same as tests
Verify that no errors appear in the JS console
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
android_hybrid.mp4
Android: mWeb Chrome
android_mWeb.mp4
iOS: Native
ios_hybrid.mp4
iOS: mWeb Safari
ios_mWeb.mp4
MacOS: Chrome / Safari
web_chrome.mp4