Skip to content

[No QA] [Payment due @ikevin127] [No QA] Docs updates for E/A#100113 Correct bank account status badges and pending validation paths - #100750

Merged
strepanier03 merged 4 commits into
mainfrom
claude-docsPendingUsdBankAccountValidation
Sep 30, 2026
Merged

strepanier03 merged 4 commits into
mainfrom
claude-docsPendingUsdBankAccountValidation

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Explanation of Change

Help site follow-up for #100113, which made a pending USD bank account open Validate your bank account directly instead of painting the Continue setup / Start over entry point.

Reviewing docs/articles against that change surfaced two problems — one caused by the change, one a pre-existing inaccuracy in the same flow.

1. The Action required badge does not exist in the product.

Three articles told members to look for an Action required badge. That string appears nowhere in src/languages/en.ts. The real badges come from src/libs/BankAccountUtils.ts:88-125, and they differ by account state:

State Badge Message Action
SETUP Incomplete Finish adding bank account Finish
PENDING Pending Please confirm test transactions Confirm
VERIFYING Verifying We're reviewing your documentation —
LOCKED Locked This account requires attention Unlock

This mattered more than a naming nit: a member with a pending account was told to hunt for a badge that never renders, and the distinction between Incomplete (setup not submitted) and Pending (submitted, waiting on test transactions) is exactly what tells them whether there is any setup left to finish.

2. The workspace Workflows path was undocumented.

The redirect in #100113 is gated on !!policyIDParam && achData?.policyID === policyIDParam, so it covers the workspace entry point — Workspaces > [Workspace name] > Workflows > Payments. That path is the one that previously showed the Continue setup / Start over screen for a pending account, and no article described it; Validate-a-Business-Bank-Account.md documented only the Account > Wallet path. The Wallet entry points pass no policyID and are excluded from the redirect, but still reach validation, so both paths are now documented separately.

What changed

  • Validate-a-Business-Bank-Account.md — corrected the badge to Pending with its Please confirm test transactions message and Confirm action; named the amount fields Transaction 1, Transaction 2, Transaction 3 (connectBankAccountStep.validationInputLabel); added a ## How to validate a workspace business bank account from Workflows section; added a ## What happens when you open a pending US business bank account section explaining that setup is never re-offered, and why this is US-only; noted the Workspace Admin / Payments Admin requirement for the Workflows path; noted that Payments in Workflows is offline-disabled so Wallet is the offline route; fixed four Settings > Wallet references to Account > Wallet.
  • Connect-a-Business-Bank-Account.md — replaced the single "Partially set-up accounts display an Action required badge" sentence with the real four-state badge list, and pointed Pending at the validation article.
  • Share-a-Business-Bank-Account.md — corrected the same Action required claim for a shared US account.

Label verification

The app-web-tester session could not be used — its browser page never rendered (0 accessibility nodes, blank screenshots, zero network requests over ~100s), which looks like test-infra rather than a product bug. Every label below was instead verified against src/languages/en.ts and the components that render it, which is the source of truth for UI copy:

  • connectBankAccountStep.validateYourBankAccount → Validate your bank account, rendered as the header title for a pending account at ConnectBankAccount.tsx:130
  • connectBankAccountStep.validateButtonText → Validate
  • connectBankAccountStep.validationInputLabel → Transaction (fields render as Transaction 1–3)
  • walletPage.bankAccountStatus.* → Pending, Incomplete, Verifying, Finish, Unlock, Please confirm test transactions
  • walletPage.personalBankAccounts / businessBankAccounts → Personal bank accounts / Business bank accounts
  • workflowsPage.makeOrTrackPaymentsTitle → Payments; bankAccount.addBankAccount → Add bank account; workspace.common.workflows → Workflows
  • common.account → Account, common.wallet → Wallet (hence Account > Wallet, not Settings > Wallet)

Guidelines applied

HELP_AUTHORING_GUIDELINES.md, HELPSITE_NAMING_CONVENTIONS.md, and TEMPLATE.md: both new headings are task-based and start with a question word; only ## is used; every UI label is bolded, unquoted, and matches the product's capitalization; the Workflows section gives one unified navigation sentence since web and mobile differ only in tab placement; the one added screenshot placeholder uses the non-rendered HTML comment format and states the specific confusion it resolves. npm run spell-changed passes (3 files, 0 issues).

One pre-existing violation left in place: Validate-a-Business-Bank-Account.md has a third # heading (# Troubleshooting), which the spec allows only for the title and # FAQ. Fixing it means either demoting its children to a banned ### depth or splitting the article, so I left it rather than restructure an article beyond the scope of this change. Flagging it for a follow-up.

Fixed Issues

$
PROPOSAL:

Docs follow-up requested on #100113. There is no separate help site issue to link.

Tests

// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.

Reviewer note — this is a documentation-only change, so verification means confirming the copy matches the product. With a pending USD business bank account, check that: the Wallet row shows a Pending badge (not Action required), opening it from either Account > Wallet or Workspaces > [Workspace name] > Workflows > Payments lands on Validate your bank account, the three fields read Transaction 1–3, and the submit button reads Validate.

  • Verify that no errors appear in the JS console

Offline tests

Not applicable — this change only edits Markdown files under docs/articles and adds no app behavior.

QA Steps

// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@ikevin127, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying @MelvinBot mark this PR as ready for review.

…idation entry points

Co-authored-by: Kevin Brian Bader <ikevin127@users.noreply.github.com>
@MelvinBot
MelvinBot requested a review from a team September 9, 2026 19:57
@MelvinBot MelvinBot added the HelpDot Apply this label if the issue relates to ExpensifyHelp label Sep 9, 2026
@ikevin127

Copy link
Copy Markdown
Contributor

@MelvinBot mark this PR as ready for review.

@MelvinBot
MelvinBot marked this pull request as ready for review September 10, 2026 22:38
@melvin-bot

melvin-bot Bot commented Sep 10, 2026 •

Copy link
Copy Markdown

Concierge reviewer checklist:

  • I have verified the accuracy of the article
    • The article is within a hub that makes sense, and the navigation is correct
    • All processes, screenshots, and examples align with current product behavior.
    • All links within the doc have been verified for correct destination and functionality.
  • I have verified the readability of the article
    • The article's language is clear, concise, and free of jargon.
    • The grammar, spelling, and punctuation are correct.
    • The article contains at least one image, or that an image is not necessary
  • I have verified the formatting of the article
    • The article has consistent formatting (headings, bullet points, etc.) with other HelpDot articles and that aligns with the HelpDot formatting standards.
    • The article has proper text spacing and breaks for readability.
  • I have verified the article has the appropriate tone and style
    • The article's tone is professional, friendly, and suitable for the target audience.
    • The article's tone, terminology, and voice are consistent throughout.
  • I have verified the overall quality of the article
    • The article is not missing any information, nor does it contain redundant information.
    • The article fully addresses user needs.
  • I have verified that all requested improvements have been addressed

For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member?

cc @strepanier03

@MelvinBot

MelvinBot commented Sep 10, 2026 •

Copy link
Copy Markdown
Contributor Author

🤖 Done — this PR is now ready for review.

Checks: all passing except Check independent approval, which is expected on a draft-turned-ready PR and clears once a reviewer approves.

One thing left for you: the ### Tests and ### QA Steps sections still contain the // TODO: **The human co-author** must fill out... placeholders. I don't fill those in on someone's behalf, so please replace them before a reviewer picks this up. The reviewer note already in the Tests section covers what to check with a pending USD business bank account:

  • The Wallet row shows a Pending badge (not Action required)
  • Opening it from Account > Wallet or Workspaces > [Workspace name] > Workflows > Payments lands on Validate your bank account
  • The three fields read Transaction 1–3
  • The submit button reads Validate

The PR Author Checklist is also still unchecked.


view run · no recording available

@melvin-bot
melvin-bot Bot requested review from strepanier03 and removed request for a team September 10, 2026 22:38
@melvin-bot

melvin-bot Bot commented Sep 10, 2026

Copy link
Copy Markdown

@strepanier03 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@github-actions

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR corrects a factual error across three wallet-and-payments articles (a non-existent Action required badge) and replaces it with the real state-based badges (Incomplete, Pending, Verifying, Locked), then documents the previously-undocumented Workflows > Payments validation path for pending US business bank accounts. The changes are well-scoped, accurate to the product source of truth, and align closely with the HelpDot governance files.

Scores Summary

  • Readability: 9/10 - The badge list is scannable with bold labels mapped to clear actions and messages. New numbered steps are sequential, action-oriented, and match the actual UI flow. The two added explanatory sections are concise and benefit-focused.
  • AI Readiness: 9/10 - Both new headings are task-based and start with question words (## How to validate a workspace business bank account from Workflows, ## What happens when you open a pending US business bank account). Added content uses ## only. keywords and internalScope were updated to reflect the new Workflows workflow and the Pending badge / Please confirm test transactions search phrases. Full feature names used throughout.
  • Style Compliance: 9/10 - Excellent adherence to HELPSITE_NAMING_CONVENTIONS.md: all UI labels are bolded, unquoted, and match product capitalization; the Workflows navigation uses a single unified sentence (correct since web/mobile differ only in tab placement); the offline limitation on Payments is stated explicitly; Settings > Wallet corrected to Account > Wallet in four places; Workspace Name corrected to Workspace name. Cross-links use relative paths with descriptive anchor text and sit in explanatory sentences rather than inside step actions.

Key Findings

  • Strong correctness improvement: the removed Action required string does not exist in the product; the replacement badges and messages match BankAccountUtils.ts and en.ts.
  • The Incomplete vs Pending distinction is now explained clearly, which is exactly the distinction that tells a member whether setup remains.
  • The added SCREENSHOT placeholders follow the non-rendered HTML-comment format and state a specific confusion each resolves (distinguishing Incomplete/Pending; confirming the correct Workflows row).
  • Pre-existing # Troubleshooting third H1 in Validate-a-Business-Bank-Account.md violates the single-H1 rule, but it is outside this diff and correctly flagged for follow-up rather than restructured out of scope.

Recommendations

  • No blocking issues in the proposed changes. Optional: track the pre-existing # Troubleshooting H1 as a separate follow-up so it is not lost.
  • When screenshots are captured, ensure the Pending-badge callout images (_02/_03) reflect the corrected badge naming referenced in the alt text.

Files Reviewed

  • docs/articles/new-expensify/wallet-and-payments/Connect-a-Business-Bank-Account.md - Badge list corrected to the four real states with a validation cross-link. Compliant.
  • docs/articles/new-expensify/wallet-and-payments/Share-a-Business-Bank-Account.md - Action required claim corrected to Pending for shared US accounts. Compliant.
  • docs/articles/new-expensify/wallet-and-payments/Validate-a-Business-Bank-Account.md - New Workflows validation section, pending-account behavior section, corrected badges/fields/labels, and Settings > Wallet fixes. Compliant within the diff.

Note: Detailed line-by-line feedback has been provided as inline comments.

An account that still needs your attention displays a badge that tells you what is left to do:

- **Incomplete** with a **Finish** action means setup was not submitted. Click the account row to resume setup from where you left off.
- **Pending** with a **Please confirm test transactions** message and a **Confirm** action means the account was submitted and is waiting on test transactions. Click the account row to go straight to **Validate your bank account**. Learn how to [validate a business bank account](/articles/new-expensify/wallet-and-payments/Validate-a-Business-Bank-Account).

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cross-linking / link placement: This bullet mixes an action instruction ("Click the account row to go straight to Validate your bank account.") with an inline cross-link in the same item. Per HELP_AUTHORING_GUIDELINES.md (Link Formatting), links should follow explanatory sentences and not interrupt procedural/action flow. Consider moving the "Learn how to [validate a business bank account]" link to a separate explanatory sentence after the badge list.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8fd8f5f275

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

2. In the **Bank accounts** section, click the business bank account with the **Action required** badge.
3. In the **Validate your bank account** section that appears, enter each transaction amount.
2. In the **Bank accounts** section, click the business bank account with the **Pending** badge. It shows the message **Please confirm test transactions** and a **Confirm** action.
3. On the **Validate your bank account** screen that appears, enter each amount in **Transaction 1**, **Transaction 2**, and **Transaction 3**.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Document the Wallet intermediate screen for non-admins

For members without write access to the account's workspace—the group directed to use Account > Wallet above—WalletPage opens the account by bankAccountID because shouldOpenBankAccountByPolicy() returns false, while ReimbursementAccountPage requires a matching policyIDParam for the direct validation redirect. These members therefore see Continue setup and Start over, not this validation screen immediately, so the instructions omit the required Continue setup action.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MelvinBot Address this code comment accordingly.

@MelvinBot MelvinBot Sep 11, 2026 •

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The feedback is correct — fixed in a197bd8.

Opening a pending account from Account > Wallet only skips straight to validation when the account has a policyID and you can write to that workspace's Workflows/Payments feature. WalletPage/index.tsx:236-240 otherwise navigates by bankAccountID, which passes no policyID, so shouldRedirectToPendingValidation is false and the Continue setup / Start over entry point renders. That group was exactly the one the article told to use Account > Wallet, so the steps were missing the click they need.

What changed

  • Validate-a-Business-Bank-Account.md — added a step for the Continue setup screen in the Wallet flow, and rewrote What happens when you open a pending US business bank account to split the two cases instead of claiming both routes skip the entry point.
  • Connect-a-Business-Bank-Account.md, Share-a-Business-Bank-Account.md — same over-broad "goes straight to Validate your bank account" claim corrected.
Details
  • shouldOpenBankAccountByPolicy returns canMemberWrite(policy, login, WORKFLOWS_PAYMENTS) — WalletPage/utils.ts:9-17. It is also false when the account has no additionalData.policyID at all, so a business bank account not attached to a workspace hits the entry point too — the doc now covers that case, not just non-admins.
  • Continue setup is safe to click here: continueUSDVBBASetup maps achData.currentStep through stepToPageName, and a pending account's VALIDATION step maps to the validation page — ReimbursementAccountPage.tsx:536-553. No company or ownership details are re-asked, which is why the doc points at Continue setup and warns off Start over (bankAccount.clearProgress: "Starting over will clear the progress you've made so far.").
  • The Workflows section needed no change: that route always carries a policyID, and a member without Workflows/Payments write access gets the not-authorized screen there instead — ReimbursementAccountPage.tsx:652.
  • npm run spell-changed passes on all three files (0 issues). I did not verify this on a live account — reproducing it needs a real USD business bank account sitting in PENDING with test transactions issued, which is not something a test account can be driven into. The behavior above is read off the routing conditions rather than observed.

Separately, strepanier03's note on the other thread about the two screenshots still showing the old Action required badge is still open — I left those alone since they need new images rather than a text edit. Let me know if you want them removed pending replacements.


view run · no recording available

Comment on lines +45 to +47
![Account > Wallet > bank account with a callout on the Pending badge]({{site.url}}/assets/images/ExpensifyHelp-BetterBusinessBankAccount_02.png){:width="100%"}

![Account > Wallet > bank account with a Pending badge > expose validation pane]({{site.url}}/assets/images/ExpensifyHelp-BetterBusinessBankAccount_03.png){:width="100%"}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Replace screenshots that still show the obsolete badge

Both referenced PNGs still visibly display the old Action required badge (_02 prominently and _03 behind the validation pane); changing only their alt text does not update the rendered images. Since this change specifically explains that this badge does not exist and tells members to find Pending, the screenshots directly contradict the corrected instructions and should be replaced or removed.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good feedback and we should address the image if it's going to be outdated to the copy updates this PR is for.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@strepanier03 https://help.expensify.com/assets/images/ExpensifyHelp-BetterBusinessBankAccount_02.png resolves to:

Image

The OP issue's video shows Pending state like so:

Image

while the ExpensifyHelp-BetterBusinessBankAccount_02.png works for Action required badge (previous), it doesn't quite match for Pending state.

So I'm not sure who's supposed to help with these illustrations but that's what needs updated before merging this PR, let me know!

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replaced in 3789a00. The first Wallet screenshot (ExpensifyHelp-BetterBusinessBankAccount_02.png) now uses wallet-test-transactions.png, which shows the Pending badge and Confirm action. I also updated its alt text to match.

Two things to know:

  • ExpensifyHelp-BetterBusinessBankAccount_03.png (the validation pane) still shows a faded Action required badge behind the pane. Do you want a new version of that one too, or should I remove it?
  • The new image is on main but not on this branch, so the HelpDot preview may show it as broken. It will render on the help site after merge.

view run

@strepanier03

Copy link
Copy Markdown
Contributor

Review checklist is mostly done but I want to highlight the screenshot inconsistency and make sure it's handled in this or another PR before I approve.

…pened from Wallet

Co-authored-by: Kevin Brian Bader <ikevin127@users.noreply.github.com>
@github-actions github-actions Bot changed the title Docs updates for E/A#100113 Correct bank account status badges and pending validation paths [No QA] Docs updates for E/A#100113 Correct bank account status badges and pending validation paths Sep 11, 2026
@OSBotify

This comment has been minimized.

@strepanier03

Copy link
Copy Markdown
Contributor

I'm going to see if I can get the image using the extension.

@strepanier03

Copy link
Copy Markdown
Contributor

Actually, I don't know how to get this image because I don't have an account with this type of setup. I think we might need to ask @Expensify/design for some help recreating the original image with the new button and UI.

@dubielzyk-expensify

Copy link
Copy Markdown
Contributor

Happy to help. What specifically do you need?

@ikevin127

Copy link
Copy Markdown
Contributor

@dubielzyk-expensify Checkout this comment 🙌

@dubielzyk-expensify

dubielzyk-expensify commented Sep 15, 2026 •

Copy link
Copy Markdown
Contributor

Yeah, I saw that, was hoping for some more clarification. So we want this visual here:
CleanShot 2026-09-15 at 2 10 06 PM@2x

inserted in here?

CleanShot 2026-09-15 at 2 10 20 PM@2x

Cause the comment above shows two different screens.

@ikevin127

Copy link
Copy Markdown
Contributor

@dubielzyk-expensify Yes, we want that UI with the error / Confirm badge as opposed to the green Action required badge.

@strepanier03

Copy link
Copy Markdown
Contributor

Added you @dubielzyk-expensify for the images, thank you again!

@dubielzyk-expensify

Copy link
Copy Markdown
Contributor

What about this?

image

@dannymcclain

Copy link
Copy Markdown
Contributor

Ugh mono looks so good and I still think it's a pity that we don't use it more 🤣

@ikevin127

Copy link
Copy Markdown
Contributor

@dubielzyk-expensify Thanks for the artwork - looks great. Before I ask Melvin to update the docs in this PR, can we get the URL for this image uploaded at this location (e.g https://help.expensify.com/assets/images/ExpensifyHelp-BetterBusinessBankAccount_02.png) - like wherever this assets/images location is served at the https://help.expensify.com domain, that's where we need to have the new one so I can referece it in code as:

  • e.g. ![Account > Wallet > bank account with a Pending badge > expose validation pane]({{site.url}}/assets/images/ExpensifyHelp-BetterBusinessBankAccount_03.png){:width="100%"}

@dubielzyk-expensify

Copy link
Copy Markdown
Contributor

I believe that's where @stephanieelliott comes in? I've never uploaded these but here's the file if Stephanie can help 😇

wallet-test-transactions.png.zip

@stephanieelliott

Copy link
Copy Markdown
Contributor

Added the file here: docs/assets/images/wallet-test-transactions.png

Heads up there are instructions for adding images on the README.md file 😀 https://github.com/Expensify/App/tree/main/docs#add-images

…e and Confirm action

Co-authored-by: Kevin Brian Bader <ikevin127@users.noreply.github.com>
@ikevin127

Copy link
Copy Markdown
Contributor

@MelvinBot Merge main to resolve conflicts, then explain how come the https://raw.githubusercontent.com/Expensify/App/refs/heads/main/docs/assets/images/wallet-test-transactions.png url was added as {{site.url}}/assets/images/wallet-test-transactions.png in the docs and explain how the main branch docs translates to the https://help.expensify.com assets direct image url.

…BankAccountValidation

Co-authored-by: Kevin Brian Bader <ikevin127@users.noreply.github.com>

# Conflicts:
#	docs/articles/new-expensify/wallet-and-payments/Connect-a-Business-Bank-Account.md
#	docs/articles/new-expensify/wallet-and-payments/Share-a-Business-Bank-Account.md
#	docs/articles/new-expensify/wallet-and-payments/Validate-a-Business-Bank-Account.md
@MelvinBot

Copy link
Copy Markdown
Contributor Author

Merged main in 6ef9887. The PR is mergeable again.

Why {{site.url}}/assets/images/...: The raw.githubusercontent.com link is just GitHub serving the file docs/assets/images/wallet-test-transactions.png from main. The help site is a Jekyll site built from docs/, so every file in docs/ is published at the same relative path under help.expensify.com. {{site.url}} is set to https://help.expensify.com, so the image path becomes https://help.expensify.com/assets/images/wallet-test-transactions.png. That URL returns the same file today (200, 73,554 bytes). This is the documented way to add images.

How docs/ on main becomes help.expensify.com
  1. docs/_config.yml:4 sets url: https://help.expensify.com, which is what {{site.url}} renders to.
  2. docs/README.md:162-164 says to put images in docs/assets/images/ and reference them as {{site.url}}/assets/images/<name>.png.
  3. deployExpensifyHelp.yml:5-10 runs on every push to main that changes docs/**.
  4. deployExpensifyHelp.yml:68-70 builds docs/ into docs/_site. Jekyll copies docs/assets/images/x.png to _site/assets/images/x.png unchanged.
  5. deployExpensifyHelp.yml:74-89 deploys _site to the helpdot Cloudflare Pages project and purges the help.expensify.com cache.

The image was uploaded to main in a87427c, which triggered that deploy. Because site.url is hardcoded, PR preview builds also load images from help.expensify.com. So the new screenshot already shows in the preview. That corrects my earlier note that it might appear broken.

How the conflicts were resolved

main had made overlapping badge edits to all three articles.

  • Validate-a-Business-Bank-Account.md: kept this PR's steps, Workflows section, and new screenshot. Used main's wording for step 2: "find the account with the Pending badge and the message Please confirm test transactions, then click Confirm." This matches the new screenshot.
  • Share-a-Business-Bank-Account.md: kept this PR's version, which already includes everything main added.
  • Connect-a-Business-Bank-Account.md: kept this PR's four-badge list, and added main's Active badge, Finish adding bank account message, and "Learn what each bank account connection status means" link.

One thing to check: main links to /articles/new-expensify/wallet-and-payments/Check-Bank-Account-and-Card-Connection-Status, but that article doesn't exist on main yet. I kept the link as main has it (Set-up-your-wallet.md uses it too). It will be broken until that article is published.


view run

@ikevin127 ikevin127 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 LGTM - Thanks for the /docs/ upload guide, will use that moving forward 🙌

@melvin-bot melvin-bot Bot changed the title [No QA] Docs updates for E/A#100113 Correct bank account status badges and pending validation paths [Payment due @ikevin127] [No QA] Docs updates for E/A#100113 Correct bank account status badges and pending validation paths Sep 29, 2026
@melvin-bot

melvin-bot Bot commented Sep 29, 2026

Copy link
Copy Markdown

🎯 @ikevin127, thanks for reviewing and testing this PR! 🎉

A payment issue will be created for your review once this PR is deployed to production.
E/E issue linked to the PR - no internal issue.

If payment is not needed (e.g., regression PR review fix etc), react with 👎 to this comment to prevent the payment issue from being created.

@github-actions github-actions Bot changed the title [Payment due @ikevin127] [No QA] Docs updates for E/A#100113 Correct bank account status badges and pending validation paths [No QA] [Payment due @ikevin127] [No QA] Docs updates for E/A#100113 Correct bank account status badges and pending validation paths Sep 29, 2026
@OSBotify

Copy link
Copy Markdown
Contributor

@strepanier03 strepanier03 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-reviewed the changes and then reviewed the new builds as well. Looking solid.

@strepanier03
strepanier03 merged commit c550884 into main Sep 30, 2026
24 of 26 checks passed
@strepanier03
strepanier03 deleted the claude-docsPendingUsdBankAccountValidation branch September 30, 2026 20:12
@OSBotify

OSBotify commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/strepanier03 in version: 9.5.0-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@melvin-bot

melvin-bot Bot commented Oct 1, 2026

Copy link
Copy Markdown

🤖 Payment issue created: #102817

@OSBotify

OSBotify commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/Julesssss in version: 9.5.0-5 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 failure ❌

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants