Repository navigation
Extract shared Intl.Collator into CollatorUtils - #100944
Conversation
|
@codex review |
|
Codex Review: Didn't find any major issues. 🚀 Reviewed commit: ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
|
⏱️ Ran out of time before I could finish. This usually means the task was too complex or I got stuck exploring. Please try again with a more specific request or post in #melvinbot-ai. |
|
@thelullabyy Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / SafariScreen.Recording.2026-09-14.at.19.59.07.mov |
|
Please merge main so we can pass the PR Reviews with Claude Code failure @sosek108 |
|
main merged @thelullabyy |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.4.78-0 🚀
|
|
🤖 No help site changes are required for this PR. This is an internal-only refactor. It extracts the existing
The PR description confirms the intent: "No behavior change otherwise — all three call sites keep the same Because no changes are required, I did not create a draft PR. If a later slice of the @sosek108, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR view run · no recording available |
|
🚀 Deployed to production by https://github.com/luacmartins in version: 9.4.78-3 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Prep slice 1 of 4 decomposing #99062 (Route Search previews through the shared LHN alternate text pipeline). This slice only extracts the shared
Intl.Collatorconstruction into a newCollatorUtils.getCollator(locale)helper, ahead of the actual pipeline change.Behavioral note: in
LocaleContextProvider, this replaces a per-rendernew Intl.Collator(...)with a shared cached instance.Intl.Collator#compareis stateless, so sharing the instance across renders/locales is safe, and the now-stable identity helps downstream memoization.No behavior change otherwise — all three call sites keep the same
COLLATOR_OPTIONS, just sourced from one place.Fixed Issues
$ #98958
PROPOSAL:
Tests
Offline tests
N/A — pure refactor of locale-aware string comparison, no network interaction.
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari