Repository navigation
Conversation
|
@codex review |
|
Codex Review: Didn't find any major issues. Swish! Reviewed commit: ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
|
@thelullabyy Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
⏱️ Ran out of time before I could finish. This usually means the task was too complex or I got stuck exploring. Please try again with a more specific request or post in #melvinbot-ai. |
dylanexpensify
left a comment
There was a problem hiding this comment.
Refactor, no product input needed
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / SafariScreen.Recording.2026-09-15.at.18.35.54.mov |
mountiny
left a comment
There was a problem hiding this comment.
Thanks, just one NAB that you can add in next pr if you agree
There was a problem hiding this comment.
Can you add unit test for getExpensifyCardFromReportAction?
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.4.81-0 🚀
|
|
🤖 No help site changes are required for this PR. This is an internal refactor with no user-facing change. It moves the Expensify Card lookup out of the What I checkedFiles changed (2, both source):
No changes to Help site search: I searched Because no article needs an edit, I did not open a draft help site PR. The parent work (Route Search previews through the shared LHN alternate text pipeline) may still be worth a docs pass if it changes what users actually see in Search previews — re-run this check on the slice that lands that change. @sosek108, there is no linked help site PR to review because no article needed an edit. If you disagree and think an article does need updating, reply with which one and I'll open the draft PR. |
|
Hi @sosek108. Can you please share more detailed steps for QA? |
|
Hi @IuliiaHerets, sorry for the thin steps. This is a pure refactor of how an Expensify Card is looked up for a "card issued" report action, so QA is regression-only. Detailed steps: Setup
Test 1 — card issued message as the assignee (non-admin path)
Test 2 — same message as workspace admin (admin path)
Test 3 — Travel Billing feed
Test 5 — context menu
Expected everywhere: identical behavior to production — no missing card name, no console errors. |
|
@mountiny @francoisl We are trying to run this complex scenario and team is working to see if we have all the right accounts and prerequisites. |
|
This PR failing because of the issue #101455 |
|
@mvtglobally You can check this off, it is simple refactoring so I think we are safe here |
|
🚀 Deployed to production by https://github.com/luacmartins in version: 9.4.81-1 🚀
|
1 similar comment
|
🚀 Deployed to production by https://github.com/luacmartins in version: 9.4.81-1 🚀
|
Explanation of Change
Prep slice 3 of 4 decomposing #99062 (Route Search previews through the shared LHN alternate text pipeline). This slice only extracts the Expensify-card lookup out of
useGetExpensifyCardFromReportActioninto a pure function, ahead of the actual pipeline change that needs to call it from non-React code.Fixed Issues
$ #98958
PROPOSAL:
Tests
Cannot test this manually as I don't have access to Expensify Cards feature
npm run test tests/unit/useGetExpensifyCardFromReportActionTest.tsOffline tests
N/A — pure refactor of an Onyx-collection lookup, no network interaction.
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari