Repository navigation
Conversation
|
@MelvinBot review |
|
Codex Review: Didn't find any major issues. 🚀 Reviewed commit: ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
|
@thelullabyy Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
🤖 Review: LGTM — the refactor is behavior-preserving. Two non-blocking follow-ups below. The extracted 1. A third copy of this logic is still hand-rolled
2. No test covers a non-
|
|
⏱️ Ran out of time before I could finish. This usually means the task was too complex or I got stuck exploring. Please try again with a more specific request or post in #melvinbot-ai. |
|
No product review needed. |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / SafariScreen.Recording.2026-09-14.at.19.59.07.mov |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
🚧 francoisl has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/francoisl in version: 9.4.80-0 🚀
|
|
No help site changes are required for this PR, so I did not create a docs PR. This is an internal refactor with no user-facing change. It renames Nothing in What I checkedFiles changed (2, both internal TypeScript):
No docs triggers present: no new or renamed feature, no new setting, tab, or button, no changed UI label, no changed workflow or permission, and no changed user-visible output. Every existing caller still formats with Help site search: I searched Worth noting for the follow-up slices: this is slice 2 of 4 prepping Last message preview text is inconsistent between LHN and the Search / Chat Switcher list. The later slices change what users actually see in previews. Those are still unlikely to need docs, since the help site doesn't document preview text, but they're the ones worth re-checking. @sosek108 — since no docs changes were needed, there's no help site PR to review. If you think an article should cover this and I missed it, reply with |
|
🚀 Deployed to production by https://github.com/luacmartins in version: 9.4.80-0 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Prep slice 2 of 4 decomposing #99062 (Route Search previews through the shared LHN alternate text pipeline). This slice only generalizes the currency formatting helper, ahead of the actual pipeline change.
No behavior change: every existing caller goes through the unchanged
…EnLocalewrapper and still formats withen.Fixed Issues
$ #98958
PROPOSAL:
Tests
en, unchanged.Offline tests
N/A — pure refactor of currency string formatting, no network interaction.
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Nagranie.z.ekranu.2026-09-11.o.14.12.51.mov