Repository navigation
[No QA] Docs updates for E/A#99236 Workspace change now requires Save button - #101009
Conversation
Co-authored-by: truph01 <truph01@users.noreply.github.com>
|
A preview of your ExpensifyHelp changes have been deployed to https://f972575b.helpdot.pages.dev ⚡️ Updated articles: |
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? |
|
@truph01 @brianlee-expensify One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
HelpDot Documentation Review Overall Assessment Scores Summary
Key Findings
Recommendations
Files Reviewed
Note: This review covers only the proposed diff, not unchanged article content. |
|
🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.4.95-0 🚀
|
|
🚀 Deployed to production by https://github.com/Julesssss in version: 9.4.95-4 🚀
|
Explanation of Change
Help site follow-up for #99236, which gated the workspace pickers behind a Save button for WCAG 3.2.2 "On Input". Tapping a workspace row no longer commits the change or navigates away — the pick is staged and only applied when the user presses Save.
Two help articles documented the old behavior, implying the report moved as soon as Change workspace was tapped. Both now include the Save step:
docs/articles/new-expensify/reports-and-expenses/Understanding-Report-Statuses-and-Actions.md— the "Moving Expenses or Reports" instruction now says to tap the workspace and then tap Save, and states the report does not move until Save is tapped. The IOU sender bullet and the IOU FAQ answer were updated the same way.docs/articles/new-expensify/reports-and-expenses/Create-and-Submit-Reports.md— the "switch workspaces" note now includes selecting the workspace and then selecting Save.The same file also referred to the menu option as "Change Workspace" in five places. The live UI label is Change workspace (sentence case), so those were corrected per
docs/HELPSITE_NAMING_CONVENTIONS.md, which requires exact UI capitalization.Labels were verified against the running app, not inferred from code: the report More menu option is Change workspace, the picker screen header is Change workspace, and the bottom button is Save, disabled until the tapped row differs from the current workspace.
No changes were needed for the other two pickers touched by #99236. The domain group Preferred workspace picker and the default workspace picker have no step-by-step coverage in
docs/articles, so nothing there describes the old immediate-commit behavior.Expense-and-Report-Actions.mdwas also left alone — its action tables describe outcomes ("Moves the report to another workspace"), which is still accurate.Fixed Issues
$ #74834
PROPOSAL:
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review".
Offline tests
QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review", or the PR title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
@truph01, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.