Skip to content

[No QA] Docs updates for E/A#99236 Workspace change now requires Save button - #101009

Merged
stephanieelliott merged 1 commit into
mainfrom
claude-docs-workspace-picker-save
Sep 28, 2026
Merged

stephanieelliott merged 1 commit into
mainfrom
claude-docs-workspace-picker-save

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Explanation of Change

Help site follow-up for #99236, which gated the workspace pickers behind a Save button for WCAG 3.2.2 "On Input". Tapping a workspace row no longer commits the change or navigates away — the pick is staged and only applied when the user presses Save.

Two help articles documented the old behavior, implying the report moved as soon as Change workspace was tapped. Both now include the Save step:

  • docs/articles/new-expensify/reports-and-expenses/Understanding-Report-Statuses-and-Actions.md — the "Moving Expenses or Reports" instruction now says to tap the workspace and then tap Save, and states the report does not move until Save is tapped. The IOU sender bullet and the IOU FAQ answer were updated the same way.
  • docs/articles/new-expensify/reports-and-expenses/Create-and-Submit-Reports.md — the "switch workspaces" note now includes selecting the workspace and then selecting Save.

The same file also referred to the menu option as "Change Workspace" in five places. The live UI label is Change workspace (sentence case), so those were corrected per docs/HELPSITE_NAMING_CONVENTIONS.md, which requires exact UI capitalization.

Labels were verified against the running app, not inferred from code: the report More menu option is Change workspace, the picker screen header is Change workspace, and the bottom button is Save, disabled until the tapped row differs from the current workspace.

No changes were needed for the other two pickers touched by #99236. The domain group Preferred workspace picker and the default workspace picker have no step-by-step coverage in docs/articles, so nothing there describes the old immediate-commit behavior. Expense-and-Report-Actions.md was also left alone — its action tables describe outcomes ("Moves the report to another workspace"), which is still accurate.

Fixed Issues

$ #74834
PROPOSAL:

Tests

// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review".

  • Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review", or the PR title must include "[No QA]."

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@truph01, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying @MelvinBot mark this PR as ready for review.

Co-authored-by: truph01 <truph01@users.noreply.github.com>
@MelvinBot
MelvinBot requested a review from a team September 11, 2026 22:14
@MelvinBot MelvinBot added the HelpDot Apply this label if the issue relates to ExpensifyHelp label Sep 11, 2026
@github-actions github-actions Bot changed the title Docs updates for E/A#99236 Workspace change now requires Save button [No QA] Docs updates for E/A#99236 Workspace change now requires Save button Sep 11, 2026
@OSBotify

Copy link
Copy Markdown
Contributor

@melvin-bot

melvin-bot Bot commented Sep 28, 2026

Copy link
Copy Markdown

Concierge reviewer checklist:

  • I have verified the accuracy of the article
    • The article is within a hub that makes sense, and the navigation is correct
    • All processes, screenshots, and examples align with current product behavior.
    • All links within the doc have been verified for correct destination and functionality.
  • I have verified the readability of the article
    • The article's language is clear, concise, and free of jargon.
    • The grammar, spelling, and punctuation are correct.
    • The article contains at least one image, or that an image is not necessary
  • I have verified the formatting of the article
    • The article has consistent formatting (headings, bullet points, etc.) with other HelpDot articles and that aligns with the HelpDot formatting standards.
    • The article has proper text spacing and breaks for readability.
  • I have verified the article has the appropriate tone and style
    • The article's tone is professional, friendly, and suitable for the target audience.
    • The article's tone, terminology, and voice are consistent throughout.
  • I have verified the overall quality of the article
    • The article is not missing any information, nor does it contain redundant information.
    • The article fully addresses user needs.
  • I have verified that all requested improvements have been addressed

For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member?

cc @brianlee-expensify

@melvin-bot
melvin-bot Bot requested review from brianlee-expensify and truph01 and removed request for a team September 28, 2026 03:51
@melvin-bot

melvin-bot Bot commented Sep 28, 2026

Copy link
Copy Markdown

@truph01 @brianlee-expensify One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ⚠️ Failed 2026-09-28T04:21:25.572203Z 4064dc0 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment
This PR is a focused help-site follow-up to #99236, which gated the workspace pickers behind a Save button (WCAG 3.2.2 "On Input"). The changes are small and surgical (+7 / -7 across two articles) and do two things: (1) correct the UI label "Change Workspace" to sentence-case "Change workspace" in five places, and (2) add the new Save confirmation step so the docs match the current staged-then-committed behavior. All changes are diff-scoped edits to existing sentences and lists; no headings, metadata, or structure were touched.

Scores Summary

  • Readability: 9/10 - Edits are clear, sequential, and action-oriented. The added clause "The report does not move until you tap Save" is a strong readability win that sets correct expectations.
  • AI Readiness: 9/10 - Changes use UI-exact labels and reinforce a single workflow. The updated text improves retrievability by describing the full tap -> select -> Save sequence. No metadata or heading changes were in scope, so nothing regressed.
  • Style Compliance: 10/10 - Exactly on target. Corrects capitalization to match the live UI ("Change workspace"), bolds all button and menu names (Save, Change workspace), and avoids quotation marks around labels, per HELPSITE_NAMING_CONVENTIONS.md Core UI Referencing Rules and Button Naming Standards.

Key Findings

  • Sentence-case fix ("Change Workspace" -> "Change workspace") is applied consistently across all five occurrences, satisfying the "match capitalization exactly" rule.
  • The new Save step is added everywhere the old immediate-commit behavior was implied: the Moving Expenses instruction, the IOU-as-Sender bullet, and the IOU FAQ answer. Coverage is complete and consistent.
  • Button and menu names are correctly bolded and unquoted throughout.
  • The FAQ answer edit stays within the FAQ section convention and reads cleanly.
  • Minor observation only (pre-existing, not introduced by this PR): the articles mix "Tap" and "Select" phrasing; the diff follows each files existing verb convention, so this is acceptable and not a regression.

Recommendations

  • No blocking changes required. The diff is accurate, consistent, and compliant with all three governance docs.
  • Optional: confirm the picker header and label casing against the live UI one final time before merge (the PR description states this was already verified against the running app).

Files Reviewed

  • docs/articles/new-expensify/reports-and-expenses/Understanding-Report-Statuses-and-Actions.md - Approved. Five label corrections plus Save-step additions in the More-menu list, Moving Expenses instruction, IOU sender bullet, and IOU FAQ answer.
  • docs/articles/new-expensify/reports-and-expenses/Create-and-Submit-Reports.md - Approved. Switch-workspaces note updated to include selecting the workspace and then Save.

Note: This review covers only the proposed diff, not unchanged article content.

@stephanieelliott
stephanieelliott merged commit 597d8e0 into main Sep 28, 2026
20 of 21 checks passed
@stephanieelliott
stephanieelliott deleted the claude-docs-workspace-picker-save branch September 28, 2026 03:54
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.4.95-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/Julesssss in version: 9.4.95-4 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 failure ❌
🍎 iOS 🍎 failure ❌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants