Repository navigation
[No QA] Docs updates for E/A#99695 document over-limit approver change messages in #admins - #101145
Conversation
Adds the #admins system messages posted when the over-limit Additional approver or Report amount changes, documents Remove limit, and bolds UI labels per naming conventions. Co-authored-by: rayane-d <rayane-d@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
| - `set the approval workflow for approver@company.com to forward reports over $100.00 to second-approver@company.com` | ||
| - `changed the approval workflow for approver@company.com to forward reports over $200.00 (previously $100.00)` | ||
| - `changed the approval workflow for approver@company.com to forward reports over $200.00 to new-approver@company.com (previously forwarded to second-approver@company.com)` | ||
| - `changed the approval workflow for approver@company.com to stop forwarding reports over $200.00 (previously forwarded to second-approver@company.com)` | ||
|
|
||
| Changing the **Report amount** and the **Additional approver** in the same save posts one message covering both changes. Amounts use the workspace's report currency. |
There was a problem hiding this comment.
@stephanieelliott do you think writing out these example workspace change log messages adds value? I guess it could help if an admin is struggling to find it, and asks Concierge. That seems unlikely, since these messages are pretty straightforward.
There was a problem hiding this comment.
I agree with you -- I think these are just noise. I'll remove this section
|
@MelvinBot resolve the merge conflicts and merge the main branch into this branch |
…t-approver-changelog # Conflicts: # docs/articles/new-expensify/workspaces/Add-Approvals.md
|
🤖 Merged There was one conflict, in the What main brought in, and why nothing from this PR was lostThe rest of the article auto-merged. Main's changes to it since this branch was cut:
Those touch different lines than this PR's additions, so both survive. I confirmed against the branch tip that every section this PR adds is still present after the merge:
One note on the PR description: it lists a section named "What happens after you change the over-limit Additional approver or Report amount". That section does not exist on the branch — it was already replaced by the Where can I see who changed the over-limit approver or threshold? FAQ entry in an earlier commit on this branch, before I touched anything. The merge did not remove it. You may want to update the description so it matches the files changed. Verification: no conflict markers remain, the front matter still parses as a single well-formed The PR shows as |
|
A preview of your ExpensifyHelp changes have been deployed to https://181de4ab.helpdot.pages.dev ⚡️ Updated articles: |
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? |
|
@CortneyOfstad Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Courtney doesn't need to review, I've already done it. |
HelpDot Documentation ReviewOverall AssessmentThis PR makes targeted, high-quality improvements to a single article, Scores Summary
Key Findings
Recommendations
Files Reviewed
Note: Detailed line-by-line feedback has been provided as inline comments. |
|
🚀 Deployed to staging by https://github.com/sakluger in version: 9.4.94-0 🚀
|
|
🚀 Deployed to production by https://github.com/Julesssss in version: 9.4.94-0 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Help site updates for the new policy change log report actions rendered in #99695 (
POLICYCHANGELOG_UPDATE_OVER_LIMIT_FORWARDS_TOandPOLICYCHANGELOG_UPDATE_APPROVAL_LIMIT).Before that PR, changing the over-limit Additional approver or the Report amount left no visible trace for admins. Now NewDot renders a system message in the workspace #admins room for every such change, and the help site didn't mention it.
docs/articles/new-expensify/workspaces/Add-Approvals.mdalready documented how to set an over-limit approver, so this PR extends that article rather than adding a new one.Changes to
docs/articles/new-expensify/workspaces/Add-Approvals.md:Reports above $100.00 forward to ...).docs/HELPSITE_NAMING_CONVENTIONS.md.All UI labels were verified against the live app on web: the toggle is Approvals, the row is Add approval workflow, the fields are Report amount and Additional approver, the clear action is Remove limit, and the row hint reads
Reports above $100.00 forward to <email>.Fixed Issues
$ https://github.com/Expensify/Expensify/issues/668648
PROPOSAL:
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
Offline tests
N/A — documentation only.
QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
@rayane-d, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.