Skip to content

[No QA] Docs updates for E/A#99695 document over-limit approver change messages in #admins - #101145

Merged
sakluger merged 3 commits into
mainfrom
melvin-docs-over-limit-approver-changelog
Sep 24, 2026
Merged

sakluger merged 3 commits into
mainfrom
melvin-docs-over-limit-approver-changelog

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Explanation of Change

Help site updates for the new policy change log report actions rendered in #99695 (POLICYCHANGELOG_UPDATE_OVER_LIMIT_FORWARDS_TO and POLICYCHANGELOG_UPDATE_APPROVAL_LIMIT).

Before that PR, changing the over-limit Additional approver or the Report amount left no visible trace for admins. Now NewDot renders a system message in the workspace #admins room for every such change, and the help site didn't mention it. docs/articles/new-expensify/workspaces/Add-Approvals.md already documented how to set an over-limit approver, so this PR extends that article rather than adding a new one.

Changes to docs/articles/new-expensify/workspaces/Add-Approvals.md:

  • New section What happens after you change the over-limit Additional approver or Report amount documenting the #admins system messages, with example wording taken from the shipped copy, plus a note that changing the amount and the approver in one save posts a single message.
  • New section How to change or remove the over-limit Additional approver documenting Remove limit, which was previously undocumented.
  • Added the hint text that appears on the approver row once a limit is set (Reports above $100.00 forward to ...).
  • New FAQ entry Where can I see who changed the over-limit approver or threshold?
  • Bolded the Report amount and Additional approver labels that were plain text, per docs/HELPSITE_NAMING_CONVENTIONS.md.
  • Added keywords for the new search intents (remove limit, approval workflow change message, admins room system message).

All UI labels were verified against the live app on web: the toggle is Approvals, the row is Add approval workflow, the fields are Report amount and Additional approver, the clear action is Remove limit, and the row hint reads Reports above $100.00 forward to <email>.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/668648
PROPOSAL:

Tests

// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.

  • Verify that no errors appear in the JS console

Offline tests

N/A — documentation only.

QA Steps

// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@rayane-d, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying @MelvinBot mark this PR as ready for review.

Adds the #admins system messages posted when the over-limit Additional approver or Report amount changes, documents Remove limit, and bolds UI labels per naming conventions.

Co-authored-by: rayane-d <rayane-d@users.noreply.github.com>
@MelvinBot
MelvinBot requested a review from a team September 15, 2026 01:49
@MelvinBot MelvinBot added the HelpDot Apply this label if the issue relates to ExpensifyHelp label Sep 15, 2026
@rayane-d
rayane-d requested a review from sakluger September 15, 2026 01:51
@github-actions github-actions Bot changed the title Docs updates for E/A#99695 document over-limit approver change messages in #admins [No QA] Docs updates for E/A#99695 document over-limit approver change messages in #admins Sep 15, 2026
@OSBotify

This comment has been minimized.

Comment on lines +104 to +109
- `set the approval workflow for approver@company.com to forward reports over $100.00 to second-approver@company.com`
- `changed the approval workflow for approver@company.com to forward reports over $200.00 (previously $100.00)`
- `changed the approval workflow for approver@company.com to forward reports over $200.00 to new-approver@company.com (previously forwarded to second-approver@company.com)`
- `changed the approval workflow for approver@company.com to stop forwarding reports over $200.00 (previously forwarded to second-approver@company.com)`

Changing the **Report amount** and the **Additional approver** in the same save posts one message covering both changes. Amounts use the workspace's report currency.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stephanieelliott do you think writing out these example workspace change log messages adds value? I guess it could help if an admin is struggling to find it, and asks Concierge. That seems unlikely, since these messages are pretty straightforward.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with you -- I think these are just noise. I'll remove this section

@rayane-d

Copy link
Copy Markdown
Contributor

@MelvinBot resolve the merge conflicts and merge the main branch into this branch

…t-approver-changelog

# Conflicts:
#	docs/articles/new-expensify/workspaces/Add-Approvals.md
@MelvinBot

Copy link
Copy Markdown
Contributor Author

🤖 Merged main into this branch and resolved the conflict. The PR is now mergeable (41a1d7a).

There was one conflict, in the keywords front matter of docs/articles/new-expensify/workspaces/Add-Approvals.md:4. Both sides appended terms to the same line, so I kept the union — this branch's remove limit, remove approval limit, approval workflow change message, admins room system message plus main's import workflows, import approval workflows, bulk approval workflows, spreadsheet import. No keyword was dropped and none are duplicated.

What main brought in, and why nothing from this PR was lost

The rest of the article auto-merged. Main's changes to it since this branch was cut:

  • Workflows page was split into tabs, so several steps now say "Open the Approvals tab…" / "On the Advanced tab of the Workflows page…".
  • A new section, How to import approval workflows from a spreadsheet.

Those touch different lines than this PR's additions, so both survive. I confirmed against the branch tip that every section this PR adds is still present after the merge:

  • How to change or remove the over-limit Additional approver (documents Remove limit)
  • The Reports above $100.00 forward to … row hint
  • FAQ: Where can I see who changed the over-limit approver or threshold?
  • The bolded Report amount / Additional approver labels

One note on the PR description: it lists a section named "What happens after you change the over-limit Additional approver or Report amount". That section does not exist on the branch — it was already replaced by the Where can I see who changed the over-limit approver or threshold? FAQ entry in an earlier commit on this branch, before I touched anything. The merge did not remove it. You may want to update the description so it matches the files changed.

Verification: no conflict markers remain, the front matter still parses as a single well-formed keywords: list, and docs/articles/new-expensify/workspaces/Add-Approvals.md is the only file this branch changes relative to main. I could not run the local cspell pass or drive the app in a browser in this environment — CI's spell check will cover the front-matter line, and since this is a docs-only merge with no new prose, there is nothing to verify in the UI.

The PR shows as BLOCKED only because it's still awaiting review and the author checklist, not because of the merge.

@OSBotify

Copy link
Copy Markdown
Contributor

A preview of your ExpensifyHelp changes have been deployed to https://181de4ab.helpdot.pages.dev ⚡️

Updated articles:

@sakluger
sakluger marked this pull request as ready for review September 24, 2026 18:28
@melvin-bot

melvin-bot Bot commented Sep 24, 2026

Copy link
Copy Markdown

Concierge reviewer checklist:

  • I have verified the accuracy of the article
    • The article is within a hub that makes sense, and the navigation is correct
    • All processes, screenshots, and examples align with current product behavior.
    • All links within the doc have been verified for correct destination and functionality.
  • I have verified the readability of the article
    • The article's language is clear, concise, and free of jargon.
    • The grammar, spelling, and punctuation are correct.
    • The article contains at least one image, or that an image is not necessary
  • I have verified the formatting of the article
    • The article has consistent formatting (headings, bullet points, etc.) with other HelpDot articles and that aligns with the HelpDot formatting standards.
    • The article has proper text spacing and breaks for readability.
  • I have verified the article has the appropriate tone and style
    • The article's tone is professional, friendly, and suitable for the target audience.
    • The article's tone, terminology, and voice are consistent throughout.
  • I have verified the overall quality of the article
    • The article is not missing any information, nor does it contain redundant information.
    • The article fully addresses user needs.
  • I have verified that all requested improvements have been addressed

For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member?

cc @CortneyOfstad

@melvin-bot
melvin-bot Bot requested review from CortneyOfstad and removed request for a team September 24, 2026 18:28
@melvin-bot

melvin-bot Bot commented Sep 24, 2026

Copy link
Copy Markdown

@CortneyOfstad Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-24T18:43:38.162687Z 41a1d7a Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@sakluger
sakluger removed the request for review from CortneyOfstad September 24, 2026 18:28
@sakluger

Copy link
Copy Markdown
Contributor

Courtney doesn't need to review, I've already done it.

@github-actions

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR makes targeted, high-quality improvements to a single article, docs/articles/new-expensify/workspaces/Add-Approvals.md. The changes expand keyword metadata, fix pre-existing UI-label formatting issues, add a clarifying hint sentence, introduce a new task-based section on changing or removing the over-limit Additional approver, and add a related FAQ entry. All proposed changes align with the HelpDot governance standards.

Scores Summary

  • Readability: 9/10 - New steps are sequential, action-oriented, and clearly scannable. The hint sentence and the note about first-approver routing add helpful context without clutter.
  • AI Readiness: 9/10 - Expanded keywords reflect realistic search queries (remove limit, admins room system message, approval workflow change message). The new heading is a full task-based ## How to... phrase using the exact feature name, and the new FAQ entry uses a question word. All new headings use ## only.
  • Style Compliance: 9/10 - The changes fix pre-existing violations by bolding the Report amount and Additional approver UI labels. New steps consistently bold UI labels and buttons (Workflows, Remove limit, Save) per the Button/Tab/Section naming standards.

Key Findings

  • The diff fixes pre-existing naming-convention violations by adding missing bold formatting to Report amount and Additional approver.
  • The new ## How to change or remove the over-limit Additional approver section is exemplary: task-based heading with the feature name, sequential numbered steps, and exact UI labels.
  • The new FAQ entry (## Where can I see who changed the over-limit approver or threshold?) is question-based and compliant.
  • Out-of-scope note (not caused by this PR): the file as a whole uses multiple # headings, which conflicts with the "exactly one # heading" rule in HELP_AUTHORING_GUIDELINES.md Section 4. This is a pre-existing condition; the changed lines here only add ## headings and do not worsen it.

Recommendations

  • No changes required for this PR. The proposed edits are clean and compliant.
  • Optional follow-up (separate PR): address the pre-existing multiple-#-heading structure by demoting secondary # sections to ## (or splitting into separate articles) to fully conform to the single-# rule.

Files Reviewed

  • docs/articles/new-expensify/workspaces/Add-Approvals.md - Approved. Changes are compliant and improve clarity, metadata, and formatting.

Note: Detailed line-by-line feedback has been provided as inline comments.

@sakluger
sakluger merged commit cd1d8ba into main Sep 24, 2026
26 of 27 checks passed
@sakluger
sakluger deleted the melvin-docs-over-limit-approver-changelog branch September 24, 2026 18:35
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/sakluger in version: 9.4.94-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/Julesssss in version: 9.4.94-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants