Skip to content

refactor: extract transaction selection and pending expense hooks, finish wiring - #101202

Merged
mountiny merged 10 commits into
Expensify:mainfrom
callstack-internal:decompose/money-request-report-transactions-b4-v2
Sep 29, 2026
Merged

mountiny merged 10 commits into
Expensify:mainfrom
callstack-internal:decompose/money-request-report-transactions-b4-v2

Conversation

@sosek108

@sosek108 sosek108 commented Sep 15, 2026 •

Copy link
Copy Markdown
Contributor

refactor: extract transaction selection and pending expense hooks, finish wiring

Explanation of Change

Slice 10 of 10 (B4) of the MoneyRequestReportActionsList/MoneyRequestReportTransactionList decomposition (#99919). This final slice extracts the last two hooks out of MoneyRequestReportTransactionList.tsx and finishes the wiring so the component reaches its final decomposed shape.

Fixed Issues

$ #99919
PROPOSAL:

Tests

  1. Open an expense report with multiple transactions.
  2. Verify the transaction list renders correctly (rows, totals, footer).
  3. Long-press (mobile) or use the checkbox (desktop) to select a transaction; verify the selection toolbar appears and select-all works.
  4. While offline, add an expense to the report; verify the optimistic pending expense row appears.
  5. Verify sorting and group-by still work as before.

Offline tests

Same as Tests — step 4 covers the offline pending expense row.

QA Steps

Same as tests.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
Nagranie.z.ekranu.2026-09-22.o.09.59.55.mov
iOS: mWeb Safari
MacOS: Chrome / Safari
Nagranie.z.ekranu.2026-09-22.o.09.42.02.mov

… decompose/money-request-report-transactions-b4-v2
… decompose/money-request-report-transactions-b4-v2
@codecov

codecov Bot commented Sep 22, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
...tReportView/useMoneyRequestReportPendingExpense.ts 100.00% <100.00%> (ø)
...tView/useMoneyRequestReportTransactionSelection.ts 100.00% <100.00%> (ø)
...stReportView/MoneyRequestReportTransactionList.tsx 71.64% <65.00%> (+8.16%) ⬆️
... and 26 files with indirect coverage changes

@sosek108
sosek108 marked this pull request as ready for review September 25, 2026 09:48
@sosek108
sosek108 requested review from a team as code owners September 25, 2026 09:48
@melvin-bot
melvin-bot Bot requested review from dylanexpensify and suneox and removed request for a team September 25, 2026 09:48
@melvin-bot

melvin-bot Bot commented Sep 25, 2026

Copy link
Copy Markdown

@suneox Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot removed the request for review from a team September 25, 2026 09:48
@sosek108

Copy link
Copy Markdown
Contributor Author

@codex review
@MelvinBot review

@MelvinBot

Copy link
Copy Markdown
Contributor

Review

I found no correctness issues. The two new hooks keep the logic from the old component unchanged.

The main risk is the switch from useCallback-wrapped useFocusEffect callbacks to inline ones. useFocusEffect re-runs, and calls the previous cleanup, whenever the callback identity changes. In useMoneyRequestReportTransactionSelection, that cleanup calls clearSelectedTransactions(true), so an unstable callback would clear the selection on every re-render. I checked this locally: both new hooks, MoneyRequestReportTransactionList, and its parent compile and memoize under both Babel and OXC (react-compiler-compliance-check --verbose). The react-hooks/exhaustive-deps suppression does not stop compilation. The compiled callback depends on the same values the old useCallback did.

Other checks
  • Dropping memo() on the default export is safe. The parent MoneyRequestReportActionsList is compiled.
  • Moving useMoneyRequestReportColumns and the selection hook below the grouping hooks does not change behavior. useMoneyRequestReportActiveTransactionIDs does not touch selection state.
  • transactions.length === 0 matches isEmpty(transactions) for an array.
  • Each new test case has // Given / // When / // Then comments.
  • All CI checks pass except Check independent approval, which is expected before review.

Nit: The new component docblock at MoneyRequestReportTransactionList.tsx:167 lists the extracted hooks but leaves out useMoneyRequestReportPendingExpense and useMoneyRequestReportActiveTransactionIDs.

@dylanexpensify dylanexpensify left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

refactor, product input not required

@suneox

suneox commented Sep 28, 2026

Copy link
Copy Markdown
Contributor

I'll take a look at this PR today

@suneox

suneox commented Sep 29, 2026

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
CleanShot.2026-09-29.at.11.11.18.2.mp4
Android: mWeb Chrome
CleanShot.2026-09-29.at.11.11.18.mp4
iOS: HybridApp
CleanShot.2026-09-29.at.11.21.33.4.mp4
iOS: mWeb Safari
CleanShot.2026-09-29.at.11.19.17.3.mp4
MacOS: Chrome / Safari
CleanShot.2026-09-29.at.11.02.00.1.mp4

@suneox suneox left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the extracted hooks keep the logic unchanged

MoneyRequestReportActionsList.perf-test (MoneyRequestReportTransactionList perf test isn't available)

There is no perf regression

Test Duration Render count Redundant updates
500 reportActions / 10 transactions 28.7 ms to 31.4 ms (+9.6%) 6 to 6 2 to 2
500 reportActions / 100 transactions 32.5 ms to 31.9 ms (-1.7%) 6 to 6 2 to 2
a new report action arrives 111.3 ms to 119.2 ms (+7.1%) 12.2 to 12.2 7 to 7
a transaction under the report changes 117.8 ms to 108.0 ms (-8.3%) 12 to 12 7 to 7
an unrelated report receives new actions 118.6 ms to 122.8 ms (+3.5%) 16 to 16 12 to 12
a transaction of an unrelated report gets a violation 135.9 ms to 124.0 ms (-8.8%) 16 to 16 12 to 12

@melvin-bot
melvin-bot Bot requested a review from mountiny September 29, 2026 04:34

@mountiny mountiny left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! The changes look good to me

@mountiny
mountiny merged commit 2d73789 into Expensify:main Sep 29, 2026
35 of 39 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/mountiny in version: 9.4.96-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 cancelled 🔪
🍎 iOS 🍎 cancelled 🔪

@MelvinBot

Copy link
Copy Markdown
Contributor

No help site update is needed. This PR is an internal refactor: it moves transaction selection and pending expense logic into two hooks without changing any user-facing behavior, labels, or beta gates.


view run

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/mountiny in version: 9.4.99-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor

No help site update is needed. This PR is an internal refactor: it moves the transaction selection and pending expense placeholder logic into new hooks, and it doesn't change any user-facing behavior, labels, or workflows.


view run

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/Julesssss in version: 9.4.99-2 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants