Repository navigation
refactor: extract transaction selection and pending expense hooks, finish wiring - #101202
Conversation
… decompose/money-request-report-transactions-b4-v2
… decompose/money-request-report-transactions-b4-v2
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
… decompose/money-request-report-transactions-b4-v2
… decompose/money-request-report-transactions-b4-v2
|
@codex review |
ReviewI found no correctness issues. The two new hooks keep the logic from the old component unchanged. The main risk is the switch from Other checks
Nit: The new component docblock at MoneyRequestReportTransactionList.tsx:167 lists the extracted hooks but leaves out |
dylanexpensify
left a comment
There was a problem hiding this comment.
refactor, product input not required
|
I'll take a look at this PR today |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppCleanShot.2026-09-29.at.11.11.18.2.mp4Android: mWeb ChromeCleanShot.2026-09-29.at.11.11.18.mp4iOS: HybridAppCleanShot.2026-09-29.at.11.21.33.4.mp4iOS: mWeb SafariCleanShot.2026-09-29.at.11.19.17.3.mp4MacOS: Chrome / SafariCleanShot.2026-09-29.at.11.02.00.1.mp4 |
suneox
left a comment
There was a problem hiding this comment.
LGTM, the extracted hooks keep the logic unchanged
MoneyRequestReportActionsList.perf-test (MoneyRequestReportTransactionList perf test isn't available)
There is no perf regression
| Test | Duration | Render count | Redundant updates |
|---|---|---|---|
| 500 reportActions / 10 transactions | 28.7 ms to 31.4 ms (+9.6%) | 6 to 6 | 2 to 2 |
| 500 reportActions / 100 transactions | 32.5 ms to 31.9 ms (-1.7%) | 6 to 6 | 2 to 2 |
| a new report action arrives | 111.3 ms to 119.2 ms (+7.1%) | 12.2 to 12.2 | 7 to 7 |
| a transaction under the report changes | 117.8 ms to 108.0 ms (-8.3%) | 12 to 12 | 7 to 7 |
| an unrelated report receives new actions | 118.6 ms to 122.8 ms (+3.5%) | 16 to 16 | 12 to 12 |
| a transaction of an unrelated report gets a violation | 135.9 ms to 124.0 ms (-8.8%) | 16 to 16 | 12 to 12 |
mountiny
left a comment
There was a problem hiding this comment.
Thanks! The changes look good to me
|
🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.4.96-0 🚀
|
|
No help site update is needed. This PR is an internal refactor: it moves transaction selection and pending expense logic into two hooks without changing any user-facing behavior, labels, or beta gates. |
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.4.99-0 🚀
|
|
No help site update is needed. This PR is an internal refactor: it moves the transaction selection and pending expense placeholder logic into new hooks, and it doesn't change any user-facing behavior, labels, or workflows. |
|
🚀 Deployed to production by https://github.com/Julesssss in version: 9.4.99-2 🚀
Bundle Size Analysis (Sentry): |
refactor: extract transaction selection and pending expense hooks, finish wiring
Explanation of Change
Slice 10 of 10 (B4) of the
MoneyRequestReportActionsList/MoneyRequestReportTransactionListdecomposition (#99919). This final slice extracts the last two hooks out ofMoneyRequestReportTransactionList.tsxand finishes the wiring so the component reaches its final decomposed shape.Fixed Issues
$ #99919
PROPOSAL:
Tests
Offline tests
Same as Tests — step 4 covers the offline pending expense row.
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
Nagranie.z.ekranu.2026-09-22.o.09.59.55.mov
iOS: mWeb Safari
MacOS: Chrome / Safari
Nagranie.z.ekranu.2026-09-22.o.09.42.02.mov