Skip to content

[Merge ATS] Add merge ATS filters page - #101236

Merged
yuwenmemon merged 28 commits into
Expensify:mainfrom
bernhardoj:feat/99512-merge-ats-filters-page
Sep 24, 2026
Merged

yuwenmemon merged 28 commits into
Expensify:mainfrom
bernhardoj:feat/99512-merge-ats-filters-page

Conversation

@bernhardoj

@bernhardoj bernhardoj commented Sep 15, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

Fixed Issues

$ #99512
PROPOSAL:

Tests

Same as QA Steps

  • Verify that no errors appear in the JS console

Offline tests

Same as QA Steps

QA Steps

Prerequisite: have a workspace with recruiting enabled and greenhouse connected

  1. Press Complete setup (if you have never set filters yet) or Import settings
  2. Verify it opens the import settings page with Job stages, Tag, and Office toggles
  3. Verify that when Job stages or Tags toggles are disabled, pressing Save shows an error message
  4. Enable one of the toggles
  5. Verify the initially selected value is "All ..."
  6. Press the field
  7. Verify it shows all options as selected
  8. Edit any selection
  9. Press Save and verify the selection is saved
  10. Press Save again
  11. Verify it starts syncing after a few seconds
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
import.mp4

@bernhardoj
bernhardoj requested review from a team as code owners September 15, 2026 17:02
@melvin-bot

melvin-bot Bot commented Sep 15, 2026

Copy link
Copy Markdown

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

  1. Look at the code and make sure there are no malicious changes.
  2. Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx bun ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx bun ./scripts/generateTranslations.ts --compare-ref main

@melvin-bot

melvin-bot Bot commented Sep 15, 2026

Copy link
Copy Markdown

@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot removed request for a team September 15, 2026 17:03

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6ccb3ba3ce

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

{filterType: CONST.MERGE.ATS_FILTER_TYPE.OFFICES, title: translate('workspace.recruiting.filters.offices.optionalTitle')},
];

const hasRequiredFilter = !!filters.tags?.length || !!filters.stages?.length;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Avoid exposing an unsavable office-only setup

When the initial sync returns offices but no tags or stages, isMergeATSCompleteSetupNeeded() still exposes the Complete setup flow because it treats any nonempty catalog as sufficient, but this check rejects every selection the user can make because offices never satisfy hasRequiredFilter. The admin is left unable to complete setup or dismiss its CTA; align setup eligibility with the required dimensions or permit an office selection to complete it.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@trjExpensify the import settings require at least one filter from job stages or tags. When the ATS only has offices, should we show "Complete setup"?

"Complete setup" will open the import settings page, but the user won't be able to save it because job stages and tags are empty.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bernhardoj have you seen this in an example? From the design doc:

At least one Tag or Stage must be selected. Office is optional and cannot be the only filter.

So, if Merge returns only offices, we should not show Complete setup -- at least in theory.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anyway, going to leave this as an NAB, and we can address it in a follow-up if we feel like we want to.

Comment thread src/libs/merge/RecruitingUtils.ts Resolved
Comment thread src/languages/en.ts Resolved
@OSBotify

This comment has been minimized.

@codecov

codecov Bot commented Sep 16, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
src/CONST/index.ts 94.06% <ø> (ø)
src/SCREENS.ts 100.00% <ø> (ø)
...gation/linkingConfig/RELATIONS/WORKSPACE_TO_RHP.ts 100.00% <ø> (ø)
src/libs/Navigation/linkingConfig/config.ts 62.50% <ø> (ø)
...es/workspace/workflows/ToggleSettingsOptionRow.tsx 100.00% <ø> (ø)
src/ROUTES.ts 30.38% <0.00%> (-0.03%) ⬇️
...gation/AppNavigator/ModalStackNavigators/index.tsx 7.74% <33.33%> (+0.07%) ⬆️
...on/AppNavigator/Navigators/RightModalNavigator.tsx 3.89% <0.00%> (-0.08%) ⬇️
src/libs/merge/RecruitingUtils.ts 93.44% <86.66%> (-6.56%) ⬇️
...ting/merge/filters/MergeATSFiltersDraftContext.tsx 13.63% <13.63%> (ø)
... and 2 more
... and 154 files with indirect coverage changes

@JmillsExpensify
JmillsExpensify requested review from garrettmknight and removed request for JmillsExpensify September 16, 2026 10:26
@JmillsExpensify

Copy link
Copy Markdown
Contributor

@garrettmknight is the product owner for this one.

@ishpaul777

Copy link
Copy Markdown
Contributor

we should probably have a search bar on this selection pages

Screenshot 2026-09-16 at 6 49 25 PM

@bernhardoj

Copy link
Copy Markdown
Contributor Author

Should the search bar also filter the "Don't import" option?

Option 1: "Don't import" is sticky, not filtered

sticky.mp4

Option 2: "Don't import" isn't sticky; it gets filtered

no.stick.mp4

@ishpaul777

Copy link
Copy Markdown
Contributor

@Expensify/design Any thoughts on #101236 (comment) question ?

@DylanDylann

Copy link
Copy Markdown
Contributor

IMO, I prefer this option

Option 1: "Don't import" is sticky, not filtered

@yuwenmemon

Copy link
Copy Markdown
Contributor

@bernhardoj some conflicts here.

@bernhardoj

Copy link
Copy Markdown
Contributor Author

@yuwenmemon conflicts fixed

@DylanDylann

Copy link
Copy Markdown
Contributor

@bernhardoj We should only display the error message when the user clicks the Save button

Screen.Recording.2026-09-24.at.18.17.47.mov

@OSBotify

Copy link
Copy Markdown
Contributor

🦜 Polyglot Parrot! 🦜

Squawk! Looks like you added some shiny new English strings. Allow me to parrot them back to you in other tongues:

View the translation diff
diff --git a/src/languages/de.ts b/src/languages/de.ts
index 2cd0d6c0..3e305d92 100644
--- a/src/languages/de.ts
+++ b/src/languages/de.ts
@@ -8749,27 +8749,28 @@ Fügen Sie weitere Ausgabelimits hinzu, um den Cashflow Ihres Unternehmens zu sc
             defaultApprover: 'Standardgenehmiger',
             approverFields: {recruiter: 'Personalvermittler', recruitingCoordinator: 'Recruiting-Koordinator'},
             filters: {
-                description: (providerName: string) => `Wählen Sie aus, welche Mitglieder von ${providerName} importiert werden. Sie können nach Jobphasen, Tags und Büros auswählen.`,
+                description: (providerName: string) => `Wählen Sie aus, welche Mitglieder aus ${providerName} importiert werden. Sie können nach Jobphasen, Tags und Büros auswählen.`,
                 stages: {
                     title: 'Jobphase',
                     description: 'Wählen Sie die Bewerbungsphase der Kandidat:innen, die Sie mit diesem Workspace synchronisieren möchten',
-                    toggleTitle: 'Importauftragsphasen',
-                    allSelected: 'Alle Jobphasen',
-                    emptySelectionError: 'Bitte wählen Sie mindestens eine Jobphase aus',
+                    toggleTitle: 'Jobphasen',
+                    allSelected: 'Alle Stellenphasen',
+                    emptySelectionError: 'Bitte wählen Sie mindestens eine Projektphase aus',
                 },
                 tags: {
                     title: 'Tag',
-                    description: 'Wählen Sie die Stichwörter der Kandidat:innen aus, die Sie mit diesem Workspace synchronisieren möchten',
-                    toggleTitle: 'Tags importieren',
+                    description: 'Wählen Sie die Tags der Kandidat:innen, die Sie mit diesem Workspace synchronisieren möchten',
+                    toggleTitle: 'Tags',
                     allSelected: 'Alle Tags',
                     emptySelectionError: 'Bitte wählen Sie mindestens einen Tag aus',
                 },
                 offices: {
                     title: 'Büro',
                     description: 'Wählen Sie die Büros der Kandidat:innen aus, die Sie mit diesem Workspace synchronisieren möchten',
-                    toggleTitle: 'Büros importieren (optional)',
+                    toggleTitle: 'Büros',
                     allSelected: 'Alle Büros',
                 },
+                enableJobStagesOrTags: 'Aktivieren Sie Jobphasen oder Tags, um fortzufahren',
             },
             subtitle: 'Verknüpfen Sie Recruiting-Tools und halten Sie Kandidatengenehmigungen synchron.',
             syncResults: {
diff --git a/src/languages/el.ts b/src/languages/el.ts
index 6433ac28..7273091d 100644
--- a/src/languages/el.ts
+++ b/src/languages/el.ts
@@ -7725,27 +7725,28 @@ _Για πιο αναλυτικές οδηγίες, [επισκεφθείτε τ
             defaultApprover: 'Προεπιλεγμένος εγκρίνων',
             approverFields: {recruiter: 'Στρατολογητής', recruitingCoordinator: 'Συντονιστής προσλήψεων'},
             filters: {
-                description: (providerName: string) => `Επιλέξτε ποια μέλη θα εισαχθούν από το ${providerName}. Μπορείτε να επιλέξετε με βάση στάδια θέσης, ετικέτες και γραφεία.`,
+                description: (providerName: string) => `Επιλέξτε ποια μέλη θα εισαχθούν από το ${providerName}. Μπορείτε να επιλέξετε από στάδια εργασίας, ετικέτες και γραφεία.`,
                 stages: {
                     title: 'Στάδιο εργασίας',
-                    description: 'Επιλέξτε το στάδιο θέσης εργασίας των υποψηφίων που θέλετε να συγχρονίσετε με αυτόν τον χώρο εργασίας',
-                    toggleTitle: 'Στάδια εργασίας εισαγωγής',
+                    description: 'Επιλέξτε το στάδιο πρόσληψης των υποψηφίων που θέλετε να συγχρονίζονται με αυτόν τον χώρο εργασίας',
+                    toggleTitle: 'Στάδια εργασίας',
                     allSelected: 'Όλα τα στάδια εργασίας',
-                    emptySelectionError: 'Παρακαλώ επιλέξτε τουλάχιστον ένα στάδιο εργασίας',
+                    emptySelectionError: 'Παρακαλούμε επιλέξτε τουλάχιστον ένα στάδιο εργασίας',
                 },
                 tags: {
                     title: 'Ετικέτα',
-                    description: 'Επιλέξτε τις ετικέτες των υποψηφίων που θέλετε να συγχρονίσετε με αυτόν τον χώρο εργασίας',
-                    toggleTitle: 'Εισαγωγή ετικετών',
+                    description: 'Επιλέξτε τις ετικέτες υποψηφίων που θέλετε να συγχρονίσετε με αυτόν τον χώρο εργασίας',
+                    toggleTitle: 'Ετικέτες',
                     allSelected: 'Όλες οι ετικέτες',
                     emptySelectionError: 'Παρακαλώ επιλέξτε τουλάχιστον μία ετικέτα',
                 },
                 offices: {
                     title: 'Γραφείο',
                     description: 'Επιλέξτε τα γραφεία των υποψηφίων που θέλετε να συγχρονίσετε με αυτόν τον χώρο εργασίας',
-                    toggleTitle: 'Εισαγωγή γραφείων (προαιρετικό)',
+                    toggleTitle: 'Γραφεία',
                     allSelected: 'Όλα τα γραφεία',
                 },
+                enableJobStagesOrTags: 'Ενεργοποιήστε τα στάδια εργασίας ή τις ετικέτες για να συνεχίσετε',
             },
             subtitle: 'Συνδέστε τα εργαλεία προσλήψεων και διατηρήστε τις εγκρίσεις υποψηφίων συγχρονισμένες.',
             syncResults: {
diff --git a/src/languages/es.ts b/src/languages/es.ts
index b245dbdd..0f954096 100644
--- a/src/languages/es.ts
+++ b/src/languages/es.ts
@@ -7461,27 +7461,28 @@ El plan Controlar empieza en 9 $ por miembro activo al mes.`,
             defaultApprover: 'Aprobador predeterminado',
             approverFields: {recruiter: 'Reclutador', recruitingCoordinator: 'Coordinador de selección'},
             filters: {
-                description: (providerName: string) => `Selecciona qué miembros se importan desde ${providerName}. Puedes elegir entre fases del proceso, etiquetas y oficinas.`,
+                description: (providerName: string) => `Selecciona qué miembros se importan desde ${providerName}. Puedes elegir entre etapas de trabajo, etiquetas y oficinas.`,
                 stages: {
                     title: 'Etapa del trabajo',
                     description: 'Elige la fase del puesto de los candidatos que te gustaría sincronizar con este espacio de trabajo',
-                    toggleTitle: 'Importar fases del trabajo',
-                    allSelected: 'Todos los estados del trabajo',
-                    emptySelectionError: 'Selecciona al menos una etapa del trabajo',
+                    toggleTitle: 'Fases del trabajo',
+                    allSelected: 'Todas las fases del trabajo',
+                    emptySelectionError: 'Por favor, selecciona al menos una etapa del trabajo',
                 },
                 tags: {
                     title: 'Etiqueta',
-                    description: 'Elige las etiquetas de candidatos que te gustaría sincronizar con este espacio de trabajo',
-                    toggleTitle: 'Importar etiquetas',
+                    description: 'Elige las etiquetas de los candidatos que te gustaría sincronizar con este espacio de trabajo',
+                    toggleTitle: 'Etiquetas',
                     allSelected: 'Todas las etiquetas',
-                    emptySelectionError: 'Por favor, selecciona al menos una etiqueta',
+                    emptySelectionError: 'Selecciona al menos una etiqueta',
                 },
                 offices: {
                     title: 'Oficina',
-                    description: 'Elige las oficinas de los candidatos que te gustaría sincronizar con este espacio de trabajo',
-                    toggleTitle: 'Importar oficinas (opcional)',
+                    description: 'Elige las oficinas de las personas candidatas que te gustaría sincronizar con este espacio de trabajo',
+                    toggleTitle: 'Oficinas',
                     allSelected: 'Todas las oficinas',
                 },
+                enableJobStagesOrTags: 'Habilita las etapas de trabajo o las etiquetas para continuar',
             },
             subtitle: 'Conecta herramientas de selección y mantén sincronizadas las aprobaciones de candidatos.',
             syncResults: {
diff --git a/src/languages/fr.ts b/src/languages/fr.ts
index c3b1dfd7..e253b954 100644
--- a/src/languages/fr.ts
+++ b/src/languages/fr.ts
@@ -8770,25 +8770,26 @@ Ajoutez davantage de règles de dépenses pour protéger la trésorerie de l’e
                 description: (providerName: string) =>
                     `Sélectionnez quels membres sont importés depuis ${providerName}. Vous pouvez choisir selon les étapes de poste, les tags et les bureaux.`,
                 stages: {
-                    title: 'Étape du poste',
-                    description: 'Choisissez l’étape de recrutement des candidats que vous souhaitez synchroniser avec cet espace de travail',
-                    toggleTitle: 'Étapes de la tâche d’importation',
-                    allSelected: 'Tous les stades du poste',
-                    emptySelectionError: 'Veuillez sélectionner au moins une étape de travail',
+                    title: 'Étape de recrutement',
+                    description: 'Choisissez l’étape du poste des candidat·es que vous souhaitez synchroniser avec cet espace de travail',
+                    toggleTitle: 'Étapes du poste',
+                    allSelected: 'Toutes les étapes du poste',
+                    emptySelectionError: 'Veuillez sélectionner au moins une étape de poste',
                 },
                 tags: {
                     title: 'Tag',
                     description: 'Choisissez les tags de candidats que vous souhaitez synchroniser avec cet espace de travail',
-                    toggleTitle: 'Importer des tags',
+                    toggleTitle: 'Tags',
                     allSelected: 'Tous les tags',
                     emptySelectionError: 'Veuillez sélectionner au moins un tag',
                 },
                 offices: {
                     title: 'Bureau',
                     description: 'Choisissez les bureaux des candidats que vous souhaitez synchroniser avec cet espace de travail',
-                    toggleTitle: 'Importer des bureaux (facultatif)',
+                    toggleTitle: 'Bureaux',
                     allSelected: 'Tous les bureaux',
                 },
+                enableJobStagesOrTags: 'Activez les étapes de mission ou les Tags pour continuer',
             },
             subtitle: 'Connectez les outils de recrutement et synchronisez les validations de candidats.',
             syncResults: {
diff --git a/src/languages/it.ts b/src/languages/it.ts
index fd66a89d..9ff67f76 100644
--- a/src/languages/it.ts
+++ b/src/languages/it.ts
@@ -8696,27 +8696,28 @@ Aggiungi altre regole di spesa per proteggere il flusso di cassa aziendale.`,
             defaultApprover: 'Approvatore predefinito',
             approverFields: {recruiter: 'Recruiter', recruitingCoordinator: 'Coordinatore recruiting'},
             filters: {
-                description: (providerName: string) => `Seleziona quali membri importare da ${providerName}. Puoi scegliere in base a fasi lavorative, tag e sedi.`,
+                description: (providerName: string) => `Seleziona quali membri importare da ${providerName}. Puoi scegliere in base alle fasi lavorative, ai tag e alle sedi.`,
                 stages: {
-                    title: 'Fase del lavoro',
-                    description: 'Scegli la fase del lavoro dei candidati che vuoi sincronizzare con questo workspace',
-                    toggleTitle: 'Fasi del processo di importazione',
-                    allSelected: 'Tutte le fasi di lavoro',
+                    title: 'Fase lavoro',
+                    description: 'Scegli la fase del processo di selezione dei candidati che vuoi sincronizzare con questo spazio di lavoro',
+                    toggleTitle: 'Fasi del lavoro',
+                    allSelected: 'Tutte le fasi del lavoro',
                     emptySelectionError: 'Seleziona almeno una fase di lavoro',
                 },
                 tags: {
                     title: 'Tag',
-                    description: 'Scegli i tag dei candidati che vuoi sincronizzare con questo workspace',
-                    toggleTitle: 'Importa tag',
-                    allSelected: 'Tutte le etichette',
+                    description: 'Scegli i tag dei candidati che vuoi sincronizzare con questo spazio di lavoro',
+                    toggleTitle: 'Tag',
+                    allSelected: 'Tutti i tag',
                     emptySelectionError: 'Seleziona almeno un tag',
                 },
                 offices: {
                     title: 'Ufficio',
                     description: 'Scegli gli uffici dei candidati che vuoi sincronizzare con questo spazio di lavoro',
-                    toggleTitle: 'Importa uffici (facoltativo)',
+                    toggleTitle: 'Uffici',
                     allSelected: 'Tutti gli uffici',
                 },
+                enableJobStagesOrTags: 'Abilita le fasi di lavoro o i tag per continuare',
             },
             subtitle: 'Collega gli strumenti di recruiting e mantieni sincronizzate le approvazioni dei candidati.',
             syncResults: {
diff --git a/src/languages/ja.ts b/src/languages/ja.ts
index 46ce5f83..3b84b19c 100644
--- a/src/languages/ja.ts
+++ b/src/languages/ja.ts
@@ -8585,27 +8585,23 @@ ${reportName}`,
             defaultApprover: 'デフォルト承認者',
             approverFields: {recruiter: '採用担当者', recruitingCoordinator: '採用コーディネーター'},
             filters: {
-                description: (providerName: string) => `${providerName} からインポートするメンバーを選択してください。採用ステージ、タグ、オフィスから選ぶことができます。`,
+                description: (providerName: string) => `${providerName} からインポートするメンバーを選択してください。採用ステージ、タグ、オフィスから選択できます。`,
                 stages: {
-                    title: 'ジョブステージ',
-                    description: 'このワークスペースと同期したい候補者の求人ステージを選択してください',
-                    toggleTitle: 'インポートジョブのステージ',
-                    allSelected: 'すべての求人ステージ',
+                    title: 'ジョブの段階',
+                    description: 'このワークスペースと同期したい候補者の選考ステージを選択してください',
+                    toggleTitle: 'ジョブのステージ',
+                    allSelected: 'すべての採用ステージ',
                     emptySelectionError: '少なくとも1つの求人ステージを選択してください',
                 },
                 tags: {
                     title: 'タグ',
                     description: 'このワークスペースと同期したい候補者のタグを選択してください',
-                    toggleTitle: 'タグをインポート',
+                    toggleTitle: 'タグ',
                     allSelected: 'すべてのタグ',
-                    emptySelectionError: '少なくとも 1 つタグを選択してください',
-                },
-                offices: {
-                    title: 'オフィス',
-                    description: 'このワークスペースと同期したい候補者のオフィスを選択してください',
-                    toggleTitle: 'オフィスをインポート(任意)',
-                    allSelected: 'すべてのオフィス',
+                    emptySelectionError: 'タグを少なくとも1つ選択してください',
                 },
+                offices: {title: 'オフィス', description: 'このワークスペースと同期したい候補者のオフィスを選択してください', toggleTitle: 'オフィス', allSelected: 'すべてのオフィス'},
+                enableJobStagesOrTags: '続行するにはジョブステージまたはタグを有効にしてください',
             },
             subtitle: '採用ツールを連携して、候補者の承認を常に同期させます。',
             syncResults: {
diff --git a/src/languages/nl.ts b/src/languages/nl.ts
index 60e3edf0..47016bac 100644
--- a/src/languages/nl.ts
+++ b/src/languages/nl.ts
@@ -8675,27 +8675,28 @@ er bestedingsregels toe om de kasstroom van het bedrijf te beschermen.`,
             defaultApprover: 'Standaardgoedkeurder',
             approverFields: {recruiter: 'Recruiter', recruitingCoordinator: 'Coördinator werving'},
             filters: {
-                description: (providerName: string) => `Selecteer welke leden worden geïmporteerd uit ${providerName}. Je kunt kiezen op basis van functiestadia, tags en kantoren.`,
+                description: (providerName: string) => `Selecteer welke leden worden geïmporteerd uit ${providerName}. Je kunt kiezen op basis van functieniveaus, tags en kantoren.`,
                 stages: {
                     title: 'Functiefase',
-                    description: 'Kies de sollicitatiefase van de kandidaten die je met deze workspace wilt synchroniseren',
-                    toggleTitle: 'Importtaakfasen',
-                    allSelected: 'Alle functiestadia',
-                    emptySelectionError: 'Selecteer minimaal één functieniveau',
+                    description: 'Kies de sollicitatiefase van kandidaten die je met deze workspace wilt synchroniseren',
+                    toggleTitle: 'Functiefasen',
+                    allSelected: 'Alle functiestappen',
+                    emptySelectionError: 'Selecteer minstens één functiefase',
                 },
                 tags: {
                     title: 'Label',
-                    description: 'Kies de tags van kandidaten die je wilt synchroniseren met deze workspace',
-                    toggleTitle: 'Tags importeren',
-                    allSelected: 'Alle tags',
-                    emptySelectionError: 'Selecteer ten minste één tag',
+                    description: 'Kies de tags van kandidaten die je met deze workspace wilt synchroniseren',
+                    toggleTitle: 'Tags',
+                    allSelected: 'Alle labels',
+                    emptySelectionError: 'Selecteer minstens één tag',
                 },
                 offices: {
                     title: 'Kantoor',
                     description: 'Kies de kantoren van kandidaten die je met deze workspace wilt synchroniseren',
-                    toggleTitle: 'Kantoren importeren (optioneel)',
+                    toggleTitle: 'Kantoren',
                     allSelected: 'Alle kantoren',
                 },
+                enableJobStagesOrTags: 'Schakel functiestadia of labels in om door te gaan',
             },
             subtitle: 'Koppel wervingstools en houd kandidaategoedkeuringen gesynchroniseerd.',
             syncResults: {
diff --git a/src/languages/pl.ts b/src/languages/pl.ts
index 0b85001d..8d9b5e27 100644
--- a/src/languages/pl.ts
+++ b/src/languages/pl.ts
@@ -8695,27 +8695,23 @@ Dodaj więcej zasad wydatków, żeby chronić płynność finansową firmy.`,
             defaultApprover: 'Domyślny zatwierdzający',
             approverFields: {recruiter: 'Rekruter', recruitingCoordinator: 'Koordynator rekrutacji'},
             filters: {
-                description: (providerName: string) => `Wybierz, których członków zaimportować z ${providerName}. Możesz wybierać według etapów rekrutacji, tagów i biur.`,
+                description: (providerName: string) => `Wybierz, którzy członkowie zostaną zaimportowani z ${providerName}. Możesz wybierać spośród etapów rekrutacji, tagów i biur.`,
                 stages: {
                     title: 'Etap zadania',
-                    description: 'Wybierz etap rekrutacji kandydatek i kandydatów, których chcesz zsynchronizować z tym obszarem roboczym',
-                    toggleTitle: 'Etapy zadania importu',
+                    description: 'Wybierz etap rekrutacji kandydatów, których chcesz zsynchronizować z tym miejscem pracy',
+                    toggleTitle: 'Etapy zlecenia',
                     allSelected: 'Wszystkie etapy pracy',
                     emptySelectionError: 'Wybierz co najmniej jeden etap pracy',
                 },
                 tags: {
                     title: 'Tag',
                     description: 'Wybierz tagi kandydatów, które chcesz zsynchronizować z tym obszarem roboczym',
-                    toggleTitle: 'Importuj tagi',
+                    toggleTitle: 'Tagi',
                     allSelected: 'Wszystkie tagi',
                     emptySelectionError: 'Wybierz co najmniej jeden znacznik',
                 },
-                offices: {
-                    title: 'Biuro',
-                    description: 'Wybierz biura kandydatów, które chcesz zsynchronizować z tym miejscem pracy',
-                    toggleTitle: 'Importuj biura (opcjonalnie)',
-                    allSelected: 'Wszystkie biura',
-                },
+                offices: {title: 'Biuro', description: 'Wybierz biura kandydatów, które chcesz zsynchronizować z tym miejscem pracy', toggleTitle: 'Biura', allSelected: 'Wszystkie biura'},
+                enableJobStagesOrTags: 'Włącz etapy zleceń lub tagi, aby kontynuować',
             },
             subtitle: 'Połącz narzędzia rekrutacyjne i utrzymuj zgody kandydatów w synchronizacji.',
             syncResults: {
diff --git a/src/languages/pt-BR.ts b/src/languages/pt-BR.ts
index 24c9969a..4ad6406a 100644
--- a/src/languages/pt-BR.ts
+++ b/src/languages/pt-BR.ts
@@ -8682,23 +8682,24 @@ Adicione mais regras de gasto para proteger o fluxo de caixa da empresa.`,
                 stages: {
                     title: 'Etapa do trabalho',
                     description: 'Escolha a etapa do processo seletivo dos candidatos que você gostaria de sincronizar com este workspace',
-                    toggleTitle: 'Etapas de importação',
-                    allSelected: 'Todas as etapas do trabalho',
+                    toggleTitle: 'Etapas do trabalho',
+                    allSelected: 'Todas as etapas de trabalho',
                     emptySelectionError: 'Selecione pelo menos uma etapa de trabalho',
                 },
                 tags: {
                     title: 'Tag',
-                    description: 'Escolha as tags de candidatos que você gostaria de sincronizar com este workspace',
-                    toggleTitle: 'Importar etiquetas',
+                    description: 'Escolha as tags dos candidatos que você gostaria de sincronizar com este workspace',
+                    toggleTitle: 'Tags',
                     allSelected: 'Todas as tags',
                     emptySelectionError: 'Selecione pelo menos uma tag',
                 },
                 offices: {
                     title: 'Escritório',
-                    description: 'Escolha os escritórios dos candidatos que você quer sincronizar com este workspace',
-                    toggleTitle: 'Importar escritórios (opcional)',
+                    description: 'Escolha os escritórios dos candidatos que você gostaria de sincronizar com este espaço de trabalho',
+                    toggleTitle: 'Escritórios',
                     allSelected: 'Todos os escritórios',
                 },
+                enableJobStagesOrTags: 'Ative Estágios de Trabalho ou Tags para continuar',
             },
             subtitle: 'Conecte ferramentas de recrutamento e mantenha as aprovações de candidatos em sincronia.',
             syncResults: {
diff --git a/src/languages/zh-hans.ts b/src/languages/zh-hans.ts
index 8e8f2523..79067555 100644
--- a/src/languages/zh-hans.ts
+++ b/src/languages/zh-hans.ts
@@ -8364,16 +8364,17 @@ ${reportName}`,
             defaultApprover: '默认审批人',
             approverFields: {recruiter: '招聘人员', recruitingCoordinator: '招聘协调员'},
             filters: {
-                description: (providerName: string) => `选择要从 ${providerName} 导入的成员。你可以根据职位阶段、标签和办公室进行选择。`,
+                description: (providerName: string) => `选择要从 ${providerName} 导入的成员。您可以按工作阶段、标签和办公室进行选择。`,
                 stages: {
                     title: '职位阶段',
                     description: '选择你希望与此工作区同步的候选人职位阶段',
-                    toggleTitle: '导入作业阶段',
+                    toggleTitle: '工作阶段',
                     allSelected: '所有职位阶段',
-                    emptySelectionError: '请至少选择一个职位阶段',
+                    emptySelectionError: '请选择至少一个职位阶段',
                 },
-                tags: {title: '标签', description: '选择要与此工作区同步的候选人标签', toggleTitle: '导入标签', allSelected: '所有标签', emptySelectionError: '请至少选择一个标签'},
-                offices: {title: '办公室', description: '选择你想与此工作区同步的候选人办公室', toggleTitle: '导入办公室(可选)', allSelected: '所有办公室'},
+                tags: {title: '标签', description: '选择要与此工作区同步的候选人标签', toggleTitle: '标签', allSelected: '所有标签', emptySelectionError: '请至少选择一个标签'},
+                offices: {title: '办公室', description: '选择你想与此工作区同步的候选人办公地点', toggleTitle: '办公室', allSelected: '所有办公室'},
+                enableJobStagesOrTags: '启用职位阶段或标签以继续',
             },
             subtitle: '连接招聘工具并保持候选人审批同步。',
             syncResults: {

Note

You can apply these changes to your branch by copying the patch to your clipboard, then running pbpaste | git apply 😉

View workflow run

@melvin-bot
melvin-bot Bot requested a review from yuwenmemon September 24, 2026 13:37
@yuwenmemon
yuwenmemon merged commit beac406 into Expensify:main Sep 24, 2026
38 of 42 checks passed
@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions

Copy link
Copy Markdown
Contributor

🚧 yuwenmemon has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/yuwenmemon in version: 9.4.94-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@izarutskaya

Copy link
Copy Markdown

@bernhardoj We don't see Don't import option, only Select all Is it the same? Let me know please. Thank you

1790477220875.101236w.mp4

@bernhardoj

Copy link
Copy Markdown
Contributor Author

@izarutskaya ah, the UI changes, but I forgot to update the QA steps. I just updated it.

@izarutskaya

Copy link
Copy Markdown

@bernhardoj So it's passed, right?

@Julesssss

Copy link
Copy Markdown
Contributor

@bernhardoj So it's passed, right?

@yuwenmemon @bernhardoj I think yes, looking at the test steps but please confirm.

@Julesssss

Copy link
Copy Markdown
Contributor

@bernhardoj So it's passed, right?

Yeah working through the new test steps that is a pass.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/Julesssss in version: 9.4.94-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.