Repository navigation
Conversation
…ilters change Follows E/A#101142, which removed shouldPreserveSelectionOnSearch from the Members table so the selection now clears whenever the search string changes. Also corrects the Remove Multiple Members steps to use the real UI labels verified against dev NewDot web. Co-authored-by: Linh Vo <linhvovan29546@users.noreply.github.com>
40 tasks
Contributor
|
A preview of your ExpensifyHelp changes have been deployed to https://b5d73680.helpdot.pages.dev ⚡️ Updated articles: |
3 tasks
Contributor
|
@MelvinBot Make the PR ready for review |
Contributor
Author
|
🤖 I couldn't mark this PR as ready for review. My environment blocked the The PR itself looks ready:
Before you do, you may want to delete the two |
Contributor
|
Consolidating to #101958 to avoid conflicts |
truph01
pushed a commit
to truph01/App
that referenced
this pull request
Sep 28, 2026
…nsify/workspaces
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Help site follow-up for Clear the Members table selection when the search string changes, which removed
shouldPreserveSelectionOnSearchfrom the Members table. The member selection now clears whenever the Find member search string changes — including when the search is cleared — instead of surviving the search.docs/articles/new-expensify/workspaces/Managing-Workspace-Members.mdsaid nothing about how selection interacts with search or filters, so an admin who selects members inside a search and then clears it has no documented explanation for the checkboxes emptying. This adds that note under Remove Multiple Members.While in that section, the steps also referenced UI that no longer exists. I verified every label against dev NewDot web on the Members page and corrected them:
Also documents the Select all header checkbox and the fact that you can't select your own row, and adds matching keywords to the front matter.
Applies
docs/HELPSITE_NAMING_CONVENTIONS.md(exact, bolded UI labels; no paraphrased or invented control names) anddocs/HELP_AUTHORING_GUIDELINES.md. This is a targeted edit to one existing article, so it keeps that article's current heading structure rather than restructuring it.Fixed Issues
Docs follow-up for #101142, which fixed:
$ #100991
PROPOSAL:
Tests
// TODO: The human co-author must fill out the tests they ran before marking this PR as "ready for review".
This PR changes Markdown under
docs/articlesonly — there is no app code to exercise. What needs checking is that the documented behavior and labels match the product:Offline tests
Not applicable. This PR only changes help site Markdown and ships no app code, so there is no offline behavior to test.
QA Steps
// TODO: The human co-author must fill out the QA steps before marking this PR as "ready for review".
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
No app code changed. These are the label and behavior checks I ran on dev NewDot web to source the wording in this article.
@linhvovan29546, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.