Repository navigation
[No QA] Add a non-production link back to token-based (SOAP) NetSuite setup - #101283
Conversation
|
@dubielzyk-expensify @abdulrahuman5196 One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
🦜 Polyglot Parrot! 🦜Squawk! Looks like you added some shiny new English strings. Allow me to parrot them back to you in other tongues: View the translation diffdiff --git a/src/languages/el.ts b/src/languages/el.ts
index 27c540bc..0fcbf70c 100644
--- a/src/languages/el.ts
+++ b/src/languages/el.ts
@@ -5671,7 +5671,7 @@ ${amount} για ${merchant} - ${date}`,
noSubsidiariesFoundDescription: 'Παρακαλούμε προσθέστε μια θυγατρική στο NetSuite και συγχρονίστε ξανά τη σύνδεση',
tokenInput: {
title: 'Ρύθμιση NetSuite',
- connectWithTokenAuthentication: 'Εναλλακτικά, συνδεθείτε με έλεγχο ταυτότητας με διακριτικό token (SOAP)',
+ connectWithTokenAuthentication: 'Συνδεθείτε με έλεγχο ταυτότητας βάσει διακριτικού (SOAP) αντ’ αυτού',
formSteps: {
installBundle: {
title: 'Εγκαταστήστε το πακέτο Expensify',
diff --git a/src/languages/es.ts b/src/languages/es.ts
index b0e46a5d..eb93cc6e 100644
--- a/src/languages/es.ts
+++ b/src/languages/es.ts
@@ -5514,7 +5514,7 @@ ${amount} para ${merchant} - ${date}`,
noSubsidiariesFoundDescription: 'Añade la subsidiaria en NetSuite y sincroniza de nuevo la conexión',
tokenInput: {
title: 'Netsuite configuración',
- connectWithTokenAuthentication: 'Conectar con autenticación basada en token (SOAP) en su lugar',
+ connectWithTokenAuthentication: 'Conéctate con autenticación basada en tokens (SOAP) en su lugar',
formSteps: {
installBundle: {
title: 'Instala el paquete de Expensify',
diff --git a/src/languages/fr.ts b/src/languages/fr.ts
index 096f4c42..b85b688c 100644
--- a/src/languages/fr.ts
+++ b/src/languages/fr.ts
@@ -5589,7 +5589,7 @@ ${amount} pour ${merchant} - ${date}`,
noSubsidiariesFoundDescription: 'Veuillez ajouter une filiale dans NetSuite et synchroniser à nouveau la connexion',
tokenInput: {
title: 'Configuration NetSuite',
- connectWithTokenAuthentication: 'Se connecter plutôt avec l’authentification basée sur les jetons (SOAP)',
+ connectWithTokenAuthentication: 'Connectez-vous plutôt avec l’authentification par jeton (SOAP)',
formSteps: {
installBundle: {
title: 'Installer le bundle Expensify',
diff --git a/src/languages/it.ts b/src/languages/it.ts
index b01c3a24..9bf4e3b9 100644
--- a/src/languages/it.ts
+++ b/src/languages/it.ts
@@ -5549,7 +5549,7 @@ ${amount} per ${merchant} - ${date}`,
noSubsidiariesFoundDescription: 'Aggiungi una consociata in NetSuite e sincronizza di nuovo la connessione',
tokenInput: {
title: 'Configurazione NetSuite',
- connectWithTokenAuthentication: 'Connettiti invece con l’autenticazione basata su token (SOAP)',
+ connectWithTokenAuthentication: 'Connettiti invece con autenticazione basata su token (SOAP)',
formSteps: {
installBundle: {
title: 'Installa il pacchetto Expensify',
diff --git a/src/languages/ja.ts b/src/languages/ja.ts
index 1d2aacf1..8e832ee4 100644
--- a/src/languages/ja.ts
+++ b/src/languages/ja.ts
@@ -5491,7 +5491,7 @@ ${integrationName === CONST.ONBOARDING_ACCOUNTING_MAPPING.other ? 'あなたの'
noSubsidiariesFoundDescription: 'NetSuite に子会社を追加して、もう一度接続を同期してください',
tokenInput: {
title: 'NetSuite のセットアップ',
- connectWithTokenAuthentication: '代わりにトークンベース認証(SOAP)で接続する',
+ connectWithTokenAuthentication: '代わりにトークンベース認証(SOAP)で接続します',
formSteps: {
installBundle: {
title: 'Expensify バンドルをインストール',
diff --git a/src/languages/nl.ts b/src/languages/nl.ts
index 15d36722..c8b9a238 100644
--- a/src/languages/nl.ts
+++ b/src/languages/nl.ts
@@ -5547,7 +5547,7 @@ ${amount} voor ${merchant} - ${date}`,
noSubsidiariesFoundDescription: 'Voeg een dochteronderneming toe in NetSuite en synchroniseer de verbinding opnieuw',
tokenInput: {
title: 'NetSuite-configuratie',
- connectWithTokenAuthentication: 'In plaats daarvan verbinden met token-gebaseerde verificatie (SOAP)',
+ connectWithTokenAuthentication: 'In plaats daarvan verbinding maken met token-gebaseerde authenticatie (SOAP)',
formSteps: {
installBundle: {
title: 'Installeer de Expensify-bundel',
diff --git a/src/languages/pl.ts b/src/languages/pl.ts
index 6b016b3d..8b7ab0cb 100644
--- a/src/languages/pl.ts
+++ b/src/languages/pl.ts
@@ -5573,7 +5573,7 @@ ${amount} dla ${merchant} - ${date}`,
noSubsidiariesFoundDescription: 'Dodaj proszę jednostkę zależną w NetSuite i ponownie zsynchronizuj połączenie',
tokenInput: {
title: 'Konfiguracja NetSuite',
- connectWithTokenAuthentication: 'Zamiast tego połącz się za pomocą uwierzytelniania opartego na tokenach (SOAP)',
+ connectWithTokenAuthentication: 'Połącz się zamiast tego z użyciem uwierzytelniania opartego na tokenie (SOAP)',
formSteps: {
installBundle: {
title: 'Zainstaluj pakiet Expensify',
diff --git a/src/languages/pt-BR.ts b/src/languages/pt-BR.ts
index 6c93ec1c..d2b4601e 100644
--- a/src/languages/pt-BR.ts
+++ b/src/languages/pt-BR.ts
@@ -5540,7 +5540,7 @@ ${amount} para ${merchant} - ${date}`,
noSubsidiariesFoundDescription: 'Adicione uma subsidiária no NetSuite e sincronize a conexão novamente',
tokenInput: {
title: 'Configuração do NetSuite',
- connectWithTokenAuthentication: 'Em vez disso, conectar com autenticação baseada em token (SOAP)',
+ connectWithTokenAuthentication: 'Conectar com autenticação baseada em token (SOAP) em vez disso',
formSteps: {
installBundle: {
title: 'Instale o pacote do Expensify',
diff --git a/src/languages/zh-hans.ts b/src/languages/zh-hans.ts
index 8ffac9dd..cfc36220 100644
--- a/src/languages/zh-hans.ts
+++ b/src/languages/zh-hans.ts
@@ -5351,7 +5351,7 @@ ${amount},商户:${merchant} - 日期:${date}`,
noSubsidiariesFoundDescription: '请在 NetSuite 中添加一个子公司,然后再次同步连接',
tokenInput: {
title: 'NetSuite 设置',
- connectWithTokenAuthentication: '改用基于令牌的身份验证 (SOAP) 连接',
+ connectWithTokenAuthentication: '改为使用基于令牌的身份验证(SOAP)连接',
formSteps: {
installBundle: {
title: '安装 Expensify 插件包',
Note You can apply these changes to your branch by copying the patch to your clipboard, then running |
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 439e7af56d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| Navigation.navigate( | ||
| ROUTES.POLICY_ACCOUNTING_NETSUITE_TOKEN_INPUT.getRoute(policyID, CONST.NETSUITE_CONFIG.TOKEN_INPUT.PAGE_NAME.AUTHENTICATION, CONST.NETSUITE_CONFIG.TOKEN_INPUT.AUTH_TYPE.TBA), | ||
| ); |
There was a problem hiding this comment.
Clear OAuth history when switching authentication flows
When this link is selected after progressing through the OAuth wizard, Navigation.navigate places the token-authentication screen above the previously pushed OAuth steps. Consequently, browser/system Back immediately returns to the OAuth flow; even using the header Back until reaching the token flow's install page eventually exposes an older OAuth step because prevPage() can only replace the current screen with the missing install?authType=tba route. Reset or realign the wizard history when switching flows so Back cannot silently change the selected authentication method.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
(Yuwen's Agent) Confirmed the mechanism: switchToTokenAuthentication uses Navigation.navigate, so it pushes install?authType=tba on top of the already-pushed OAuth step screens, and Back can walk back into the OAuth flow (prevPage() only replaces the current screen). Real behavior. This link is a dev/beta-only convenience — gated by isDevelopment or the explicit-only netSuiteOAuth beta, and the PR is [No QA]. The deep case needs a dev to advance several OAuth steps, switch, then Back all the way down. Reworking the wizard's stack history is broader than this PR's scope, so I'm flagging it to the author to decide rather than changing navigation here.
| REST: 'enable-rest', | ||
| }, | ||
| AUTH_TYPE: { | ||
| TBA: 'tba', |
There was a problem hiding this comment.
NAB: spell the acronym out, or at least add a comment
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
|
🚧 yuwenmemon has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/yuwenmemon in version: 9.4.82-0 🚀
|
|
No help site changes are required for this PR, so I did not create a draft PR. This change is a developer-only escape hatch. Everything it adds is gated off in production, so nothing a customer reads on the help site becomes wrong. Why no docs change is neededThe new link never renders in production. Production wizard behavior is unchanged. The one new copy string is dev/staging only. The existing articles still match production. Step 12 of Connect to NetSuite (New Expensify) still describes the five token-based steps and the NetSuite Account ID, Token ID, and Token Secret fields ending in Confirm — which is what production users get today, since Heads up for the OAuth rollout: once the There is no help site PR to link, so the closing review request doesn't apply here. @yuwenmemon, if you disagree that production behavior is unchanged, reply with |
|
🚀 Deployed to staging by https://github.com/yuwenmemon in version: 9.4.86-0 🚀
|
|
🤖 No help site changes are required. I did not create a draft PR. Why: this PR changes nothing that a production customer can see.
The current articles still match what production users get. Connect to NetSuite documents the token-based (SOAP) setup — install the bundle, enable Token Based Authentication, assign the Expensify Integration role, create access tokens — which is exactly the wizard everyone outside the One thing to flag for later: the OAuth 2.0 / REST wizard itself (Install the Expensify bundle → Enable OAuth 2.0 → Enable REST web services → Enter your NetSuite credentials) is not documented anywhere in @yuwenmemon — there is no linked help site PR to review, since no article changes are needed. Please confirm you agree with that call. If you want the OAuth 2.0 wizard documented now rather than at rollout, reply and I will open the draft PR. |
|
🚀 Deployed to staging by https://github.com/yuwenmemon in version: 9.4.89-0 🚀
|
|
🚀 Deployed to production by https://github.com/luacmartins in version: 9.4.89-0 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
The
netSuiteOAuthbeta is leaving the explicit-only list, so every account on theallbeta, including every dev account, will get the OAuth 2.0 / REST wizard when connecting NetSuite. Engineers on dev and staging still need to connect over SOAP now and then, and the wizard had no way back to it. Outside production each OAuth step now carries a small link that switches to the token-based (SOAP) steps.The choice travels as an
authType=tbaroute param rather than React state because every wizard step is pushed as its own screen, so component state would reset between steps. In production the link is hidden and the param is ignored, so production beta members always get OAuth.Fixed Issues
For https://github.com/Expensify/Expensify/issues/612599
PROPOSAL: N/A
Tests
netSuiteOAuthbeta, open a Control workspace and go to Accounting > NetSuite > Connect.token-input/authentication?authType=tbaand the step reads Enable token-based authentication.npm test -- tests/unit/pages/workspace/accounting/netsuiteand verify it passes.Offline tests
Same as Tests. The wizard steps are static content, so they work offline. Only the final Connect or Confirm needs a connection.
QA Steps
No QA. Production is unchanged. The link only appears for
netSuiteOAuthbeta members, and staging QA accounts do not have that beta until the Web-Expensify BetaManager change lands.PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari