Skip to content

[No QA] Add a non-production link back to token-based (SOAP) NetSuite setup - #101283

Merged
yuwenmemon merged 6 commits into
mainfrom
yuwen-netsuite-oauth-dev-default
Sep 17, 2026
Merged

yuwenmemon merged 6 commits into
mainfrom
yuwen-netsuite-oauth-dev-default

Conversation

@yuwenmemon

@yuwenmemon yuwenmemon commented Sep 16, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

The netSuiteOAuth beta is leaving the explicit-only list, so every account on the all beta, including every dev account, will get the OAuth 2.0 / REST wizard when connecting NetSuite. Engineers on dev and staging still need to connect over SOAP now and then, and the wizard had no way back to it. Outside production each OAuth step now carries a small link that switches to the token-based (SOAP) steps.

The choice travels as an authType=tba route param rather than React state because every wizard step is pushed as its own screen, so component state would reset between steps. In production the link is hidden and the param is ignored, so production beta members always get OAuth.

Fixed Issues

For https://github.com/Expensify/Expensify/issues/612599
PROPOSAL: N/A

Tests

  1. On dev, with an account on the netSuiteOAuth beta, open a Control workspace and go to Accounting > NetSuite > Connect.
  2. Verify the wizard shows four steps: Install the Expensify bundle, Enable OAuth 2.0, Enable REST web services, Enter your NetSuite credentials.
  3. Verify the last step asks only for the NetSuite Account ID and its button reads Connect.
  4. On any of those steps, click "Connect with token-based authentication (SOAP) instead".
  5. Verify the URL now ends in token-input/authentication?authType=tba and the step reads Enable token-based authentication.
  6. Click Next through Enable SOAP web services and Create an access token.
  7. Verify the credentials step asks for Account ID, Token ID and Token Secret, its button reads Confirm, and the link is gone.
  8. Reload the page on that step and verify the token form is still shown.
  9. Run npm test -- tests/unit/pages/workspace/accounting/netsuite and verify it passes.
  • Verify that no errors appear in the JS console

Offline tests

Same as Tests. The wizard steps are static content, so they work offline. Only the final Connect or Confirm needs a connection.

QA Steps

No QA. Production is unchanged. The link only appears for netSuiteOAuth beta members, and staging QA accounts do not have that beta until the Web-Expensify BetaManager change lands.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

netsuite-oauth-soap-fallback
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@yuwenmemon
yuwenmemon requested review from a team as code owners September 16, 2026 04:39
@melvin-bot
melvin-bot Bot requested review from JmillsExpensify, abdulrahuman5196 and dubielzyk-expensify and removed request for a team September 16, 2026 04:39
@melvin-bot

melvin-bot Bot commented Sep 16, 2026

Copy link
Copy Markdown

@dubielzyk-expensify @abdulrahuman5196 One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 16, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-16T04:52:01.004110Z 439e7af PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@OSBotify

Copy link
Copy Markdown
Contributor

🦜 Polyglot Parrot! 🦜

Squawk! Looks like you added some shiny new English strings. Allow me to parrot them back to you in other tongues:

View the translation diff
diff --git a/src/languages/el.ts b/src/languages/el.ts
index 27c540bc..0fcbf70c 100644
--- a/src/languages/el.ts
+++ b/src/languages/el.ts
@@ -5671,7 +5671,7 @@ ${amount} για ${merchant} - ${date}`,
             noSubsidiariesFoundDescription: 'Παρακαλούμε προσθέστε μια θυγατρική στο NetSuite και συγχρονίστε ξανά τη σύνδεση',
             tokenInput: {
                 title: 'Ρύθμιση NetSuite',
-                connectWithTokenAuthentication: 'Εναλλακτικά, συνδεθείτε με έλεγχο ταυτότητας με διακριτικό token (SOAP)',
+                connectWithTokenAuthentication: 'Συνδεθείτε με έλεγχο ταυτότητας βάσει διακριτικού (SOAP) αντ’ αυτού',
                 formSteps: {
                     installBundle: {
                         title: 'Εγκαταστήστε το πακέτο Expensify',
diff --git a/src/languages/es.ts b/src/languages/es.ts
index b0e46a5d..eb93cc6e 100644
--- a/src/languages/es.ts
+++ b/src/languages/es.ts
@@ -5514,7 +5514,7 @@ ${amount} para ${merchant} - ${date}`,
             noSubsidiariesFoundDescription: 'Añade la subsidiaria en NetSuite y sincroniza de nuevo la conexión',
             tokenInput: {
                 title: 'Netsuite configuración',
-                connectWithTokenAuthentication: 'Conectar con autenticación basada en token (SOAP) en su lugar',
+                connectWithTokenAuthentication: 'Conéctate con autenticación basada en tokens (SOAP) en su lugar',
                 formSteps: {
                     installBundle: {
                         title: 'Instala el paquete de Expensify',
diff --git a/src/languages/fr.ts b/src/languages/fr.ts
index 096f4c42..b85b688c 100644
--- a/src/languages/fr.ts
+++ b/src/languages/fr.ts
@@ -5589,7 +5589,7 @@ ${amount} pour ${merchant} - ${date}`,
             noSubsidiariesFoundDescription: 'Veuillez ajouter une filiale dans NetSuite et synchroniser à nouveau la connexion',
             tokenInput: {
                 title: 'Configuration NetSuite',
-                connectWithTokenAuthentication: 'Se connecter plutôt avec l’authentification basée sur les jetons (SOAP)',
+                connectWithTokenAuthentication: 'Connectez-vous plutôt avec l’authentification par jeton (SOAP)',
                 formSteps: {
                     installBundle: {
                         title: 'Installer le bundle Expensify',
diff --git a/src/languages/it.ts b/src/languages/it.ts
index b01c3a24..9bf4e3b9 100644
--- a/src/languages/it.ts
+++ b/src/languages/it.ts
@@ -5549,7 +5549,7 @@ ${amount} per ${merchant} - ${date}`,
             noSubsidiariesFoundDescription: 'Aggiungi una consociata in NetSuite e sincronizza di nuovo la connessione',
             tokenInput: {
                 title: 'Configurazione NetSuite',
-                connectWithTokenAuthentication: 'Connettiti invece con l’autenticazione basata su token (SOAP)',
+                connectWithTokenAuthentication: 'Connettiti invece con autenticazione basata su token (SOAP)',
                 formSteps: {
                     installBundle: {
                         title: 'Installa il pacchetto Expensify',
diff --git a/src/languages/ja.ts b/src/languages/ja.ts
index 1d2aacf1..8e832ee4 100644
--- a/src/languages/ja.ts
+++ b/src/languages/ja.ts
@@ -5491,7 +5491,7 @@ ${integrationName === CONST.ONBOARDING_ACCOUNTING_MAPPING.other ? 'あなたの'
             noSubsidiariesFoundDescription: 'NetSuite に子会社を追加して、もう一度接続を同期してください',
             tokenInput: {
                 title: 'NetSuite のセットアップ',
-                connectWithTokenAuthentication: '代わりにトークンベース認証(SOAP)で接続する',
+                connectWithTokenAuthentication: '代わりにトークンベース認証(SOAP)で接続します',
                 formSteps: {
                     installBundle: {
                         title: 'Expensify バンドルをインストール',
diff --git a/src/languages/nl.ts b/src/languages/nl.ts
index 15d36722..c8b9a238 100644
--- a/src/languages/nl.ts
+++ b/src/languages/nl.ts
@@ -5547,7 +5547,7 @@ ${amount} voor ${merchant} - ${date}`,
             noSubsidiariesFoundDescription: 'Voeg een dochteronderneming toe in NetSuite en synchroniseer de verbinding opnieuw',
             tokenInput: {
                 title: 'NetSuite-configuratie',
-                connectWithTokenAuthentication: 'In plaats daarvan verbinden met token-gebaseerde verificatie (SOAP)',
+                connectWithTokenAuthentication: 'In plaats daarvan verbinding maken met token-gebaseerde authenticatie (SOAP)',
                 formSteps: {
                     installBundle: {
                         title: 'Installeer de Expensify-bundel',
diff --git a/src/languages/pl.ts b/src/languages/pl.ts
index 6b016b3d..8b7ab0cb 100644
--- a/src/languages/pl.ts
+++ b/src/languages/pl.ts
@@ -5573,7 +5573,7 @@ ${amount} dla ${merchant} - ${date}`,
             noSubsidiariesFoundDescription: 'Dodaj proszę jednostkę zależną w NetSuite i ponownie zsynchronizuj połączenie',
             tokenInput: {
                 title: 'Konfiguracja NetSuite',
-                connectWithTokenAuthentication: 'Zamiast tego połącz się za pomocą uwierzytelniania opartego na tokenach (SOAP)',
+                connectWithTokenAuthentication: 'Połącz się zamiast tego z użyciem uwierzytelniania opartego na tokenie (SOAP)',
                 formSteps: {
                     installBundle: {
                         title: 'Zainstaluj pakiet Expensify',
diff --git a/src/languages/pt-BR.ts b/src/languages/pt-BR.ts
index 6c93ec1c..d2b4601e 100644
--- a/src/languages/pt-BR.ts
+++ b/src/languages/pt-BR.ts
@@ -5540,7 +5540,7 @@ ${amount} para ${merchant} - ${date}`,
             noSubsidiariesFoundDescription: 'Adicione uma subsidiária no NetSuite e sincronize a conexão novamente',
             tokenInput: {
                 title: 'Configuração do NetSuite',
-                connectWithTokenAuthentication: 'Em vez disso, conectar com autenticação baseada em token (SOAP)',
+                connectWithTokenAuthentication: 'Conectar com autenticação baseada em token (SOAP) em vez disso',
                 formSteps: {
                     installBundle: {
                         title: 'Instale o pacote do Expensify',
diff --git a/src/languages/zh-hans.ts b/src/languages/zh-hans.ts
index 8ffac9dd..cfc36220 100644
--- a/src/languages/zh-hans.ts
+++ b/src/languages/zh-hans.ts
@@ -5351,7 +5351,7 @@ ${amount},商户:${merchant} - 日期:${date}`,
             noSubsidiariesFoundDescription: '请在 NetSuite 中添加一个子公司,然后再次同步连接',
             tokenInput: {
                 title: 'NetSuite 设置',
-                connectWithTokenAuthentication: '改用基于令牌的身份验证 (SOAP) 连接',
+                connectWithTokenAuthentication: '改为使用基于令牌的身份验证(SOAP)连接',
                 formSteps: {
                     installBundle: {
                         title: '安装 Expensify 插件包',

Note

You can apply these changes to your branch by copying the patch to your clipboard, then running pbpaste | git apply 😉

View workflow run

@codecov

codecov Bot commented Sep 16, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
src/CONST/index.ts 91.52% <ø> (ø)
...uite/NetSuiteTokenInput/NetSuiteTokenInputPage.tsx 94.44% <100.00%> (+94.44%) ⬆️
...uiteTokenInput/subPages/NetSuiteTokenInputForm.tsx 85.00% <100.00%> (-0.37%) ⬇️
src/ROUTES.ts 29.33% <0.00%> (ø)
...eTokenInput/subPages/NetSuiteTokenSetupContent.tsx 0.00% <0.00%> (ø)
...uiteTokenInput/NetSuiteTokenAuthenticationLink.tsx 0.00% <0.00%> (ø)
... and 16 files with indirect coverage changes

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 439e7af56d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +23 to +25
Navigation.navigate(
ROUTES.POLICY_ACCOUNTING_NETSUITE_TOKEN_INPUT.getRoute(policyID, CONST.NETSUITE_CONFIG.TOKEN_INPUT.PAGE_NAME.AUTHENTICATION, CONST.NETSUITE_CONFIG.TOKEN_INPUT.AUTH_TYPE.TBA),
);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Clear OAuth history when switching authentication flows

When this link is selected after progressing through the OAuth wizard, Navigation.navigate places the token-authentication screen above the previously pushed OAuth steps. Consequently, browser/system Back immediately returns to the OAuth flow; even using the header Back until reaching the token flow's install page eventually exposes an older OAuth step because prevPage() can only replace the current screen with the missing install?authType=tba route. Reset or realign the wizard history when switching flows so Back cannot silently change the selected authentication method.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Yuwen's Agent) Confirmed the mechanism: switchToTokenAuthentication uses Navigation.navigate, so it pushes install?authType=tba on top of the already-pushed OAuth step screens, and Back can walk back into the OAuth flow (prevPage() only replaces the current screen). Real behavior. This link is a dev/beta-only convenience — gated by isDevelopment or the explicit-only netSuiteOAuth beta, and the PR is [No QA]. The deep case needs a dev to advance several OAuth steps, switch, then Back all the way down. Reworking the wizard's stack history is broader than this PR's scope, so I'm flagging it to the author to decide rather than changing navigation here.

@yuwenmemon
yuwenmemon requested a review from akinwale September 16, 2026 07:15
@yuwenmemon yuwenmemon changed the title [No QA] Default dev to the NetSuite OAuth connect flow with a SOAP fallback link [No QA] Let NetSuite OAuth beta members fall back to token-based (SOAP) setup Sep 16, 2026
@yuwenmemon yuwenmemon changed the title [No QA] Let NetSuite OAuth beta members fall back to token-based (SOAP) setup [No QA] Add a dev-only link back to token-based (SOAP) NetSuite setup Sep 16, 2026
@yuwenmemon yuwenmemon changed the title [No QA] Add a dev-only link back to token-based (SOAP) NetSuite setup [No QA] Add a non-production link back to token-based (SOAP) NetSuite setup Sep 16, 2026

@JmillsExpensify JmillsExpensify left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akinwale akinwale left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread src/CONST/index.ts
REST: 'enable-rest',
},
AUTH_TYPE: {
TBA: 'tba',

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NAB: spell the acronym out, or at least add a comment

@francoisl

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Android: mWeb Chrome
iOS: HybridApp
iOS: mWeb Safari
MacOS: Chrome / Safari

@yuwenmemon
yuwenmemon merged commit 13d56e2 into main Sep 17, 2026
46 of 49 checks passed
@yuwenmemon
yuwenmemon deleted the yuwen-netsuite-oauth-dev-default branch September 17, 2026 20:37
@github-actions

Copy link
Copy Markdown
Contributor

🚧 yuwenmemon has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/yuwenmemon in version: 9.4.82-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 cancelled 🔪
🍎 iOS 🍎 cancelled 🔪

@MelvinBot

Copy link
Copy Markdown
Contributor

No help site changes are required for this PR, so I did not create a draft PR.

This change is a developer-only escape hatch. Everything it adds is gated off in production, so nothing a customer reads on the help site becomes wrong.

Why no docs change is needed

The new link never renders in production. NetSuiteTokenInputPage.tsx:59 gates it on canUseNetSuiteOAuth && !isProduction, and line 117 passes that same flag down as shouldShowTokenAuthenticationLink. The authType=tba route param is ignored in production because isTokenAuthenticationSelected depends on the same gate.

Production wizard behavior is unchanged. NetSuiteTokenInputForm used to read the beta itself; it now receives isOAuthFlow as a prop. In production that value still resolves to the beta check alone, so the steps, the input fields, and the button label are identical to before this PR.

The one new copy string is dev/staging only. workspace.netsuite.tokenInput.connectWithTokenAuthentication ("Connect with token-based authentication (SOAP) instead") is rendered only by the gated link, so it is not customer-facing copy.

The existing articles still match production. Step 12 of Connect to NetSuite (New Expensify) still describes the five token-based steps and the NetSuite Account ID, Token ID, and Token Secret fields ending in Confirm — which is what production users get today, since netSuiteOAuth is still beta-gated there.

Heads up for the OAuth rollout: once the netSuiteOAuth wizard reaches production, Step 12 of both Connect to NetSuite (New Expensify) and Connect to NetSuite (Expensify Classic) will need rewriting — the wizard drops to four steps (Install the Expensify bundle, Enable OAuth 2.0, Enable REST web services, Enter your NetSuite credentials), the final step asks only for the NetSuite Account ID, and the button reads Connect. The earlier NetSuite-side steps about creating access tokens and the "exports via SOAP Web Services" note would also need revisiting. That is a separate change to make when the beta ships, not something to publish while production is still on token-based authentication.

There is no help site PR to link, so the closing review request doesn't apply here. @yuwenmemon, if you disagree that production behavior is unchanged, reply with @MelvinBot and the correction and I'll open the draft docs PR.


view run

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/yuwenmemon in version: 9.4.86-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor

🤖 No help site changes are required. I did not create a draft PR.

Why: this PR changes nothing that a production customer can see.

  • The new Connect with token-based authentication (SOAP) instead link is rendered only when canSwitchToTokenAuthentication is true, which requires !isProduction — see NetSuiteTokenInputPage.tsx:53. On production the link is hidden and the authType=tba route param is ignored.
  • Everything else is a refactor: isOAuthFlow moves from a direct beta check inside the form to a prop passed down from the page (NetSuiteTokenInputForm.tsx:35). Same production output.
  • The only new copy, connectWithTokenAuthentication, belongs to that non-production link.

The current articles still match what production users get. Connect to NetSuite documents the token-based (SOAP) setup — install the bundle, enable Token Based Authentication, assign the Expensify Integration role, create access tokens — which is exactly the wizard everyone outside the netSuiteOAuth beta sees.

One thing to flag for later: the OAuth 2.0 / REST wizard itself (Install the Expensify bundle → Enable OAuth 2.0 → Enable REST web services → Enter your NetSuite credentials) is not documented anywhere in docs/articles. That gap predates this PR, but it will need an article update before the netSuiteOAuth beta reaches production customers. Tag me on that rollout PR and I will draft it.

@yuwenmemon — there is no linked help site PR to review, since no article changes are needed. Please confirm you agree with that call. If you want the OAuth 2.0 wizard documented now rather than at rollout, reply and I will open the draft PR.


view run

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/yuwenmemon in version: 9.4.89-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/luacmartins in version: 9.4.89-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 failure ❌

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants