Repository navigation
Show a Pending status for Expensify Cards awaiting issue or activation - #101399
luacmartins merged 8 commits into
Conversation
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx bun ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
|
@mkhutornyi Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
🚧 flaviadefaria has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
@flaviadefaria, Thanks for catching that.
On the I can switch it back so all the Inactive badges match, though it would then be the same tangerine as |
|
Ok so just to confirm:
Is this all correct? |
@flaviadefaria, Almost, two things to add:
Here they are together:
|
|
@marufsharifi Thanks, this is really helpful! So it sounds like we use the tangerine color whenever we need the user to take action, which makes sense to me. Let’s keep it as is. |
🦜 Polyglot Parrot! 🦜Squawk! Looks like you added some shiny new English strings. Allow me to parrot them back to you in other tongues: View the translation diffdiff --git a/src/languages/de.ts b/src/languages/de.ts
index 2e048d88..2c72e406 100644
--- a/src/languages/de.ts
+++ b/src/languages/de.ts
@@ -2754,6 +2754,7 @@ const translations: TranslationDeepObject<typeof en> = {
fixConnectionIn: (companyCardsRoute: string) => `Bitte beheben Sie diese Verbindung in <a href="${companyCardsRoute}">Firmenkarten</a>`,
askAdminToFixConnection: 'Bitte bitten Sie eine(n) Admin, diese Verbindung zu reparieren',
reconnectBank: 'Ihre Bankverbindung muss erneut authentifiziert werden',
+ pending: 'Ausstehend',
},
bankAccountStatus: {
active: 'Aktiv',
diff --git a/src/languages/el.ts b/src/languages/el.ts
index 978da716..d6b72920 100644
--- a/src/languages/el.ts
+++ b/src/languages/el.ts
@@ -2812,6 +2812,7 @@ const translations: TranslationDeepObject<typeof en> = {
fixConnectionIn: (companyCardsRoute: string) => `Παρακαλούμε διορθώστε αυτήν τη σύνδεση στις <a href="${companyCardsRoute}">εταιρικές κάρτες</a>`,
askAdminToFixConnection: 'Παρακαλούμε ζητήστε από έναν διαχειριστή να διορθώσει αυτήν τη σύνδεση',
reconnectBank: 'Η σύνδεσή σας με την τράπεζα χρειάζεται επαναπιστοποίηση',
+ pending: 'Σε εκκρεμότητα',
},
bankAccountStatus: {
active: 'Ενεργό',
diff --git a/src/languages/es.ts b/src/languages/es.ts
index 44ed1ed6..d656551d 100644
--- a/src/languages/es.ts
+++ b/src/languages/es.ts
@@ -2674,6 +2674,7 @@ const translations: TranslationDeepObject<typeof en> = {
fixConnectionIn: (companyCardsRoute) => `Por favor, corrige esta conexión en <a href="${companyCardsRoute}">tarjetas de la empresa</a>`,
askAdminToFixConnection: 'Pídele a un administrador que solucione esta conexión',
reconnectBank: 'Tu conexión bancaria necesita volver a autenticarse',
+ pending: 'Pendiente',
},
bankAccountStatus: {
active: 'Activo',
diff --git a/src/languages/fr.ts b/src/languages/fr.ts
index 0d793dae..b51164ce 100644
--- a/src/languages/fr.ts
+++ b/src/languages/fr.ts
@@ -2758,6 +2758,7 @@ const translations: TranslationDeepObject<typeof en> = {
fixConnectionIn: (companyCardsRoute: string) => `Veuillez corriger cette connexion dans <a href="${companyCardsRoute}">cartes d’entreprise</a>`,
askAdminToFixConnection: 'Veuillez demander à un administrateur de corriger cette connexion',
reconnectBank: 'Votre connexion bancaire doit être réauthentifiée',
+ pending: 'En attente',
},
bankAccountStatus: {
active: 'Actif',
diff --git a/src/languages/it.ts b/src/languages/it.ts
index 4f26513f..757309ac 100644
--- a/src/languages/it.ts
+++ b/src/languages/it.ts
@@ -2744,6 +2744,7 @@ const translations: TranslationDeepObject<typeof en> = {
fixConnectionIn: (companyCardsRoute: string) => `Correggi questa connessione in <a href="${companyCardsRoute}">carte aziendali</a>`,
askAdminToFixConnection: 'Chiedi a un amministratore di correggere questa connessione',
reconnectBank: 'La connessione con la tua banca deve essere nuovamente autenticata',
+ pending: 'In sospeso',
},
bankAccountStatus: {
active: 'Attiva',
diff --git a/src/languages/ja.ts b/src/languages/ja.ts
index 42828ac5..a0317e13 100644
--- a/src/languages/ja.ts
+++ b/src/languages/ja.ts
@@ -2722,6 +2722,7 @@ const translations: TranslationDeepObject<typeof en> = {
fixConnectionIn: (companyCardsRoute: string) => `この接続を<a href="${companyCardsRoute}">会社カード</a>で修正してください`,
askAdminToFixConnection: '管理者にこの接続の修正を依頼してください',
reconnectBank: '銀行連携の再認証が必要です',
+ pending: '保留中',
},
bankAccountStatus: {
active: 'アクティブ',
diff --git a/src/languages/nl.ts b/src/languages/nl.ts
index 05e69b44..3c7b4014 100644
--- a/src/languages/nl.ts
+++ b/src/languages/nl.ts
@@ -2747,6 +2747,7 @@ const translations: TranslationDeepObject<typeof en> = {
fixConnectionIn: (companyCardsRoute: string) => `Repareer deze verbinding in <a href="${companyCardsRoute}">bedrijfskaarten</a>`,
askAdminToFixConnection: 'Vraag een/beheerder om deze verbinding te herstellen',
reconnectBank: 'Je bankverbinding moet opnieuw worden geverifieerd',
+ pending: 'In behandeling',
},
bankAccountStatus: {
active: 'Actief',
diff --git a/src/languages/pl.ts b/src/languages/pl.ts
index 5c910217..1324b277 100644
--- a/src/languages/pl.ts
+++ b/src/languages/pl.ts
@@ -2779,6 +2779,7 @@ const translations: TranslationDeepObject<typeof en> = {
fixConnectionIn: (companyCardsRoute: string) => `Napraw to połączenie w <a href="${companyCardsRoute}">firmowe karty</a>`,
askAdminToFixConnection: 'Poproś administratora o naprawienie tego połączenia',
reconnectBank: 'Twoje połączenie z bankiem wymaga ponownego uwierzytelnienia',
+ pending: 'Oczekujące',
},
bankAccountStatus: {
active: 'Aktywne',
diff --git a/src/languages/pt-BR.ts b/src/languages/pt-BR.ts
index 3287f909..86dff6b3 100644
--- a/src/languages/pt-BR.ts
+++ b/src/languages/pt-BR.ts
@@ -2739,6 +2739,7 @@ const translations: TranslationDeepObject<typeof en> = {
fixConnectionIn: (companyCardsRoute: string) => `Corrija esta conexão em <a href="${companyCardsRoute}">cartões corporativos</a>`,
askAdminToFixConnection: 'Peça para um administrador corrigir essa conexão',
reconnectBank: 'Sua conexão bancária precisa ser autenticada novamente',
+ pending: 'Pendente',
},
bankAccountStatus: {
active: 'Ativo',
diff --git a/src/languages/zh-hans.ts b/src/languages/zh-hans.ts
index 8386da74..605cf19c 100644
--- a/src/languages/zh-hans.ts
+++ b/src/languages/zh-hans.ts
@@ -2649,6 +2649,7 @@ const translations: TranslationDeepObject<typeof en> = {
fixConnectionIn: (companyCardsRoute: string) => `请在<a href="${companyCardsRoute}">公司卡</a>中修复此连接`,
askAdminToFixConnection: '请联系管理员修复此连接',
reconnectBank: '您的银行连接需要重新验证',
+ pending: '待处理',
},
bankAccountStatus: {
active: '活跃',
Note You can apply these changes to your branch by copying the patch to your clipboard, then running |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
@mkhutornyi ready for review when you get a chance, thanks! |
|
@mkhutornyi, Gentle bump. thanks. |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppScreen.Recording.2026-09-23.at.6.05.54.PM.moviOS: mWeb SafariMacOS: Chrome / SafariScreen.Recording.2026-09-23.at.6.03.35.PM.mov |
|
Reviewed the diff. The approach is sound and state coverage is complete — the wallet only lists states 2, 3, 4, 7, so 7 → 1. Virtual cards now disagree with the workspace card table. 2. The suspended-before-pending ordering is unreachable, and its test asserts an impossible card. Minor points
I reviewed this statically only — I couldn't drive the web build in a browser on this run, so I did not visually confirm the tangerine |
|
Code-quality pass (separate from the correctness review I posted earlier). The diff is clean overall — comments explain why rather than what, no magic values, no AI jargon, and replacing the nested ternary with explicit early returns is a genuine readability win. Two things I'd change: 1. The pending-state pair is now duplicated three times. 2. Minor
Static analysis only — browser verification wasn't available on this run, so I didn't exercise the wallet UI or run the tests locally. All CI checks are green apart from the reviewer-approval gate. |
|
@mkhutornyi addressed, could you take another look? Thanks |
|
🤖 Regression review — 2 things worth changing before merge, 2 minor. The logic refactors are clean and behavior-identical. The risk in this PR is the tone picked for the new badge, not the state detection. 1. The red
|
| Step | Status |
|---|---|
| ✅ | |
Payment method rows render with no missing or blank badgesAccount has no bank accounts or cards, so both sections showed their normal empty states. No malformed UI. |
✅ |
Report the status badge text on each rowNo rows exist on this account, so no badges could be observed. Not a defect — a test-data gap. |
Next Steps: Reply with @MelvinBot <your feedback> to dig into any of these.
The tone isn't severity here — tangerine means the user needs to act. Flaviadefaria confirmed that earlier in this PR:
They're answering different questions. The workspace table tracks where the card is in fulfilment, so "Pending order" and "Shipped" belong there. The wallet badge sits beside Active and Inactive and tells the cardholder one thing: whether they can spend on it yet. |
|
yup nothing to fix there |
|
🚧 luacmartins has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/luacmartins in version: 9.4.94-0 🚀
|
|
Yes, help site changes are needed. I opened a draft PR: Docs updates for E/A#101399 Document the Pending Expensify Card status in Wallet. It is labeled The Troubleshoot article listed only Active and Inactive for Expensify Cards in Wallet. This PR adds Pending, which the PR above introduced. What changed
I checked the Account tab, the Wallet page, and the Cards section names in the live web UI. The Active, Pending, and Inactive labels come from @marufsharifi, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR |
|
@marufsharifi We are stuck at step 4. For some reason we can not ship the card due to error. Tried with E account and gmail accounts. How we can avoid this? Thanks you
|
@luacmartins can you help with this to unblock app deploy please |
|
🚀 Deployed to production by https://github.com/Julesssss in version: 9.4.94-0 🚀
Bundle Size Analysis (Sentry): |






Explanation of Change
A newly issued Expensify Card sits in one of two setup states before it can be used: waiting to be issued, and waiting for the cardholder to activate it. In both, the wallet showed the card as
Active- right next to the prompt asking the user to finish setting it up. The status said the card was ready while the row told them it wasn't.The wallet only knew whether a card was suspended, and treated everything else as active.
Expensify Cards now report one of three statuses:
Pendingwhile the card is waiting to be issued or activatedInactiveonce the back end has suspended itActivewhen it can be spent onSuspended is checked first, so a card that has been turned off never reads as merely waiting. Frozen cards, company cards and personal cards are unchanged.
The status comes from the card's state, but only for a physical card. A virtual card is issued and spendable as soon as it's assigned, with no activation step, so it never reads
Pending.Fixed Issues
$ #99971
PROPOSAL:
Tests
STATE_NOT_ISSUED.Pendingbadge rather thanActive.NOT_ACTIVATED, and verify it still showsPending.Active.Inactive.Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari