Repository navigation
Align workspace selector logic - #101430
roryabraham merged 4 commits into
Conversation
|
@codex review |
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
|
@sobitneupane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
trjExpensify
left a comment
There was a problem hiding this comment.
Thanks for clearing this up! 👍
|
@sobitneupane kind bump |
There was a problem hiding this comment.
Screenshots/Videos
Android: HybridApp
Screen.Recording.2026-09-21.at.14.27.04.mov
Android: mWeb Chrome
Screen.Recording.2026-09-21.at.14.10.23.mov
iOS: HybridApp
Screen.Recording.2026-09-21.at.14.18.04.mov
iOS: mWeb Safari
Screen.Recording.2026-09-21.at.13.52.55.mov
MacOS: Chrome / Safari
Screen.Recording.2026-09-21.at.13.36.14.mov
Screen.Recording.2026-09-21.at.13.36.56.mov
Screen.Recording.2026-09-21.at.13.42.43.mov
Screen.Recording.2026-09-21.at.13.32.52.mov
I have tested a few scenarios and they all work as expected. However, I was not able to test scenario 2 (domain locks user to a preferred workspace) because I couldn't set up the scenario. |
sobitneupane
left a comment
There was a problem hiding this comment.
Reviewer Checklist
- I have verified the author checklist is complete (all boxes are checked off).
- I verified the correct issue is linked in the
### Fixed Issuessection above - I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the
Testssection - I verified the steps for Staging and/or Production testing are in the
QA stepssection - I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I verified the steps for local testing are in the
- I checked that screenshots or videos are included for tests on all platforms
- I included screenshots or videos for tests on all platforms
- I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
- I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
- I verified proper code patterns were followed (see Reviewing the code)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
- I verified that this PR follows the guidelines as stated in the Review Guidelines
- I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like
Avatar, I verified the components usingAvatarhave been tested & I retested again) - If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
- If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e.
StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
- If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
- If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like
Avataris modified, I verified thatAvataris working as expected in all cases) - If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
- If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
- If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added
Designlabel and/or tagged@Expensify/designso the design team can review the changes.
- For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
- If the
mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps. - I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.
Screenshots/Videos
Android: HybridApp
Screen.Recording.2026-09-21.at.14.27.04.mov
Android: mWeb Chrome
Screen.Recording.2026-09-21.at.14.10.23.mov
iOS: HybridApp
Screen.Recording.2026-09-21.at.14.18.04.mov
iOS: mWeb Safari
Screen.Recording.2026-09-21.at.13.52.55.mov
MacOS: Chrome / Safari
Screen.Recording.2026-09-21.at.13.36.14.mov
Screen.Recording.2026-09-21.at.13.36.56.mov
Screen.Recording.2026-09-21.at.13.42.43.mov
Screen.Recording.2026-09-21.at.13.32.52.mov
|
🚧 roryabraham has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/roryabraham in version: 9.4.92-0 🚀
|
|
Yes — help site changes are required. Draft PR: Docs updates for E/A#101430 clarify which workspace new reports open on ( Why: this PR changes which workspace a new report lands on, and the help site documented only the old, simpler rule.
Today Create-and-Submit-Reports.md says only "Reports are opened on your default workspace" — no mention of the Preferred Workspace override, and no mention of when a member is asked to Choose a workspace for this report. What the docs PR changes
Labels were checked against One case I left out: when the preferred workspace owner is past due beyond the grace period, the restricted-action page opens instead (scenario 2, step 4 of your test steps). Tell me if you want that documented and I'll add it. @jmusial, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR |
|
Deploy Blocker #102130 was identified to be related to this PR. |
|
🚀 Deployed to production by https://github.com/lakchote in version: 9.4.92-8 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
A follow up to #98973. Details in #98973 (comment).
Fixed Issues
$ #101560
PROPOSAL:
Tests
Scenario 1 (default workspace beyond the first two)
Scenario 2 (domain locks user to a preferred workspace)
Offline tests
N/A
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
MacOS: Chrome / Safari
Scenario 1
Screen.Recording.2026-09-18.at.13.58.46.mov
Scenario 2
Screen.Recording.2026-09-18.at.13.59.21.mov
Screen.Recording.2026-09-18.at.14.00.39.mov