Repository navigation
Part 16a - Thread delegateAccountID through the change-workspace report preview - #101451
Conversation
…rt preview Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
|
@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
dylanexpensify
left a comment
There was a problem hiding this comment.
Product input not required
|
@DylanDylann friendly bump |
|
@DylanDylann bump! |
Reviewer Checklist
Screenshots/VideosScreen.Recording.2026-09-25.at.14.59.27.mov |
|
🚧 madmax330 has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/madmax330 in version: 9.4.94-0 🚀
|
|
No help site changes are required for this PR, so I did not create a docs PR. This PR fixes internal data flow. It passes Why no docs update is needed
|
|
🚀 Deployed to production by https://github.com/Julesssss in version: 9.4.94-0 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
delegateAccountIDfrom the Change Workspace page throughbuildOptimisticChangePolicyDatatobuildOptimisticReportPreview, removing the need for the Onyx fallback. Also setsdelegateAccountIDon theCHANGE_POLICYsystem message, so a copilot's workspace change correctly shows the delegator immediately instead of switching after the API response. ReordersdelegateAccountIDParamso it can be required.Fixed Issues
$ #66425
PROPOSAL:
Tests
Prerequisite: Two accounts. A owns an expense report and is an admin of another eligible workspace. B is A's copilot.
Offline tests
QA Steps
Same as tests
Verify that no errors appear in the JS console
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Monosnap.screencast.2026-09-17.22-59-23.mp4