Repository navigation
Expense-Error is shown when vacation delegate clicks "Download as PDF" on rejected expense - #101515
Conversation
|
@abdulrahuman5196 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppandroidHybrid-0-Screen_Recording_2026-09-24_at_1.10.03.PM.movAndroid: mWeb ChromeandroidMWeb-0-Screen_Recording_2026-09-24_at_1.13.50.PM.moviOS: HybridAppiosHybrid-0-Screen_Recording_2026-09-24_at_1.02.25.PM.moviOS: mWeb SafariiosMWeb-0-Screen_Recording_2026-09-24_at_12.45.20.PM.movMacOS: Chrome / SafarimacOS-0-Screen_Recording_2026-09-24_at_12.38.02.PM.mov |
abdulrahuman5196
left a comment
There was a problem hiding this comment.
Changes looks good and works well. Reviewers checklist is also complete.
All yours. @mollfpr
🎀 👀 🎀
C+ Reviewed
|
🚧 mollfpr has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/mollfpr in version: 9.4.94-0 🚀
|
|
Yes, help site changes are required. I opened a draft PR: Docs updates for E/A#101515 Download report hidden for non-submitters on Draft reports. This PR hides Download report on Draft reports, including rejected reports, for everyone except the submitter. The help site said all roles could use it on any report. Changes:
I added the @lorretheboy, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR |
|
🚀 Deployed to production by https://github.com/Julesssss in version: 9.4.94-0 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Fixed Issues
$ #94728
PROPOSAL: #94728 (comment)
Tests
Preconditions:
Account A: workspace owner
Account B: workspace approver
Account C: vacation delegate
Account D: workspace submitter
As Account A, create a workspace and invite Account B (approver), Account C, and Account D (submitter) as members. As Account B, set Account C as B's vacation delegate via Account > Profile > Status > Vacation delegate.
Offline tests
QA Steps
Preconditions:
Account A: workspace owner
Account B: workspace approver
Account C: vacation delegate
Account D: workspace submitter
As Account A, create a workspace and invite Account B (approver), Account C, and Account D (submitter) as members. As Account B, set Account C as B's vacation delegate via Account > Profile > Status > Vacation delegate.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2026-09-19.at.02.43.20.mov
Android: mWeb Chrome
iOS: Native
Screen.Recording.2026-09-19.at.02.39.51.mov
iOS: mWeb Safari
Screen.Recording.2026-09-19.at.02.38.24.mov
MacOS: Chrome / Safari
Screen.Recording.2026-09-19.at.02.35.54.mov