Repository navigation
Conversation
Co-authored-by: Alex Beaman <Beamanator@users.noreply.github.com>
2 tasks done
Contributor
|
A preview of your ExpensifyHelp changes have been deployed to https://d7044189.helpdot.pages.dev ⚡️ Updated articles: |
Contributor
|
Handling in #101141 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Release DualEntry vendor matching from the beta made vendor matching generally available for configured DualEntry workspaces — the
vendorMatchingbeta is no longer required.hasVendorFeaturenow returnstruefor a configured DualEntry connection on its own, the Vendors row on More features treats DualEntry as generally available, and the product-marketing CTA routes a configured DualEntry workspace to Vendors even when the beta is off. Xero and Rillet still require the beta.The help site had a
Manage Vendor Matching for <integration>article for QuickBooks Online, Sage Intacct, Xero, and Rillet, but none for DualEntry. Now that the feature is generally available, DualEntry admins need a public, indexed article like the QuickBooks Online and Sage Intacct ones.This PR:
docs/articles/new-expensify/connections/dualentry/Manage-Vendor-Matching-for-DualEntry.md. It is indexed (nonoindex/sitemap: false) and carries no beta rollout disclaimer, matching the other generally available integrations. The Rillet article keeps its "rolling out gradually" wording because Rillet is still beta-gated.Configure-DualEntry.mdto the new article, next to the existing export settings content.UI labels used in the article were taken from the merged code and confirmed against the live web app where reachable:
No code changes; docs only.
Fixed Issues
$ #101459
PROPOSAL: N/A
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
What Melvin already ran on this branch:
./.github/scripts/createDocsRoutes.sh— passed,docs/routes.ymlis already up to date with the new article.npm run spell-changed— passed, 0 issues across both changed files.npx prettier --checkcould not run in this environment: the sandbox's parent.prettierrc.jsfails to resolve@trivago/prettier-plugin-sort-imports. This is unrelated to the changes.Verify that no errors appear in the JS console
Offline tests
N/A — documentation only.
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Not applicable — this PR only adds and edits help site markdown under
docs/articles. No app UI changes.@Beamanator, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.