Repository navigation
[Payment due @Ollyws] Show reimbursement ETA in payment report actions - #101646
Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7c13910e63
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 21176d9197
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
joekaufmanexpensify
left a comment
There was a problem hiding this comment.
Nice, great improvement.
Reviewer Checklist
Screenshots/Videos |
|
🎯 @Ollyws, thanks for reviewing and testing this PR! 🎉 A payment issue will be created for your review once this PR is deployed to production. If payment is not needed (e.g., regression PR review fix etc), react with 👎 to this comment to prevent the payment issue from being created. |
|
🚧 blimpich has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/blimpich in version: 9.4.94-0 🚀
|
|
Yes, a small help site update is needed. I opened a draft PR: Docs updates for E/A#101646 Show where to find the expected reimbursement date Payment messages sent from a business bank account now keep Waiting for payment to complete by and the expected date. No help article told members where to find this date. The draft PR changes two articles:
I checked the UI text against the merged @deetergp, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR |
|
@deetergp We don't have a correct account for this. Could you please verify this internally?
|
|
@izarutskaya as Scott is ooo, we can get it tested on a real customers account once it hits production (the issues already exists on prod currently) |
|
🚀 Deployed to production by https://github.com/Julesssss in version: 9.4.94-0 🚀
Bundle Size Analysis (Sentry): |
|
🤖 Payment issue created: #102455 |





Explanation of Change
NewDot intentionally hides NewDot-created
REIMBURSEDactions and shows their IOUPAYactions instead. The visible action previously omitted the estimated bank deposit date, so that information disappeared when the temporary report-header status expired. This change displays the persistedexpectedDateon ACH payment comments and falls back to the preceding hiddenREIMBURSEDaction for historical reports created before the backend began copying the date ontoPAY. New payments receive the field directly from https://github.com/Expensify/Auth/pull/24676.Fixed Issues
$ https://github.com/Expensify/Expensify/issues/682045
PROPOSAL: N/A
Tests
PAYaction does not containexpectedDatebut whose hiddenREIMBURSEDaction does.Offline tests
The change only renders data already stored in Onyx. No new network or mutation behavior is introduced.
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Not tested manually.
Android: mWeb Chrome
Not tested manually.
iOS: Native
Not tested manually.
iOS: mWeb Safari
Not tested manually.
MacOS: Chrome / Safari
Not tested manually.