Repository navigation
Add NOK, SEK, ZAR to auto-update government distance rates - #101656
Conversation
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx bun ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
@AndrewGable Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
No C+ review needed, simple change. This is safe to deploy now because the Auth PR is on production, and the Web-Expensify PR just enables this by default for control policies on these currencies. Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
|
🚧 neil-marcellini has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/neil-marcellini in version: 9.4.95-0 🚀
|
|
Yes, this PR needs a help site update. I created a draft PR for it: Docs updates for E/A#101656 Add Norway, Sweden, and South Africa government rates. Set-distance-rates.md said only USD, CAD, GBP, and AUD workspaces support Auto-update government rates. The draft PR makes these changes:
The UI labels and country names match @ShridharGoel, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR |
|
Deploy Blocker #102493 was identified to be related to this PR. |
|
🚀 Deployed to production by https://github.com/Julesssss in version: 9.4.95-4 🚀
|
Explanation of Change
Adds Norway (NOK), Sweden (SEK), and South Africa (ZAR) to the "Auto-update government rates" feature for distance rates, as scoped in the linked issue (R4).
NOK -> NO,SEK -> SE,ZAR -> ZAtoGOVERNMENT_RATE_CURRENCY_TO_COUNTRY, andNO,SE,ZA(allkm) toGOVERNMENT_RATE_COUNTRY_TO_UNITinCONST. This makes the "Auto-update government rate" toggle visible for workspaces with these currencies.NO,SE,ZAcountry phrases togovernmentRateCountriesin all language files, so the toggle copy reads e.g. "Automatically create new rates when Norway publishes new guidance."Note: the toggle only works end-to-end once the backend PRs (Auth, Web-Expensify) are deployed, since the backend owns the seeded rates and the auto-update logic.
Fixed Issues
For https://github.com/Expensify/Expensify/issues/683070
PROPOSAL:
Tests
Prerequisites: a Control workspace where you're an admin, with Distance rates enabled under More features.
Offline tests
N/A - the change only extends a static currency list, no network-dependent behavior changes.
QA Steps
Same as tests. Note: turning the toggle on only works once the backend PRs are on staging.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
MacOS: Chrome / Safari
Screen.Recording.2026-09-20.at.7.29.49.PM.mov