Repository navigation
Conversation
mateuuszzzzz
left a comment
There was a problem hiding this comment.
Code looks solid! Did you test it locally by building app twice from different directories? Does checksum remain stable?
@mateuuszzzzz Yes, the checksum seems to be stable among different build paths |
|
@mkhutornyi Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: mWeb SafariMacOS: Chrome / Safari |
|
We did not find an internal engineer to review this PR, trying to assign a random engineer to #101728 as well as to this PR... Please reach out for help on Slack if no one gets assigned! |
🤖 Code reviewThe approach is sound — the tarball basename ( Four things below. Only the first is worth blocking on. 1. A second user on the same Mac hard-fails
|
…le-rncore-artifacts-path
|
@mkhutornyi I will push commit regarding review in a moment – I’m investigating one possible problem which arised just now |
|
|
|
@mkhutornyi Just pushed changes regarding Melvin's comments and regenerated standalone's |
mkhutornyi
left a comment
There was a problem hiding this comment.
Revert all unrelated changes.
Only hermes-engine and React-Core-prebuilt
🤖 Code reviewThe Ruby side is in good shape now — the staging symlink is cleaned up on both paths, the stale comment about Three things. The first is the one I'd hold on. 1. The regenerated lockfile carries changes this PR doesn't explainOnly I can't reproduce that dependency from this branch. Most likely the regeneration ran against a 2.
|
|
@mkhutornyi Reverted those. We'll also need to regenerate Mobile-Expensify's |
🤖 Code reviewAll three findings from the last round are addressed. The lockfile is down to exactly the two intended checksums, One regression in the newest commit.
|
|
🚧 inimaga has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/inimaga in version: 9.4.94-0 🚀
|
|
🚀 Deployed to production by https://github.com/Julesssss in version: 9.4.94-0 🚀
Bundle Size Analysis (Sentry): |

Explanation of Change
Before these changes,
React-Core-prebuilt's podspec used the downloaded tarball's path underPodsas itssource. CocoaPods hashes the podspec intoSPEC CHECKSUMS, so the lockfile ended up different for every developer. The podspec now points at a symlink under a path that reads the same on every machine.The same applied to
HERMES_CLI_PATH, which react-native's podspec fills in withrequire.resolve.It now reads
${PODS_ROOT}/../../node_modules/..., which Xcode expands before the bundling phase.Ran
pod installon the same checkout from three different directories. Both checksums came out thesame every time:
Also built the app in Release: hermesc ran through the expanded path and produced a bytecode bundle.
Fixed Issues
$ #101728
PROPOSAL:
Tests
cd ios && bundle exec pod installgrep -E 'React-Core-prebuilt:|hermes-engine:' Podfile.lockand note both checksums.mv ~/dev/expensify-app ~/dev/expensify-app-moved), then drop what would be reused:rm -f "Pods/Local Podspecs/React-Core-prebuilt.podspec.json" "Pods/Local Podspecs/hermes-engine.podspec.json" && rm -rf /tmp/expensify-react-native-artifactsReact-Core-prebuiltsource readsfile:///tmp/expensify-react-native-artifacts/...andHERMES_CLI_PATHreads${PODS_ROOT}/../../node_modules/..., neither with a checkout path in it.Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari