Skip to content

[Home Page] Remove Validate account nudge and Discover section - #101880

Merged
mountiny merged 4 commits into
Expensify:mainfrom
software-mansion-labs:@adamgrzybowski/remove-validation-todo-and-discover-home
Sep 24, 2026
Merged

mountiny merged 4 commits into
Expensify:mainfrom
software-mansion-labs:@adamgrzybowski/remove-validation-todo-and-discover-home

Conversation

@adamgrzybowski

@adamgrzybowski adamgrzybowski commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

  • Removes the "Validate account" nudge from the home Time Sensitive section, so users are no longer prompted there to validate their account.
  • Removes the Discover section (test drive card and "See what Expensify can do" menu item) from the home page on both narrow and wide layouts.
  • Cleans up the associated translations, styles, asset, sentry label, and tests, and renumbers the Time Sensitive priority list accordingly.

Fixed Issues

$ #101737
PROPOSAL:

Tests

  • Verify that no errors appear in the JS console

Offline tests

QA Steps

  1. Open the home page and confirm the Discover section (test drive card / "See what Expensify can do in 2 min") is no longer shown, on both narrow and wide layouts.
  2. With an unvalidated account, open the home page and confirm the Time Sensitive section no longer shows a "Validate your account" row.
  3. Confirm the remaining Time Sensitive rows still appear in the correct order and no errors appear in the JS console.
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-09-22.at.15.55.17.mov

@melvin-bot

melvin-bot Bot commented Sep 22, 2026

Copy link
Copy Markdown

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

  1. Look at the code and make sure there are no malicious changes.
  2. Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx bun ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx bun ./scripts/generateTranslations.ts --compare-ref main

@codecov

codecov Bot commented Sep 22, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
src/CONST/index.ts 94.06% <ø> (ø)
src/pages/home/HomePage.tsx 100.00% <ø> (ø)
...ome/TimeSensitiveSection/useTimeSensitiveItems.tsx 68.96% <ø> (-5.28%) ⬇️
src/styles/index.ts 63.28% <ø> (ø)
... and 9 files with indirect coverage changes

@adamgrzybowski
adamgrzybowski marked this pull request as ready for review September 22, 2026 14:01
@adamgrzybowski
adamgrzybowski requested review from a team as code owners September 22, 2026 14:01
@melvin-bot
melvin-bot Bot requested review from JmillsExpensify and ZhenjaHorbach and removed request for a team September 22, 2026 14:01
@melvin-bot

melvin-bot Bot commented Sep 22, 2026

Copy link
Copy Markdown

@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@JmillsExpensify JmillsExpensify left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shawnborton

Copy link
Copy Markdown
Contributor

Video looks good to me too 👍

@JmillsExpensify

Copy link
Copy Markdown
Contributor

@grgia would appreciate you reviewing this PR for internal so that we can keep it moving.

@ZhenjaHorbach

ZhenjaHorbach commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Screen.Recording.2026-09-22.at.21.18.08.mov
Android: mWeb Chrome
Screen.Recording.2026-09-22.at.21.18.08.mov
iOS: HybridApp
Screen.Recording.2026-09-22.at.21.18.08.mov
iOS: mWeb Safari
Screen.Recording.2026-09-22.at.21.16.25.mov
MacOS: Chrome / Safari
Screen.Recording.2026-09-22.at.21.12.08.mov

grgia
grgia previously approved these changes Sep 22, 2026

@grgia grgia left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NAB

@melvin-bot
melvin-bot Bot requested a review from grgia September 22, 2026 19:19
@JmillsExpensify

Copy link
Copy Markdown
Contributor

Let's get this one merged tomorrow!

@adamgrzybowski

Copy link
Copy Markdown
Contributor Author

@MelvinBot resolve conflicts

@MelvinBot

Copy link
Copy Markdown
Contributor

⚠️ I can't push changes to this PR because I didn't open it and I'm not listed as an assignee. To have me make this fix, add me to the PR assignees and then retry your request.

In the meantime I resolved the conflict locally and verified it, so you can apply it in about a minute.

The conflict

Exactly one file conflicts: src/pages/home/TimeSensitiveSection/useTimeSensitiveItems.tsx — and only in the import block. Everything else (CONST, all 12 language files, HomePage.tsx, styles/index.ts) auto-merges.

Both sides deleted different import lines that sit next to each other, which is why git can't pick a winner:

  • Your branch dropped the validation imports (expensifyLoginsSelector, isCurrentUserValidated, isUserValidatedSelector, emailSelector, useIsAnonymousUser).
  • main moved the pending-digital-wallet-approval logic into the new useRefreshPendingDigitalWalletApproval hook, which dropped getExpensifyCardPendingWalletApproval and useFocusEffect.

So the correct resolution keeps neither side's conflicted lines — all four imports are now unused. The merged body already picked up useRefreshPendingDigitalWalletApproval() correctly.

Resolution

Replace the whole conflicted region (lines 6-19 after git merge main) so the top of the file reads:

import useCardFeedErrors from '@hooks/useCardFeedErrors';
import useCurrentUserPersonalDetails from '@hooks/useCurrentUserPersonalDetails';
import useOnyx from '@hooks/useOnyx';
import useRefreshPendingDigitalWalletApproval from '@hooks/useRefreshPendingDigitalWalletApproval';

import CONST from '@src/CONST';
import ONYXKEYS from '@src/ONYXKEYS';

import {createTimeSensitiveAdminPoliciesSelector} from '@selectors/Policy';
import React from 'react';
git checkout @adamgrzybowski/remove-validation-todo-and-discover-home
git merge origin/main
# apply the import block above
git add src/pages/home/TimeSensitiveSection/useTimeSensitiveItems.tsx
git commit
git push

Verification

  • npm run typecheck passes on the merged tree (all 5 projects).
  • No dangling references to the files you deleted (DiscoverSection.tsx, items/ValidateAccount.tsx) anywhere in src/ or tests/; main never touched them, so there's no modify/delete conflict.
  • ESLint on the merged file reports one rulesdir/no-inline-useOnyx-selector error at the createTimeSensitiveAdminPoliciesSelector call. I confirmed it's pre-existing on main (byte-identical line, same error when linting origin/main's copy), so it isn't introduced by the merge.

I couldn't verify the Home page in a browser on this run — the web environment failed to come up — so the check above is static only.

Details
  • Merge base: b2d8942
  • main at time of check: 19470ec
  • PR head: 93dc208
  • git merge-tree reports a single CONFLICT (content) and no delete/rename conflicts.

…ve-validation-todo-and-discover-home

# Conflicts:
#	src/pages/home/TimeSensitiveSection/useTimeSensitiveItems.tsx
@adamgrzybowski

Copy link
Copy Markdown
Contributor Author

conflicts fixed

…ve-validation-todo-and-discover-home

# Conflicts:
#	Mobile-Expensify
#	src/pages/home/TimeSensitiveSection/useTimeSensitiveItems.tsx
@adamgrzybowski
adamgrzybowski force-pushed the @adamgrzybowski/remove-validation-todo-and-discover-home branch from a2360a2 to f843999 Compare September 24, 2026 12:02
@JmillsExpensify

Copy link
Copy Markdown
Contributor

All yours @grgia

@mountiny mountiny left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @grgia already approved so I can just merge

@mountiny
mountiny merged commit bfa20a3 into Expensify:main Sep 24, 2026
35 of 36 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/mountiny in version: 9.4.94-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

MelvinBot commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

Yes, one help article needed changes. I opened a draft PR: Docs updates for E/A#101880 Remove Discover section from Home overview article. It has the HelpDot label and is assigned to adamgrzybowski.

What changed in Expensify-Home-Overview.md:

  • Removed Discover from the metadata and from the list of Home sections
  • Removed the How the Discover section works on Home section
  • Removed the Why don’t I see the Discover section? FAQ
Why no other changes
  • No help article lists a "Validate your account" row under Time sensitive. Articles that mention Validate your account describe the bank account flow, which this PR didn't change.
  • No other article mentions the Discover section, the test drive card, or "See what Expensify can do in 2 min".
  • On the current web build, Home no longer shows Discover, the test drive card, or the 2-minute demo item.

@adamgrzybowski, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR Ready for review


view run · view recording

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/Julesssss in version: 9.4.94-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants