Repository navigation
[Home Page] Remove Validate account nudge and Discover section - #101880
Conversation
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx bun ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
|
@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
Video looks good to me too 👍 |
|
@grgia would appreciate you reviewing this PR for internal so that we can keep it moving. |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-09-22.at.21.18.08.movAndroid: mWeb ChromeScreen.Recording.2026-09-22.at.21.18.08.moviOS: HybridAppScreen.Recording.2026-09-22.at.21.18.08.moviOS: mWeb SafariScreen.Recording.2026-09-22.at.21.16.25.movMacOS: Chrome / SafariScreen.Recording.2026-09-22.at.21.12.08.mov |
|
Let's get this one merged tomorrow! |
|
@MelvinBot resolve conflicts |
|
In the meantime I resolved the conflict locally and verified it, so you can apply it in about a minute. The conflictExactly one file conflicts: Both sides deleted different import lines that sit next to each other, which is why git can't pick a winner:
So the correct resolution keeps neither side's conflicted lines — all four imports are now unused. The merged body already picked up ResolutionReplace the whole conflicted region (lines 6-19 after import useCardFeedErrors from '@hooks/useCardFeedErrors';
import useCurrentUserPersonalDetails from '@hooks/useCurrentUserPersonalDetails';
import useOnyx from '@hooks/useOnyx';
import useRefreshPendingDigitalWalletApproval from '@hooks/useRefreshPendingDigitalWalletApproval';
import CONST from '@src/CONST';
import ONYXKEYS from '@src/ONYXKEYS';
import {createTimeSensitiveAdminPoliciesSelector} from '@selectors/Policy';
import React from 'react';git checkout @adamgrzybowski/remove-validation-todo-and-discover-home
git merge origin/main
# apply the import block above
git add src/pages/home/TimeSensitiveSection/useTimeSensitiveItems.tsx
git commit
git pushVerification
I couldn't verify the Home page in a browser on this run — the web environment failed to come up — so the check above is static only. Details
|
…ve-validation-todo-and-discover-home # Conflicts: # src/pages/home/TimeSensitiveSection/useTimeSensitiveItems.tsx
|
conflicts fixed |
…ve-validation-todo-and-discover-home # Conflicts: # Mobile-Expensify # src/pages/home/TimeSensitiveSection/useTimeSensitiveItems.tsx
a2360a2 to
f843999
Compare
|
All yours @grgia |
|
🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.4.94-0 🚀
|
|
Yes, one help article needed changes. I opened a draft PR: Docs updates for E/A#101880 Remove Discover section from Home overview article. It has the What changed in
Why no other changes
@adamgrzybowski, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR |
|
🚀 Deployed to production by https://github.com/Julesssss in version: 9.4.94-0 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Fixed Issues
$ #101737
PROPOSAL:
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-09-22.at.15.55.17.mov