Skip to content

[No QA] Consolidated help docs: new-expensify/expensify-card - #101949

Merged
VictoriaExpensify merged 8 commits into
mainfrom
helpsite-consolidated-new-expensify-expensify-card
Sep 25, 2026
Merged

VictoriaExpensify merged 8 commits into
mainfrom
helpsite-consolidated-new-expensify-expensify-card

Conversation

@stephanieelliott

Copy link
Copy Markdown
Contributor

Summary

Consolidates 3 help doc PRs for new-expensify/expensify-card into a single reviewable PR.

Included PRs

Test plan

  • Review combined doc changes for accuracy and conflicts
  • Verify no duplicate or contradictory guidance within the folder
  • No QA

@melvin-bot

melvin-bot Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

Concierge reviewer checklist:

  • I have verified the accuracy of the article
    • The article is within a hub that makes sense, and the navigation is correct
    • All processes, screenshots, and examples align with current product behavior.
    • All links within the doc have been verified for correct destination and functionality.
  • I have verified the readability of the article
    • The article's language is clear, concise, and free of jargon.
    • The grammar, spelling, and punctuation are correct.
    • The article contains at least one image, or that an image is not necessary
  • I have verified the formatting of the article
    • The article has consistent formatting (headings, bullet points, etc.) with other HelpDot articles and that aligns with the HelpDot formatting standards.
    • The article has proper text spacing and breaks for readability.
  • I have verified the article has the appropriate tone and style
    • The article's tone is professional, friendly, and suitable for the target audience.
    • The article's tone, terminology, and voice are consistent throughout.
  • I have verified the overall quality of the article
    • The article is not missing any information, nor does it contain redundant information.
    • The article fully addresses user needs.
  • I have verified that all requested improvements have been addressed

For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member?

cc @bfitzexpensify

@melvin-bot
melvin-bot Bot requested review from MonilBhavsar and bfitzexpensify and removed request for a team September 23, 2026 01:44
@melvin-bot

melvin-bot Bot commented Sep 23, 2026

Copy link
Copy Markdown

@MonilBhavsar @bfitzexpensify One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@github-actions

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment
This PR makes targeted UI-accuracy updates across four Expensify Card help articles: it simplifies Spend rules navigation (removing the now-defunct Card restrictions tab), removes an outdated settlement-frequency section, updates export/download instructions to match the current bottom action bar, and adds a section clarifying what the Inactive card status means in Wallet. The changes are corrective and well-scoped, aligning the docs with the live UI.

Scores Summary

  • Readability: 9/10 - Clear, scannable sentences; the new Inactive-status section uses a clean status list and concisely explains the not-a-broken-connection nuance. Numbered steps flow logically.
  • AI Readiness: 8/10 - New heading is question-based and includes the feature name; keywords expanded with realistic search phrases (card status, fix this connection). Legacy frontmatter still lacks the internalScope field, but this PR does not modify frontmatter beyond keywords, so it is only a minor gap.
  • Style Compliance: 9/10 - UI labels are bold, sentence case, and match the current UI (Export, More, Download statement, Account > Wallet). Navigation uses the approved unified web/mobile phrasing. Removing the Selected button and Card restrictions tab correctly eliminates references to UI that no longer exists.

Key Findings

  • Strong adherence to Core UI Referencing Rules: outdated exact labels were replaced with current ones rather than paraphrased.
  • New Inactive-status section is a helpful, deflection-oriented addition with a correct descriptive cross-link (relative link, task-based anchor text) to the personal cards article.
  • The click-More-first fallback guidance is a nice touch for overflow/responsive UI states.
  • Minor: the four articles carry legacy frontmatter without an internalScope field (Section 3 of the authoring guidelines). Not introduced by this PR, but worth backfilling.
  • Minor: In Spend-Rules, 'search field' replaced the exact 'Find rule' field label - verify the field is truly unlabeled; if it still shows a label, use the exact UI text.

Recommendations

  • Confirm the Rules search field is genuinely unlabeled before generalizing 'Find rule' field to 'search field'; use the exact label if one exists.
  • Consider backfilling internalScope frontmatter on these articles in a follow-up.
  • No blocking issues - changes are accurate and safe to merge.

Files Reviewed

  • Expensify-Card-Spend-Rules.md - Navigation simplified; verify search-field label.
  • Set-Up-and-Manage-the-Expensify-Card-US.md - Outdated settlement-frequency section removed; clean.
  • Troubleshoot-Expensify-Card-issues.md - New Inactive-status section and expanded keywords; compliant and helpful.
  • View-and-Reconcile-Expensify-Card-Expenses.md - Export/download steps updated to current action bar; compliant.

Note: This review reflects only the proposed diff, not unchanged content.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 09ea399c97

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread Web-Expensify Resolved
@MonilBhavsar

MonilBhavsar commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Android: mWeb Chrome
iOS: HybridApp
iOS: mWeb Safari
MacOS: Chrome / Safari

MonilBhavsar
MonilBhavsar previously approved these changes Sep 23, 2026
@stephanieelliott
stephanieelliott requested review from a team as code owners September 25, 2026 01:37
@melvin-bot
melvin-bot Bot requested review from JmillsExpensify and removed request for a team September 25, 2026 01:37
@OSBotify

This comment has been minimized.

@stephanieelliott
stephanieelliott marked this pull request as draft September 25, 2026 01:41
@stephanieelliott
stephanieelliott marked this pull request as ready for review September 25, 2026 01:41
@OSBotify

This comment has been minimized.

@github-actions

github-actions Bot commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment
This PR consolidates and refreshes four Expensify Card articles, mostly updating UI references to match the current product (bottom action bar, Add rule flow, Wallet card statuses) and swapping a screenshot placeholder for a real image. The changes are generally accurate improvements that better reflect the live UI, with one new well-formed troubleshooting section. A few small formatting and precision issues remain.

Scores Summary

  • Readability: 8/10 - Clear, concise, and action-oriented. Main deduction is a duplicated step number in the Spend Rules create flow that breaks sequential numbering.
  • AI Readiness: 8/10 - New heading is task-based (What the Inactive status...), keywords were expanded, and full feature names are used. No frontmatter regressions introduced.
  • Style Compliance: 8/10 - Strong UI-exact terminology (Export, More, Download statement, Wallet, Active/Inactive). Minor slips around a vague icon reference and a generalized navigation path.

Key Findings

  • Positive: UI references in View-and-Reconcile now correctly describe the bottom action bar and the Export / Download statement / More controls, replacing the outdated Selected button. This is a solid accuracy win.
  • Positive: The new 'What the Inactive status on your Expensify Card in Wallet means' section is task-based, uses correct split navigation phrasing, bolds statuses per convention, and cross-links appropriately to the personal card connection article.
  • Positive: Replacing the SCREENSHOT HTML comment with a rendered image improves the Spend Rules create flow.
  • Issue (Spend Rules): The create-rule steps have two steps numbered 6 (Configure one or more... and Select Save rule), breaking sequential numbering (violates the Step Formatting Standard).
  • Issue (Spend Rules): 'Select the trash can icon' is a slightly vague UI reference; if the control has a label or tooltip, prefer the exact label per Core UI Referencing Rules. There is also trailing whitespace after 'following rules'.
  • Note (Spend Rules): Navigation paths were generalized (e.g. removing the Card restrictions tab). This is fine if those tabs no longer exist, but confirm the removed tab/section references genuinely no longer match the UI rather than losing useful precision.
  • Note (Set-Up-and-Manage): The 'How to change your Expensify Card settlement frequency' section was removed entirely. Confirm this content lives in another article so the workflow is not orphaned; if consolidated elsewhere, a cross-link would help retrieval.

Recommendations

  • Fix the duplicate 6 numbering in the Spend Rules create-rule steps (renumber to 6 and 7).
  • Replace 'Select the trash can icon' with the exact UI label if one exists; remove trailing whitespace after 'following rules'.
  • Verify the removed settlement-frequency workflow is covered elsewhere and consider cross-linking to it.

Files Reviewed

  • docs/articles/new-expensify/expensify-card/Expensify-Card-Spend-Rules.md - Good updates; fix duplicate step number and icon reference.
  • docs/articles/new-expensify/expensify-card/Set-Up-and-Manage-the-Expensify-Card-US.md - Section removed; confirm coverage elsewhere.
  • docs/articles/new-expensify/expensify-card/Troubleshoot-Expensify-Card-issues.md - New section and keywords are well-formed and compliant.
  • docs/articles/new-expensify/expensify-card/View-and-Reconcile-Expensify-Card-Expenses.md - Accurate UI reference improvements.

Note: Detailed line-by-line feedback has been provided as inline comments.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 693b4dc41c

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@stephanieelliott stephanieelliott added the HelpDot Apply this label if the issue relates to ExpensifyHelp label Sep 25, 2026
@VictoriaExpensify
VictoriaExpensify merged commit 354727f into main Sep 25, 2026
13 of 14 checks passed
@VictoriaExpensify
VictoriaExpensify deleted the helpsite-consolidated-new-expensify-expensify-card branch September 25, 2026 02:25
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/VictoriaExpensify in version: 9.4.94-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/Julesssss in version: 9.4.94-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants