Repository navigation
[Payment due @shubham1206agra] Restore last-four SSN for USD beneficial owners - #102019
Conversation
|
@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c8f1a2fd58
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| LEGAL_NAME: 'legal-name', | ||
| DATE_OF_BIRTH: 'date-of-birth', | ||
| SSN: 'ssn', | ||
| SSN_LAST_4: 'ssnLast4', |
There was a problem hiding this comment.
Preserve the existing SSN subpage route
For an open or bookmarked USD setup URL whose subpage is ssn, changing the route value to ssnLast4 makes it unknown to useSubPage; findPageIndex() then falls back to index 0, displaying the legal-name screen rather than the SSN screen. Keep the established 'ssn' route value independently of changing the form-data field to ssnLast4 so in-progress navigation survives deployment.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Fixed in 0520ed4 - retained the existing ssn subpage route while keeping the data field named ssnLast4.
-- AI Maxence
Addresses review comment: #102019 (comment)
Addresses review comment: #102019 (comment)
Addresses review comment: #102019 (comment)
🦜 Polyglot Parrot! 🦜Squawk! Looks like you added some shiny new English strings. Allow me to parrot them back to you in other tongues: View the translation diffdiff --git a/src/languages/de.ts b/src/languages/de.ts
index fddce43e..5a6edc57 100644
--- a/src/languages/de.ts
+++ b/src/languages/de.ts
@@ -4282,7 +4282,7 @@ ${amount} für ${merchant} – ${date}`,
legalFirstName: 'Rechtlicher Vorname',
legalLastName: 'Rechtlicher Nachname',
enterTheDateOfBirthOfTheOwner: 'Wie lautet das Geburtsdatum des Eigentümers?',
- enterTheSSN: 'Wie lauten die letzten 4 Ziffern der Sozialversicherungsnummer des Inhabers?',
+ enterTheSSN: 'Wie lauten die letzten 4 Ziffern der Sozialversicherungsnummer der Inhaberin oder des Inhabers?',
dontWorry: 'Keine Sorge, wir führen keine persönlichen Bonitätsprüfungen durch!',
enterTheOwnersAddress: 'Wie lautet die Adresse des Eigentümers?',
letsDoubleCheck: 'Lass uns noch einmal überprüfen, ob alles richtig aussieht.',
diff --git a/src/languages/el.ts b/src/languages/el.ts
index eece61c9..12da94a1 100644
--- a/src/languages/el.ts
+++ b/src/languages/el.ts
@@ -4339,7 +4339,7 @@ ${amount} για ${merchant} - ${date}`,
legalFirstName: 'Επίσημο μικρό όνομα',
legalLastName: 'Επώνυμο (όπως αναγράφεται στα επίσημα έγγραφα)',
enterTheDateOfBirthOfTheOwner: 'Ποια είναι η ημερομηνία γέννησης του κατόχου;',
- enterTheSSN: 'Ποια είναι τα τελευταία 4 ψηφία του Αριθμού Κοινωνικής Ασφάλισης του ιδιοκτήτη;',
+ enterTheSSN: 'Ποια είναι τα τελευταία 4 ψηφία του αριθμού κοινωνικής ασφάλισης του κατόχου;',
dontWorry: 'Μην ανησυχείτε, δεν κάνουμε κανέναν προσωπικό έλεγχο πιστοληπτικής ικανότητας!',
enterTheOwnersAddress: 'Ποια είναι η διεύθυνση του ιδιοκτήτη;',
letsDoubleCheck: 'Ας ελέγξουμε διπλά ότι όλα φαίνονται σωστά.',
diff --git a/src/languages/es.ts b/src/languages/es.ts
index f0220880..0f9497db 100644
--- a/src/languages/es.ts
+++ b/src/languages/es.ts
@@ -4206,7 +4206,7 @@ ${amount} para ${merchant} - ${date}`,
legalFirstName: 'Nombre legal',
legalLastName: 'Apellidos legales',
enterTheDateOfBirthOfTheOwner: '¿Cuál es la fecha de nacimiento del dueño?',
- enterTheSSN: '¿Cuáles son los últimos 4 dígitos del número de la Seguridad Social del propietario?',
+ enterTheSSN: '¿Cuáles son los últimos 4 dígitos del número de Seguro Social del propietario?',
dontWorry: 'No te preocupes, ¡no realizamos verificaciones de crédito personales!',
enterTheOwnersAddress: '¿Cuál es la dirección del dueño?',
letsDoubleCheck: 'Vamos a verificar que todo esté correcto.',
diff --git a/src/languages/fr.ts b/src/languages/fr.ts
index 0a0eba04..d3a04a9c 100644
--- a/src/languages/fr.ts
+++ b/src/languages/fr.ts
@@ -4291,7 +4291,7 @@ ${amount} pour ${merchant} - ${date}`,
legalFirstName: 'Prénom légal',
legalLastName: 'Nom de famille légal',
enterTheDateOfBirthOfTheOwner: 'Quelle est la date de naissance du responsable ?',
- enterTheSSN: 'Quels sont les 4 derniers chiffres du numéro de sécurité sociale du propriétaire ?',
+ enterTheSSN: 'Quels sont les 4 derniers chiffres du numéro de Sécurité sociale du responsable ?',
dontWorry: 'Ne vous inquiétez pas, nous ne faisons aucun contrôle de crédit personnel !',
enterTheOwnersAddress: 'Quelle est l’adresse du responsable ?',
letsDoubleCheck: 'Vérifions une dernière fois que tout est correct.',
diff --git a/src/languages/it.ts b/src/languages/it.ts
index 008d3a36..6c3b45c7 100644
--- a/src/languages/it.ts
+++ b/src/languages/it.ts
@@ -4262,7 +4262,7 @@ ${amount} per ${merchant} - ${date}`,
legalFirstName: 'Nome legale di battesimo',
legalLastName: 'Cognome legale',
enterTheDateOfBirthOfTheOwner: 'Qual è la data di nascita del titolare?',
- enterTheSSN: 'Quali sono le ultime 4 cifre del codice di previdenza sociale del titolare?',
+ enterTheSSN: 'Quali sono le ultime 4 cifre del numero di previdenza sociale del titolare?',
dontWorry: 'Non preoccuparti, non effettuiamo alcun controllo del credito personale!',
enterTheOwnersAddress: "Qual è l'indirizzo del proprietario?",
letsDoubleCheck: 'Controlliamo che sia tutto a posto.',
diff --git a/src/languages/ja.ts b/src/languages/ja.ts
index af17267e..0635336a 100644
--- a/src/languages/ja.ts
+++ b/src/languages/ja.ts
@@ -4230,7 +4230,7 @@ ${integrationName === CONST.ONBOARDING_ACCOUNTING_MAPPING.other ? 'あなたの'
legalFirstName: '法的な名',
legalLastName: '法的な姓',
enterTheDateOfBirthOfTheOwner: '所有者の生年月日はいつですか?',
- enterTheSSN: '所有者の社会保障番号の下4桁は何ですか?',
+ enterTheSSN: '所有者の社会保障番号の下4桁を入力してください。',
dontWorry: 'ご安心ください。個人信用情報の審査は一切行いません。',
enterTheOwnersAddress: 'オーナーの住所は何ですか?',
letsDoubleCheck: 'すべて正しく表示されているか、もう一度確認しましょう。',
diff --git a/src/languages/nl.ts b/src/languages/nl.ts
index c80aa341..4325be43 100644
--- a/src/languages/nl.ts
+++ b/src/languages/nl.ts
@@ -4263,7 +4263,7 @@ ${amount} voor ${merchant} - ${date}`,
legalFirstName: 'Juridische voornaam',
legalLastName: 'Wettelijke achternaam',
enterTheDateOfBirthOfTheOwner: 'Wat is de geboortedatum van de eigenaar?',
- enterTheSSN: 'Wat zijn de laatste 4 cijfers van het Amerikaanse Social Security Number (SSN) van de eigenaar?',
+ enterTheSSN: 'Wat zijn de laatste 4 cijfers van het burgerservicenummer (BSN) van de eigenaar?',
dontWorry: 'Geen zorgen, we voeren geen persoonlijke kredietcontroles uit!',
enterTheOwnersAddress: 'Wat is het adres van de eigenaar?',
letsDoubleCheck: 'Laten we voor de zekerheid controleren of alles er goed uitziet.',
diff --git a/src/languages/pt-BR.ts b/src/languages/pt-BR.ts
index 21c14be0..6805a566 100644
--- a/src/languages/pt-BR.ts
+++ b/src/languages/pt-BR.ts
@@ -4251,7 +4251,7 @@ ${amount} para ${merchant} - ${date}`,
legalFirstName: 'Primeiro nome legal',
legalLastName: 'Sobrenome legal',
enterTheDateOfBirthOfTheOwner: 'Qual é a data de nascimento do proprietário?',
- enterTheSSN: 'Quais são os últimos 4 dígitos do número de Social Security do proprietário?',
+ enterTheSSN: 'Quais são os últimos 4 dígitos do Número de Seguridade Social do proprietário?',
dontWorry: 'Não se preocupe, não fazemos nenhuma análise de crédito pessoal!',
enterTheOwnersAddress: 'Qual é o endereço do proprietário?',
letsDoubleCheck: 'Vamos conferir se está tudo certo.',
diff --git a/src/languages/zh-hans.ts b/src/languages/zh-hans.ts
index 99175651..02f3f78d 100644
--- a/src/languages/zh-hans.ts
+++ b/src/languages/zh-hans.ts
@@ -4133,7 +4133,7 @@ ${amount},商户:${merchant} - 日期:${date}`,
legalFirstName: '法定名(名)',
legalLastName: '法定姓氏',
enterTheDateOfBirthOfTheOwner: '所有者的出生日期是什么?',
- enterTheSSN: '所有者的社会安全号码后4位数字是多少?',
+ enterTheSSN: '所有者社会安全号码的后四位是多少?',
dontWorry: '别担心,我们不会进行任何个人信用检查!',
enterTheOwnersAddress: '所有者的地址是什么?',
letsDoubleCheck: '让我们再仔细检查一下,确保一切都正确。',
Note You can apply these changes to your branch by copying the patch to your clipboard, then running |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
Reviewer Checklist
Screenshots/VideosScreen.Recording.2026-09-24.at.1.47.34.PM.mov |
|
@aldo-expensify Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
🎯 @shubham1206agra, thanks for reviewing and testing this PR! 🎉 A payment issue will be created for your review once this PR is deployed to production. If payment is not needed (e.g., regression PR review fix etc), react with 👎 to this comment to prevent the payment issue from being created. |
|
🚧 aldo-expensify has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/aldo-expensify in version: 9.4.94-0 🚀
|
|
Yes, one help article needed an update. I opened a draft PR: Docs updates for E/A#102019 USD beneficial owners enter last four SSN digits. What changed: Connect-a-Business-Bank-Account.md said USD beneficial owners must enter the Full 9 digits of SSN. It now says they enter the last four digits in the Last 4 of SSN field. Details
@madmax330, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR |
|
@madmax330 Can you please clarify few steps?
|
|
@izarutskaya I think the QA/Testing steps are until step 6 (including), the rest shouldn't be there. |
|
@madmax330 @aldo-expensify It's passed in Web. But we can't capture the 1790521939946.bandicam_2026-09-27_18-06-30-741.mp4WhatsApp.Video.2026-09-27.at.21.47.44.mp4 |
|
@izarutskaya yeah it looks like it's a pass, thanks |
|
🚀 Deployed to production by https://github.com/Julesssss in version: 9.4.94-0 🚀
Bundle Size Analysis (Sentry): |
|
🤖 Payment issue created: #102454 |
Explanation of Change
Restores the
ssnLast4contract for beneficial owners in the USD verified bank account flow. The full-SSN contract for US-national beneficial owners in the Non-USD/Corpay flow is unchanged.Fixed Issues
$ https://github.com/Expensify/Expensify/issues/681996
PROPOSAL:
Tests
Last 4 of SSN.UpdateBeneficialOwnersForBankAccountsendsssnLast4, notssn.npm run lint-changed,npm run spell-changed, andnpm run react-compiler-compliance-check check-changedsuccessfully.npm test -- --runTestsByPath tests/unit/ReimbursementAccountBeneficialOwnerSSNTest.ts --silentcould not execute because the local installation is missing declared dependency@legendapp/list/react-native.npm run typecheckhas unrelated pre-existing chart, LegendList dependency, and Expensify Card errors; it reports no errors in changed files.Offline tests
ssnLast4.QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionScreenshots/Videos
Not applicable. This restores the previous USD beneficial-owner SSN UI.