Skip to content

[No QA] Add NetSuite bundle release history to the help site - #102112

Merged
sakluger merged 2 commits into
mainfrom
yuwen/netsuite-bundle-release-history
Sep 24, 2026
Merged

sakluger merged 2 commits into
mainfrom
yuwen/netsuite-bundle-release-history

Conversation

@yuwenmemon

@yuwenmemon yuwenmemon commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

Customers need a version-by-version record of what the NetSuite bundle changes before upgrading. Bundle publication is separate from enabling Expensify's REST import functionality; these notes do not announce a completed OAuth migration or SuiteTax rollout.

Historical entries come from the existing integration README and the release author's confirmation of 1.11. That version changed the Expensify integration record, not the Expensify Integration role. This article can merge independently of the upgrade guide in #102101.

Fixed Issues

For https://github.com/Expensify/Expensify/issues/662135
PROPOSAL: N/A (internal documentation change)

Tests

  1. Run npm run createDocsRoutes and confirm the release notes appear under the NetSuite hub.
  2. Run npm run lint-changed and npm run spell-changed and confirm both pass.
  3. In docs, run bundle exec jekyll build and confirm the help site builds successfully.
  4. Serve the help site locally and open /articles/new-expensify/connections/netsuite/View-Expensify-Connect-Bundle-Release-Notes.
  5. Confirm the version headings, dates, permission changes, compatibility notes, and version 1.11 integration-record change render correctly.
  6. Open the NetSuite hub and confirm its release-notes link opens the article.
  • Verify that no errors appear in the JS console

Offline tests

N/A — static help content; no application or offline behavior changes.

QA Steps

No QA

  • Verify that no errors appear in the JS console (N/A — no application changes)

PR Author Checklist

Unchecked application/platform items are not applicable to this documentation-only change.

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

N/A — documentation-only change.

Android: mWeb Chrome

N/A — documentation-only change.

iOS: Native

N/A — documentation-only change.

iOS: mWeb Safari

N/A — documentation-only change.

MacOS: Chrome / Safari

N/A — documentation-only change.

@yuwenmemon yuwenmemon added the HelpDot Apply this label if the issue relates to ExpensifyHelp label Sep 24, 2026
@yuwenmemon
yuwenmemon requested a review from sakluger September 24, 2026 00:41
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-24T00:52:25.583713Z 438c077 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR adds one new article, View-Expensify-Connect-Bundle-Release-Notes.md, under the NetSuite connections hub. It documents the version-by-version release history of the Expensify Connect NetSuite bundle (ID 283395), including added/changed/removed permissions, compatibility notes, and pre-upgrade precautions. The content is well-structured, single-workflow focused, and clearly distinguishes bundle publication from Expensify feature enablement. It is a strong, governance-aligned addition.

Scores Summary

  • Readability: 9/10 - Clear, scannable prose with consistent per-version structure (Released / Added / Changed / Removed / Compatibility). Bold labels aid scanning. Sentences are precise and actionable. Minor: a few compatibility sentences are dense.
  • AI Readiness: 9/10 - Complete YAML frontmatter including a thorough internalScope with explicit audience, coverage, and exclusions. All headings are task/question-based ("What changed in...", "How to read...", "What is documented for..."), full feature name used throughout, and heading hierarchy correctly limited to # and ## with a single H1. Realistic keywords included.
  • Style Compliance: 9/10 - Exact NetSuite component, role, and permission names are bolded consistently (e.g., Expensify Integration role, REST Web Services (Full)). No prohibited vague navigation phrases. Terminology such as Workspace Admin used correctly. No Expensify UI buttons/tabs are misreferenced (this article concerns third-party NetSuite UI).

Key Findings

  • Metadata is exemplary: internalScope explicitly states audience (Workspace Admins and NetSuite administrators), what is covered (production bundle release history), and what is excluded (installation steps, OAuth setup, NetSuite platform releases, SuiteApp Marketplace releases).
  • Every ## heading begins with an approved question/action word and includes the full feature name, satisfying the task-based heading rules and the "at least one How to" requirement.
  • Heading hierarchy is compliant: exactly one # title, only ## for sections, no ### or deeper.
  • The version 1.11 documentation gap is handled honestly with its own explicit section rather than being silently omitted or inferred - a good retrieval and trust practice.
  • No cross-links are used; given the self-contained scope this is acceptable, though a single relative link to a bundle installation/upgrade guide (an explicitly excluded workflow) would align with the Cross-Linking Standards once that article merges.

Recommendations

  • Optional: once the related upgrade guide (referenced PR [No QA] Add a NetSuite bundle upgrade help guide #102101) merges, add a single descriptive relative cross-link for the excluded installation/upgrade workflow, per the Cross-Linking Standards.
  • Optional: consider tightening one or two of the denser Compatibility sentences for readability, but this is not required.
  • No blocking issues found.

Files Reviewed

  • docs/articles/new-expensify/connections/netsuite/View-Expensify-Connect-Bundle-Release-Notes.md - New article. Compliant with authoring, naming, and template governance. Strong metadata and heading discipline.

Note: Detailed line-by-line feedback has been provided as inline comments.

@OSBotify

This comment has been minimized.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 438c0777e2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@OSBotify

Copy link
Copy Markdown
Contributor

A preview of your ExpensifyHelp changes have been deployed to https://c939652b.helpdot.pages.dev ⚡️

Updated articles:

@sakluger
sakluger merged commit 69e508c into main Sep 24, 2026
17 of 19 checks passed
@sakluger
sakluger deleted the yuwen/netsuite-bundle-release-history branch September 24, 2026 18:25
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/sakluger in version: 9.4.94-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/Julesssss in version: 9.4.94-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants