Repository navigation
[No QA] Update XERO45 help article - #102185
Conversation
HelpDot Documentation ReviewOverall AssessmentThis PR updates the XERO45 sync error articles for both Expensify Classic and New Expensify. The core content change is excellent: it corrects a genuinely harmful instruction (disconnect + reconnect, which wipes imported data and settings) and replaces it with a safe reconnect-only flow. The new error message, the XERO46 distinction, and the ND note about hidden settings are all accurate and well explained. The prose is clear and the FAQ was meaningfully expanded. The main gaps are structural/style: heading hierarchy violations and the three dots menu convention. Scores Summary
Key Findings
Recommendations
Files Reviewed
Note: Detailed line-by-line feedback has been provided as inline comments. |
|
🚀 Deployed to staging by https://github.com/yuwenmemon in version: 9.4.94-0 🚀
|
|
🚀 Deployed to production by https://github.com/Julesssss in version: 9.4.94-0 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
The XERO45 article told people to disconnect Xero and then reconnect. Disconnecting wipes your imported data and all your Xero settings, so anyone following the article lost their setup and had to build it again.
In reality, you don't actually need to disconnect to fix the error, so both articles have been updated to say that.
A few other things needed updating to match:
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/679831
PROPOSAL: N/A
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari