Repository navigation
Conversation
|
🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
JmillsExpensify
left a comment
There was a problem hiding this comment.
Change summary and testing steps look good to me. Product approved.
# Conflicts: # src/libs/actions/IOU/Receipt.ts
Reviewer Checklist
Screenshots/Videos |
|
^^ @mountiny kind bump here |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.5.0-0 🚀
|
|
No help site update is needed. This PR is a bug fix: receipts added offline now upload correctly after an iOS app upgrade, which is what users already expect, and no article wording or UI changed. |
|
@VickyStash which builds should the Applause team install? |
|
@VickyStash, the links you shared lead to identical builds. Is that correct?
|
Oh, okay, then. I'm not sure it will be possible to test the exact steps on staging. I think we can at least test whether adding a receipt/replacing a receipt in the existing expense works then. |
|
🚀 Deployed to production by https://github.com/Julesssss in version: 9.5.0-5 🚀
Bundle Size Analysis (Sentry): |








Explanation of Change
For
ReplaceReceiptwe passed the receipt object without source field. On native,prepareRequestPayloadonly re-roots a receipt path and checks the file exists when source is set. Without it, theReplaceReceiptupload used the raw uri saved when the request was queued.On iOS that uri is an absolute path inside the app container (
Application/<UUID>/Documents/Receipts-Upload/...), and the container moves to a new UUID on app upgrades.So a replacement queued offline before an upgrade failed with the error "Cannot read file at: ...". After the retries ran out, failureData set the receipt to null.
This PR fixes it by adding the source to the receipt in
replaceReceipt, the same way we do for new expenses.Fixed Issues
$ #102259
PROPOSAL:
Tests
iOS: upgrade scenario. The build that adds the receipt must include this change.
Other platforms:
Offline tests
Same as in Tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
Same as in Tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
android.mp4
Android: mWeb Chrome
andr_web.mp4
iOS: Native
ios.mov
iOS: mWeb Safari
ios_web.mov
MacOS: Chrome / Safari
web.mp4