Repository navigation
Part 5- thread reportOwnerLogin through canDeleteReportAction and the merge predicates - #102260
Conversation
…redicates Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
…Approval Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
|
@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
…6413/part-4a # Conflicts: # src/hooks/useSearchBulkActions.ts # src/libs/ReportSecondaryActionUtils.ts # src/libs/ReportUtils.ts # src/libs/SearchUIUtils.ts # src/pages/inbox/report/ContextMenu/BaseReportActionContextMenu.tsx # src/pages/inbox/report/ContextMenu/ContextMenuActions.tsx # tests/unit/ReportUtilsTest.ts
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
|
@DylanDylann friendly bump |
|
@MelvinBot Can you review this PR? |
|
I found no blocking issues. The threading is correct, every caller is updated, and CI passes. I have three non-blocking suggestions.
What I checked
|
|
@Krishna2323 And please resolve conflict |
…6413/part-4a # Conflicts: # src/hooks/useSearchBulkActions.ts # src/libs/ReportUtils.ts # src/libs/actions/IOU/ReportWorkflow.ts # src/pages/Search/SearchReportsMergeReports.tsx # tests/unit/ReportUtilsTest.ts
…ng tests Signed-off-by: krishna2323 <belivethatkg@gmail.com>
|
@Krishna2323 Can you resolve conflict? |
…6413/part-4a Signed-off-by: krishna2323 <belivethatkg@gmail.com>
|
@DylanDylann resolved |
|
conflicts again. This PR is too big, it might be a challenge to merge it. |
…6413/part-4a Signed-off-by: krishna2323 <belivethatkg@gmail.com>
|
@danieldoglas conflicts resolved |
|
@Krishna2323 conflicts again |
…6413/part-4a Signed-off-by: krishna2323 <belivethatkg@gmail.com>
|
@DylanDylann @danieldoglas conflicts resolved 🙇🏻 |
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
|
🚧 danieldoglas has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/danieldoglas in version: 9.5.16-0 🚀
|
|
No help site update is needed. This PR is an internal refactor: it passes the report owner's login into the existing Delete and Merge eligibility checks instead of reading it from global data, so the user-facing rules for when Delete and Merge appear stay the same. |
|
🚀 Deployed to staging by https://github.com/danieldoglas in version: 9.5.18-0 🚀
|
|
No help site update needed. This PR is an internal refactor: it passes the report owner's login into the existing Delete and Merge permission checks instead of reading it from |
|
🚀 Deployed to production by https://github.com/grgia in version: 9.5.18-1 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Fixed Issues
$ #66413
PROPOSAL:
Tests
Setup: Workspace on Advanced approval. A submits to B, B forwards to C. A is a member, not an admin. As A, submit one expense report with a single expense and leave it submitted. Steps 1-5 all use that same report.
Tests
Offline tests
QA Steps
Same as tests
Verify that no errors appear in the JS console
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Monosnap.screencast.2026-10-02.16-56-29.mp4