Repository navigation
Remove supporting text from the Restrict card spend rule form - #102314
Conversation
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
|
🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
|
Did some testing on the adhoc and looks good to me |
|
@cretadn22 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@codex review |
|
Codex Review: Didn't find any major issues. Chef's kiss. Reviewed commit: ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
garrettmknight
left a comment
There was a problem hiding this comment.
Looks clean from a product perspective.
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-09-27.at.14.43.38.movAndroid: mWeb ChromeScreen.Recording.2026-09-27.at.14.39.21.moviOS: HybridAppScreen.Recording.2026-09-27.at.14.44.03.moviOS: mWeb SafariScreen.Recording.2026-09-27.at.14.46.51.movMacOS: Chrome / SafariScreen.Recording.2026-09-27.at.14.37.07.mov |
|
🚧 rlinoz has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/rlinoz in version: 9.4.95-0 🚀
|
|
No help site text changes are needed, so I didn't create a docs PR. One screenshot is now out of date and needs a new image.
@mountiny, I didn't create a help site PR because no text changes are needed. Please confirm this matches the current behavior, and decide who should update the |
|
🚀 Deployed to production by https://github.com/Julesssss in version: 9.4.95-4 🚀
|






Explanation of Change
The helper text under the Restrict merchants toggle was wrong for the Block option. It read "Charges are approved for permitted currencies that don't exceed a max amount, or the merchant or merchant type matches", which says a blocked merchant gets approved. The Allow copy had been reused with "and" swapped to "or".
Rather than reword it, this PR removes the supporting text from the Restrict card spend flow, as agreed in Slack. The field labels already say what each control does, and the two section headings ("If any card matches:" and "Then do this at the point of sale:") did not lead into action based labels.
Eight strings are removed from all 11 locale files under
workspace.rules.spendRules, along with their render sites:restrictCardSpendSubtitleSpendRulePageBaseifAnyCardMatchesSpendRulePageBasethenDoThisAtPointOfSaleSpendRulePageBasemaxAmountHelpSpendRuleMaxAmountBasepermittedCurrenciesSubtitleSpendRulesCurrencyBaserestrictMerchantsOffSubtitlerestrictMerchantsAllowSubtitlerestrictMerchantsBlockSubtitlesettlementCurrencyPermittedSubtitle("The card settlement currency is always permitted") stays. It sits under a locked row on the Permitted currencies page and is the only thing explaining why that currency cannot be deselected.The diff on the two restriction toggle components is larger than the change itself because removing the trailing helper
<Text>leaves a single root element, so the wrapping fragment is gone and the JSX is reindented.No behaviour changes. The help article
docs/articles/new-expensify/expensify-card/Expensify-Card-Spend-Rules.mdalready documents the restriction logic correctly, so it is unchanged.Fixed Issues
$ #102313
PROPOSAL:
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)Avatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Not yet tested — needs manual QA.
Android: mWeb Chrome
Not yet tested — needs manual QA.
iOS: Native
Not yet tested — needs manual QA.
iOS: mWeb Safari
Not yet tested — needs manual QA.
MacOS: Chrome / Safari
Not yet tested — needs manual QA.