Repository navigation
[Payment due @mkhutornyi] Add Bank account column to workspace Members page - #102427
Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
…t-column # Conflicts: # src/components/Tables/WorkspaceMembersTable/WorkspaceMembersTableRow.tsx # src/components/Tables/WorkspaceMembersTable/index.tsx # src/pages/workspace/WorkspaceMembersPage.tsx # src/pages/workspace/members/WorkspaceMemberDetailsPage.tsx
|
Bug: Bank account column flickers when switch to Overview tab and then back to Members bug.mov |
|
bring them on!!! |
This step is failing. Member row is not updated without refresh bug.mov |
|
Same refresh bug: After disable workflow and enable again in another tab, Bank account column values are not showing until refresh bug.mov |
|
Column width flickers. Please check if similar bug already happening on production (either on this table or any other tables) and we can consider out of scope if so bug.movbug.mov |
fixed. The bank accounts were kept on the member list, which gets reset every time the workspace loads. They have their own Onyx key now 34ed9dc
this one was my local backend 😅 , the job that sends updates to other accounts wasn't running. It's on now, can you retry ?
same cause as the flicker. The Members page also loads again now when the column comes back, same commit as above. |
this one isn't from this PR. The table starts with a width of 0 here and uses equal columns until it's measured here, so every column jumps for one frame when the page opens. In your video Member and Approver move too, not just Bank account. It's the same on main with the Approver column, so i think we can keep it out of scope. |
Same same.mov |
|
Is this bug? offline deleted bank account still shows bug.mov |
|
Should we show bug.mov |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari102427.mov |
your app is connecting to Pusher with a different key than my backend. I see
i think that's expected. The delete is still pending while offline, and the column shows what the server has, so it clears once you're back online (it does at the end of your video).
i followed the mockup there, it shows the bank name with just the last four under it, and |
|
ok no blockers then |
Review (re-review at
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 22256ca2d7
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
🤖 Web test steps verification results: I found no regressions on the Members page, the member details page, or the Payments toggle. I couldn't test the Workspace Agents page, which also uses the changed
|
yeah i'd leave it, it only happens when an admin changes their own default and it updates as soon as the request goes through |
Can we just fix that now? It will get reported as a bug otherwise. |
yep, done 6da036a |
arosiclair
left a comment
There was a problem hiding this comment.
LGTM, waiting on deploy for https://github.com/Expensify/Auth/pull/25620
|
Auth PR was deployed, lets merge this @arosiclair |
|
🚧 arosiclair has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/arosiclair in version: 9.5.15-1 🚀
|
|
No help site update needed. This PR adds a read-only Bank account column and member detail entry for admins, but no existing article sentence becomes incorrect, and documenting it would mean adding new content rather than fixing a wrong step. |
|
🚀 Deployed to production by https://github.com/grgia in version: 9.5.15-3 🚀
Bundle Size Analysis (Sentry): |
|
🤖 Payment issue created: #104622 |












Explanation of Change
When a workspace has payments on, admins now see a Bank account column on the Members page with the last four of each member's default bank account, and blank when they don't have one. The member details page shows the same account under Bank accounts.
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/678518
PROPOSAL: N/A
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari