Skip to content

Show the lock icon on the tag GL code row for connected workspaces - #102495

Closed
MelvinBot wants to merge 1 commit into
mainfrom
claude-restoreTagGLCodeLockIcon
Closed

MelvinBot wants to merge 1 commit into
mainfrom
claude-restoreTagGLCodeLockIcon

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Explanation of Change

Restores the lock icon on the tag GL code row when the workspace is connected to an accounting integration.

MenuItem only renders iconRight when shouldShowRightIcon is true. On DynamicTagSettingsPage, iconRight is the Lock only when hasAccountingConnections is true, but #100885 changed shouldShowRightIcon to canWriteTags && !hasAccountingConnections. That hid the icon slot in exactly the case where the Lock is set, so the Lock could never render.

This change sets shouldShowRightIcon={canWriteTags}:

Fixed Issues

$ #102485
PROPOSAL: #102485 (comment)

Tests

// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.

  • Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

…ccounting connection

Co-authored-by: DylanDylann <DylanDylann@users.noreply.github.com>
@MelvinBot
MelvinBot requested a review from a team September 29, 2026 05:28
@melvin-bot melvin-bot Bot added Melvin-Test-Android Melvin-Test-Web Triggers Melvin to run the testing steps of the PR on web labels Sep 29, 2026
@MelvinBot

Copy link
Copy Markdown
Contributor Author

I created this PR from an upstream branch since I don't have push access to your fork.

To take ownership of this branch and be able to push updates, run:

git remote add upstream https://github.com/Expensify/App.git
git fetch upstream claude-restoreTagGLCodeLockIcon
git checkout -b claude-restoreTagGLCodeLockIcon upstream/claude-restoreTagGLCodeLockIcon
git push -u origin claude-restoreTagGLCodeLockIcon

Then you can close this PR and open a new one from your fork.

@MelvinBot

MelvinBot commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor Author

🤖 Web test steps verification results: ⚠️ partial

The PR has no Tests section, so I used the steps from the linked issue. On dev web, the Tags list and tag settings load, and the GL code row on an unconnected workspace shows a chevron that opens the GL code editor. I could not test the main fix, the Lock icon on a QBO-connected workspace, because connecting QBO needs an external Intuit sign-in. I also could not test subtags, because dependent tags need a spreadsheet import.

GL code edit page opened from chevron tap

Step Status
Workspace settings > Tags list loadsThe list shows the new "Engineering" tag and its Enabled toggle.
Tags list showing Engineering tag
✅
Opening a tag shows a GL code rowThe "Engineering" tag page shows Enable tag, Name, GL code, and Delete.
Tag settings page showing GL code row with chevron
✅
Opening a subtag shows a GL code rowNot tested. Dependent tags need a CSV import (file upload), which this web session can't do. Subtags use the same page, DynamicTagSettingsPage, as the top-level tag in step 2.
⚠️
Not connected: GL code row shows a chevron and opens the GL code editorThe row shows a right chevron. Tapping it opened the GL code edit page. I upgraded the trial workspace to Control first, because GL codes require the Control plan.
Tag settings page showing GL code row with chevron
GL code edit page opened from chevron tap
✅
Connected to QBO: GL code row shows a Lock icon and is non-interactiveNot tested. Connecting QBO redirects to Intuit's external OAuth sign-in, and the dev environment has no QBO credentials. Someone with a connected workspace needs to check this.
⚠️
No errors appear in the JS consoleI saw no error banners, toasts, or broken UI during the flow. The web tooling can't dump the browser console, so I based this on the UI only.
✅

view run · view recording

@MelvinBot

MelvinBot commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor Author

🤖 Android test steps verification results: ⚠️ partial

The PR has no Tests section, so I used the steps from the linked issue. On Android, the GL code row on an unconnected workspace shows a chevron that opens the GL code editor. I could not test the main fix, the Lock icon on a QBO-connected workspace, because QBO can't be connected in this environment. I also could not test subtags, because an unrelated bug froze the app while I was setting up dependent tags.

GL code edit page opened after tapping the chevron row

Step Status
Workspace settings > Tags list loadsThe list shows the new "Marketing" tag with the Add tag, Import, and Display controls.
Workspace Tags list with Marketing tag
✅
Opening a tag shows a GL code rowThe "Marketing" tag page shows Enable tag, Name, GL code, and Delete. The GL code row has a chevron.
Tag settings page showing GL code row with chevron
✅
Opening a subtag shows a GL code rowNot tested. Tapping Tags > More > Settings to set up dependent tags logged "The action 'DISMISS_MODAL' was not handled by any navigator" and froze the menu. That menu is outside this PR's change.
⚠️
Not connected: GL code row shows a chevron and opens the GL code editorThe row shows a chevron, not a lock. The first tap opened the Control plan paywall. After the free in-app upgrade, the tap opened the GL code edit page.
GL code Control-plan paywall reached via chevron tap
GL code edit page opened after tapping the chevron row
✅
Connected to QBO: GL code row shows a Lock icon and is non-interactiveNot tested. QBO can't be connected in this environment. Someone with a connected workspace needs to check this.
⚠️
No errors or crashes appear during the flowThe tag and GL code screens logged no errors. The Tags > More > Settings path logged the DISMISS_MODAL error above and froze the app. That path is not part of this PR's change.
❌

view run · view recording

@DylanDylann

Copy link
Copy Markdown
Contributor

@MelvinBot The author already created PR to fix this bug. Please close this PR

@MelvinBot

Copy link
Copy Markdown
Contributor Author

I couldn't close this PR because I don't have permission to close PRs in this run. DylanDylann, please close it yourself.

This PR is no longer needed: fix: show lock icon on tag GL code field when connected to accounting already fixes this bug.


view run

@DylanDylann

Copy link
Copy Markdown
Contributor

@MelvinBot I am Dylan and I don't have permission to close and You have permission to close because you created it. Please help to close

@MelvinBot

Copy link
Copy Markdown
Contributor Author

Sorry DylanDylann, I still can't close this PR. The close command needs approval that I don't have in this run, even though I opened the PR.

This PR is no longer needed because fix: show lock icon on tag GL code field when connected to accounting fixes the same bug. You can ask an Expensify employee, such as the issue assignee blimpich, to close it.


view run

@DylanDylann

Copy link
Copy Markdown
Contributor

@blimpich Can you please help to close this PR?

@blimpich blimpich closed this Sep 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Melvin-Test-Android Melvin-Test-Web Triggers Melvin to run the testing steps of the PR on web

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants