Repository navigation
Conversation
…ccounting connection Co-authored-by: DylanDylann <DylanDylann@users.noreply.github.com>
|
I created this PR from an upstream branch since I don't have push access to your fork. To take ownership of this branch and be able to push updates, run: Then you can close this PR and open a new one from your fork. |
|
🤖 Web test steps verification results: The PR has no Tests section, so I used the steps from the linked issue. On dev web, the Tags list and tag settings load, and the GL code row on an unconnected workspace shows a chevron that opens the GL code editor. I could not test the main fix, the Lock icon on a QBO-connected workspace, because connecting QBO needs an external Intuit sign-in. I also could not test subtags, because dependent tags need a spreadsheet import.
|
|
🤖 Android test steps verification results: The PR has no Tests section, so I used the steps from the linked issue. On Android, the GL code row on an unconnected workspace shows a chevron that opens the GL code editor. I could not test the main fix, the Lock icon on a QBO-connected workspace, because QBO can't be connected in this environment. I also could not test subtags, because an unrelated bug froze the app while I was setting up dependent tags.
|
|
@MelvinBot The author already created PR to fix this bug. Please close this PR |
|
I couldn't close this PR because I don't have permission to close PRs in this run. This PR is no longer needed: fix: show lock icon on tag GL code field when connected to accounting already fixes this bug. |
|
@MelvinBot I am Dylan and I don't have permission to close and You have permission to close because you created it. Please help to close |
|
Sorry This PR is no longer needed because fix: show lock icon on tag GL code field when connected to accounting fixes the same bug. You can ask an Expensify employee, such as the issue assignee |
|
@blimpich Can you please help to close this PR? |







Explanation of Change
Restores the lock icon on the tag GL code row when the workspace is connected to an accounting integration.
MenuItemonly rendersiconRightwhenshouldShowRightIconis true. OnDynamicTagSettingsPage,iconRightis the Lock only whenhasAccountingConnectionsis true, but #100885 changedshouldShowRightIcontocanWriteTags && !hasAccountingConnections. That hid the icon slot in exactly the case where the Lock is set, so the Lock could never render.This change sets
shouldShowRightIcon={canWriteTags}:Fixed Issues
$ #102485
PROPOSAL: #102485 (comment)
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
Offline tests
QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari