Repository navigation
[No QA][Insights] Distinguish getInsights request failures from backend errors - #102544
Conversation
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
JmillsExpensify
left a comment
There was a problem hiding this comment.
Big fan of this update. It makes the product experience feel more purposeful and less broken.
Reviewer Checklist
Screenshots/VideosMacOS: Chrome / SafariScreen.Recording.2026-09-30.at.11.04.08.movScreen.Recording.2026-09-30.at.11.06.31.mov |
|
@truph01 Addressed your comment! |
…-And-Request-Problem
luacmartins
left a comment
There was a problem hiding this comment.
LGTM. @OlGierd03 we have conflicts
…-And-Request-Problem
451aeda
|
🚧 luacmartins has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/luacmartins in version: 9.5.0-0 🚀
|
|
No help site update needed. This PR only changes the in-app error state on Insights, showing "Refresh needed" instead of "Something went wrong" when a request gets no response, and no Insights article describes these error states. |
|
🚀 Deployed to production by https://github.com/Julesssss in version: 9.5.0-5 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
The Insights page showed the generic "Something went wrong" error for every failed
GetInsights, even when the request simply never got a response. In that case the user only needs to retry. This PR matches Spend and shows "Refresh needed" with a Refresh button instead.The page now tells the two failures apart through
responseJsonCodeon the dashboard record:NO_RESPONSE(the request never landed) shows the newSTALEstate with the "Refresh needed" view.Note
GetInsightsis now sent withmakeRequestWithSideEffects, because read hides both the response code and network rejections, same asSearchFixed Issues
$ #102550
Tests
Prerequisite: an account with expenses, so the Insights page shows charts.
Request that never gets a response:
Backend returns an error:
Regression:
Offline tests
QA Steps
NoQA
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)Avatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
MacOS: Chrome / Safari
Screen.Recording.2026-09-29.at.16.04.20.mov
Screen.Recording.2026-09-29.at.16.11.29.mov