Skip to content

Extract ReportDetailsAvatar, ReportDetailsDescription and ReportDetailsPromotedActions - #102548

Merged
mjasikowski merged 6 commits into
Expensify:mainfrom
callstack-internal:refactor/rd-03-leaf-rows
Sep 30, 2026
Merged

mjasikowski merged 6 commits into
Expensify:mainfrom
callstack-internal:refactor/rd-03-leaf-rows

Conversation

@sosek108

@sosek108 sosek108 commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

This moves the avatar, description and promoted-actions sections of the Report Details page into their own components: ReportDetailsAvatar, ReportDetailsDescription and ReportDetailsPromotedActions. Each one takes only reportID and reads its own Onyx data, so the page no longer passes report data down to them. The REPORT_METADATA subscription used for pending member deletes moved from the page into ReportDetailsAvatar, the only place that uses it. This is a pure refactor and behaviour does not change.

Stack note: this is PR 3 of 8 in the DynamicReportDetailsPage decomposition (parent issue #102173). It is stacked on PR 2, #102413 (refactor/rd-02-types), and should be reviewed and merged after it. The base is main, so until PR 1 and PR 2 merge this diff also shows their commits.

Fixed Issues

$ #102178
PROPOSAL:

Tests

  1. Open a workspace room, then open its Report details. Verify the avatar, the room description and the promoted actions look and behave as on main
  2. Open a group chat, then open its Report details. Verify the group avatar can be changed and removed as on main
  3. Open an expense report, then open its Report details. Verify the avatar and the promoted actions look and behave as on main
  4. Open a transaction thread, then open its Report details. Verify the page looks and behaves as on main
  5. Open a workspace room that has a description, then open its Report details. Tap the room description row and verify it opens the description page as on main
  6. Open a public room you have not joined, then open its Report details. Verify the Join action shows as on main

Offline tests

N/A. This PR only moves code and does not change network behaviour.

QA Steps

Same as tests.

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Nagranie.z.ekranu.2026-09-30.o.10.02.25.mov

@sosek108 sosek108 changed the title [No QA] Extract ReportDetailsAvatar, ReportDetailsDescription and ReportDetailsPromotedActions Extract ReportDetailsAvatar, ReportDetailsDescription and ReportDetailsPromotedActions Sep 30, 2026
@codecov

codecov Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
src/pages/DynamicReportDetailsPage/index.tsx 83.95% <100.00%> (+2.15%) ⬆️
...amicReportDetailsPage/ReportDetailsDescription.tsx 96.00% <96.00%> (ø)
...ReportDetailsPage/ReportDetailsPromotedActions.tsx 93.33% <93.33%> (ø)
...s/DynamicReportDetailsPage/ReportDetailsAvatar.tsx 68.88% <68.88%> (ø)
... and 21 files with indirect coverage changes

@sosek108

Copy link
Copy Markdown
Contributor Author

Eslint seems to be not related to this PR

@sosek108
sosek108 marked this pull request as ready for review September 30, 2026 08:20
@sosek108
sosek108 requested review from a team as code owners September 30, 2026 08:20
@melvin-bot
melvin-bot Bot requested review from garrettmknight and nkdengineer and removed request for a team September 30, 2026 08:20
@melvin-bot

melvin-bot Bot commented Sep 30, 2026

Copy link
Copy Markdown

@nkdengineer Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@sosek108

Copy link
Copy Markdown
Contributor Author

@MelvinBot review

@MelvinBot

Copy link
Copy Markdown
Contributor

I found no blocking issues. The three new components behave the same as the code they replace, so this looks like a clean pure refactor.

The only failing check is ESLint, and it has nothing to do with this PR. The error is max-lines in src/libs/PolicyUtils.ts (4039 lines, 4000 allowed), and this PR doesn't touch that file.

What I checked
  • Same data sources. withReportOrNotFound reads report and policy with the same @hooks/useOnyx keys that the new components use. The components therefore get the same values as the page, including in the Search snapshot case. useAllPersonalDetails() wraps useOnyx(ONYXKEYS.PERSONAL_DETAILS_LIST), which is what the page used.
  • Same derived flags. isChatRoom, isThread, isGroupChat, shouldOpenRoomMembersPage, participants, isReportArchived, shouldShowReportDescription, isTaskModifiable and canJoin are computed exactly as they were in the page.
  • Removed fallbacks are safe. ReportHeaderAvatars now gets report.reportID instead of report?.reportID ?? moneyRequestReport?.reportID, and if (report) is gone before PromotedActions.pin. Both are safe because the HOC guarantees report.
  • Hook order. Each component calls all of its hooks before its !report?.reportID early return.
  • Nothing left unused. conciergeReportID, isReportArchived, reportNameValuePairs, personalDetails and participants are all still used elsewhere in the page. Typecheck and React Compiler Compliance pass.

Optional nits. Feel free to leave these for a later PR in the stack:

I reviewed the code only. I didn't run the manual test steps in the app.


view run

@nkdengineer

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Screen.Recording.2026-09-30.at.21.10.08.mov
Android: mWeb Chrome
Screen.Recording.2026-09-30.at.21.01.55.mov
iOS: HybridApp
Screen.Recording.2026-09-30.at.21.10.30.mov
iOS: mWeb Safari
Screen.Recording.2026-09-30.at.21.12.56.mov
MacOS: Chrome / Safari
Screen.Recording.2026-09-30.at.16.24.13.mov
Screen.Recording.2026-09-30.at.20.51.24.mov
Screen.Recording.2026-09-30.at.20.55.04.mov
Screen.Recording.2026-09-30.at.20.55.44.mov
Screen.Recording.2026-09-30.at.20.57.21.mov
Screen.Recording.2026-09-30.at.20.57.44.mov
Screen.Recording.2026-09-30.at.20.58.31.mov

@nkdengineer nkdengineer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me and test well.

@melvin-bot
melvin-bot Bot requested a review from mjasikowski September 30, 2026 14:15
@mjasikowski
mjasikowski merged commit 0c26fc8 into Expensify:main Sep 30, 2026
35 of 38 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

🚧 mjasikowski has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

OSBotify commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/mjasikowski in version: 9.5.0-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor

No help site update is needed. This PR is a pure refactor that moves the Report details avatar, description, and promoted actions into separate components without changing any labels, routes, or behavior users see.


view run

@kavimuru

kavimuru commented Oct 1, 2026

Copy link
Copy Markdown

@sosek108
Applause can't test in main , how to compare here?
pen a workspace room, then open its Report details. Verify the avatar, the room description and the promoted actions look and behave as on main
Open a group chat, then open its Report details. Verify the group avatar can be changed and removed as on main
Open an expense report, then open its Report details. Verify the avatar and the promoted actions look and behave as on main
Open a transaction thread, then open its Report details. Verify the page looks and behaves as on main
Open a workspace room that has a description, then open its Report details. Tap the room description row and verify it opens the description page as on main
Open a public room you have not joined, then open its Report details. Verify the Join action shows as on main

@nkdengineer

Copy link
Copy Markdown
Contributor

@kavimuru You can compare with production

@OSBotify

OSBotify commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/Julesssss in version: 9.5.0-5 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 failure ❌

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants