Repository navigation
Extract ReportDetailsAvatar, ReportDetailsDescription and ReportDetailsPromotedActions - #102548
Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
Eslint seems to be not related to this PR |
|
@nkdengineer Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@MelvinBot review |
|
I found no blocking issues. The three new components behave the same as the code they replace, so this looks like a clean pure refactor. The only failing check is ESLint, and it has nothing to do with this PR. The error is What I checked
Optional nits. Feel free to leave these for a later PR in the stack:
I reviewed the code only. I didn't run the manual test steps in the app. |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-09-30.at.21.10.08.movAndroid: mWeb ChromeScreen.Recording.2026-09-30.at.21.01.55.moviOS: HybridAppScreen.Recording.2026-09-30.at.21.10.30.moviOS: mWeb SafariScreen.Recording.2026-09-30.at.21.12.56.movMacOS: Chrome / SafariScreen.Recording.2026-09-30.at.16.24.13.movScreen.Recording.2026-09-30.at.20.51.24.movScreen.Recording.2026-09-30.at.20.55.04.movScreen.Recording.2026-09-30.at.20.55.44.movScreen.Recording.2026-09-30.at.20.57.21.movScreen.Recording.2026-09-30.at.20.57.44.movScreen.Recording.2026-09-30.at.20.58.31.mov |
nkdengineer
left a comment
There was a problem hiding this comment.
Looks good to me and test well.
|
🚧 mjasikowski has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/mjasikowski in version: 9.5.0-0 🚀
|
|
No help site update is needed. This PR is a pure refactor that moves the Report details avatar, description, and promoted actions into separate components without changing any labels, routes, or behavior users see. |
|
@sosek108 |
|
@kavimuru You can compare with production |
|
🚀 Deployed to production by https://github.com/Julesssss in version: 9.5.0-5 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
This moves the avatar, description and promoted-actions sections of the Report Details page into their own components:
ReportDetailsAvatar,ReportDetailsDescriptionandReportDetailsPromotedActions. Each one takes onlyreportIDand reads its own Onyx data, so the page no longer passes report data down to them. TheREPORT_METADATAsubscription used for pending member deletes moved from the page intoReportDetailsAvatar, the only place that uses it. This is a pure refactor and behaviour does not change.Stack note: this is PR 3 of 8 in the
DynamicReportDetailsPagedecomposition (parent issue #102173). It is stacked on PR 2, #102413 (refactor/rd-02-types), and should be reviewed and merged after it. The base ismain, so until PR 1 and PR 2 merge this diff also shows their commits.Fixed Issues
$ #102178
PROPOSAL:
Tests
mainmainmainmainmainmainOffline tests
N/A. This PR only moves code and does not change network behaviour.
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Nagranie.z.ekranu.2026-09-30.o.10.02.25.mov