Repository navigation
Onboarding: show interested features as tiles with subtext - #102566
Conversation
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx bun ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
|
@ChavdaSachin Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@mkhutornyi just for clarity, as I may have had wires crossed about where it was posted, but these tiles can have multiple selected, whereas the accounting selector screen can have only one. So Features = checkboxes; Accounting = radio button |
dylanexpensify
left a comment
There was a problem hiding this comment.
Looks good from a product perspective 👍
yes correct. Accounting : checkbox -> radio is being fixed in #102477 |
|
@mkhutornyi am I supposed to review this ? |
yes |
|
@ChavdaSachin kind bump |
Reviewer Checklist
Screenshots/VideosAndroid: NativeScreen.Recording.2026-10-05.at.1.22.35.PM.movMacOS: Chrome / SafariScreen.Recording.2026-10-05.at.12.42.43.PM.mov |
|
We did not find an internal engineer to review this PR, trying to assign a random engineer to #102006 as well as to this PR... Please reach out for help on Slack if no one gets assigned! |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 yuwenmemon has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/yuwenmemon in version: 9.5.3-0 🚀
|
|
No help site update needed. This PR changes only the layout and heading text of the onboarding feature-selection step, and no article under |
|
🚀 Deployed to production by https://github.com/puneetlath in version: 9.5.3-4 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Changes the onboarding interested-features step from full-width rows to a grid of square tiles: 4 per row on wide layouts, 2 on narrow.
Tiles in the "additional features" section show a short description, reusing the existing More features copy.
The screen title and both section headings now use the copy from the mocks.
The accounting step's tile styles are renamed to shared
onboardingTile*styles and reused here, so both steps look the same.justifyContent: 'center'is removed from the shared tile, which doesn't visibly change the accounting step.Selection, the defaults, the submitted payload and the routing to the accounting step are unchanged.
Fixed Issues
$ #102006
Tests
Offline tests
Same as Tests
QA Steps
Same as Tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)Avatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
Screen.Recording.iPhone.18.Pro.09-29-2026.at.9.58.56.AM.mp4
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-09-29.at.9.52.53.AM.mov