Repository navigation
Limit card fraud alert GBR and buttons to the cardholder - #102581
Conversation
|
bump @situchan |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safaribefore.fix.movafter.fix.mov |
dylanexpensify
left a comment
There was a problem hiding this comment.
Looks good from a product perspective 👍
|
bump @situchan |
3d640a2 to
e483b26
Compare
…-gbr # Conflicts: # src/libs/ReportUtils.ts
|
Please pull main to fix job 6 |
ReviewThe fix looks correct, and I found no blocking issues. The green dot, the Home tile, and the buttons now all depend on the same check: the current user's card has live Minor points, none blocking:
CI: |
Regression checkI found one likely regression and one edge case worth fixing. The LHN, focus mode, To-do, and Home tile all get the new check, the removed exports have no other users, and the order of attention reasons is unchanged. 1. Stale green dots survive the upgrade (confirmed in code).
Fix: on the first compute ( 2. The dot and the buttons match cards differently (possible). The dot fires when any card's Lower-risk notes
|
|
The provided test case works well but please check above. The edge cases are non blockers though |
…ed green dots on app start
… into app-100123-card-fraud-gbr
|
Looks like job 4 failure is related |
|
Added WIP, will see if I can simplify this PR. |
|
Ready again @situchan |
|
@MelvinBot review |
Review (head
|
|
We did not find an internal engineer to review this PR, trying to assign a random engineer to #100123 as well as to this PR... Please reach out for help on Slack if no one gets assigned! |
Regression check (head
|
|
Yeah I’ll push a fix now |
|
🚧 stitesExpensify has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/stitesExpensify in version: 9.5.4-0 🚀
|
|
No help site update needed. This is a bug fix that stops showing fraud alert buttons, the green dot, and the Home task to admins and after fraud is cleared, which is what users already expect, and no existing article describes the old behavior. |
|
🚀 Deployed to production by https://github.com/puneetlath in version: 9.5.4-3 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Fixes an issue where admins saw the green dot and the "Yes, I do" / "No, it wasn't me" buttons on a cardholder's fraud alert, and where both stayed after fraud was cleared on the card. The GBR also remained visible for the submitter even after the fraud was cleared.
Fixed Issues
$ #100123
PROPOSAL: N/A
Tests
Setup: web, sign in as a user with a workspace. Open your workspace chat and copy its reportID from the URL. In the console, set
R = '<reportID>'.Onyx.merge('cardList', {999: {nameValuePairs: {possibleFraud: null}}})Onyx.merge('cardList', {999: null})Offline tests
Same as tests. Client-only change.
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Main
https://github.com/user-attachments/assets/f4705618-2828-440e-8e26-baf7bf58db19
This PR
https://github.com/user-attachments/assets/76880a16-c41e-42fc-9d53-74590c2f11d4