Skip to content

Analyzing is incorrectly shown after creating expense and enabling auto categorizing offline - #102626

Merged
jasperhuangg merged 6 commits into
Expensify:mainfrom
dukenv0307:fix/102604
Oct 6, 2026
Merged

jasperhuangg merged 6 commits into
Expensify:mainfrom
dukenv0307:fix/102604

Conversation

@dukenv0307

Copy link
Copy Markdown
Contributor

Explanation of Change

Fixed Issues

$ #102604
PROPOSAL:

Tests

Precondition:

Disable Auto-categorize new expenses in Categories settings.

  1. Go to staging.new.expensify.com
  2. Go to workspace chat.
  3. Go offline.
  4. Create an expense with Starbucks merchant.
  5. Go to workspace settings > Categories > Settings.
  6. Enable Auto-categorize new expenses.
  7. Open the expense from Step 4.
  8. Go online.
    Verify that: In Step 7, after creating expense and enabling Auto-categorize new expenses offline, Analysing will not appear on Category field because expense is already created before Auto-categorize new expenses is enabled.
  • Verify that no errors appear in the JS console

Offline tests

Same as above

QA Steps

Same as above

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-09-30.at.14.34.23.mov

@dukenv0307
dukenv0307 marked this pull request as ready for review September 30, 2026 07:39
@dukenv0307
dukenv0307 requested review from a team as code owners September 30, 2026 07:39
@melvin-bot
melvin-bot Bot requested review from JmillsExpensify and truph01 and removed request for a team September 30, 2026 07:40
@melvin-bot

melvin-bot Bot commented Sep 30, 2026

Copy link
Copy Markdown

@truph01 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot requested review from a team and removed request for a team September 30, 2026 07:40

@JmillsExpensify JmillsExpensify left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dukenv0307

Copy link
Copy Markdown
Contributor Author

@MelvinBot Why are the tests failing?

@MelvinBot

Copy link
Copy Markdown
Contributor

Two checks fail: typecheck and ESLint check. Three of the four errors come from this PR. The fourth comes from the branch being behind main.

Caused by this PR

  1. The new wasAutoCategorizeEnabledOnCreation field on Transaction is not handled in DebugUtils.ts. Both checks fail on this:
    • src/libs/DebugUtils.ts:1016: the switch is not exhaustive (ESLint). To fix it, add case 'wasAutoCategorizeEnabledOnCreation': to the boolean group at lines 1050-1058, which returns validateBoolean(value).
    • src/libs/DebugUtils.ts:1119: pendingFields is missing the new key (TS2741). To fix it, add wasAutoCategorizeEnabledOnCreation: CONST.RED_BRICK_ROAD_PENDING_ACTION, or drop the field from pendingFields in Transaction.ts if it doesn't need one.
  2. tests/actions/IOU/RequestMoneyTest.ts:1664: {id: 'A', autoCategorizeNewExpenses: false} as Policy breaks no-unsafe-type-assertion. To fix it, build a full policy, for example {...createRandomPolicy(1), id: 'A', autoCategorizeNewExpenses: false} from tests/utils/collections/policies.ts.

Not caused by this PR

  • src/libs/PolicyUtils.ts has 4039 lines, which breaks max-lines (the limit is 4000). This PR doesn't touch that file, and it has 3826 lines on main today. To fix it, merge main into the branch.

The checklist failure is the PR Author Checklist. It clears when you tick every box.


view run

@truph01

truph01 commented Sep 30, 2026

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained """"why"""" the code was doing something instead of only explaining """"what"""" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

MacOS: Chrome / Safari
output.mp4

@truph01

truph01 commented Sep 30, 2026

Copy link
Copy Markdown
Contributor

Bug: In the split flow, the split expense is displayed with the "Analyzing..." label indefinitely.

Steps:

  1. Enable "Auto-categorize new expenses" in Categories settings.
  2. Create an expense, open it, and split it.
  3. Remove the default category assigned to each split expense, if any, and save.
  4. Open any split expense.
  5. Verify that the Category row displays "Analyzing..." indefinitely.
Screen.Recording.2026-10-01.at.00.55.19.mov

cardName: existingTransaction?.cardName,
cardNumber: existingTransaction?.cardNumber,
...(existingTransaction?.iouRequestType ? {iouRequestType: existingTransaction.iouRequestType} : {}),
wasAutoCategorizeEnabledOnCreation: policy?.autoCategorizeNewExpenses !== false,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Callers that pass existingTransaction without a policy (e.g. SplitExpenseItems.ts, SplitExpenses.ts) flip a recorded false back to true.
Would falling back to existingTransaction?.wasAutoCategorizeEnabledOnCreation when policy is missing be safer?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

// Check if manual request is being created
if (pendingAction === CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD) {
return true;
return transaction.wasAutoCategorizeEnabledOnCreation !== false;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer === true here?

buildOptimisticTransaction always writes an explicit true or false for wasAutoCategorizeEnabledOnCreation, so === true would read more directly than !== false — what do you think?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@truph01 Keeping !== false so a pending expense created before this field existed still shows "Analyzing...". A missing value means the setting defaulted to on. New expenses already store true in that case.

@jasperhuangg jasperhuangg changed the title Analyzing is incorrectly shown after creating expense and enabling auto categorizing offline [CP stag] Analyzing is incorrectly shown after creating expense and enabling auto categorizing offline Sep 30, 2026
@jasperhuangg jasperhuangg changed the title [CP stag] Analyzing is incorrectly shown after creating expense and enabling auto categorizing offline Analyzing is incorrectly shown after creating expense and enabling auto categorizing offline Sep 30, 2026
@dukenv0307

Copy link
Copy Markdown
Contributor Author

@truph01 I think the issue #102626 (comment) is pre-existing then we should fix in a follow-up

@dukenv0307

Copy link
Copy Markdown
Contributor Author

@truph01 All yours, can you please create an issue for #102626 (comment)?

@dukenv0307
dukenv0307 requested a review from truph01 October 2, 2026 01:50
@dukenv0307

Copy link
Copy Markdown
Contributor Author

@truph01 all good?

cardNumber: existingTransaction?.cardNumber,
...(existingTransaction?.iouRequestType ? {iouRequestType: existingTransaction.iouRequestType} : {}),
// Splits rebuild this expense without a policy. A missing policy would otherwise read as enabled and erase a recorded false.
wasAutoCategorizeEnabledOnCreation: policy ? policy.autoCategorizeNewExpenses !== false : existingTransaction?.wasAutoCategorizeEnabledOnCreation !== false,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Readers all check !== false, so the true branch writes a no-op field to every transaction — could we drop it with ...(policy?.autoCategorizeNewExpenses === false ? {wasAutoCategorizeEnabledOnCreation: false} : {})?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@truph01 Fixed

@melvin-bot
melvin-bot Bot requested a review from jasperhuangg October 5, 2026 08:13
@dukenv0307

Copy link
Copy Markdown
Contributor Author

@jasperhuangg All yours!

@jasperhuangg
jasperhuangg merged commit a7d3f8b into Expensify:main Oct 6, 2026
34 of 36 checks passed
@OSBotify

OSBotify commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions

github-actions Bot commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

🚧 jasperhuangg has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify OSBotify mentioned this pull request Oct 6, 2026
100 tasks done
@OSBotify

OSBotify commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/jasperhuangg in version: 9.5.4-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor

No help site update needed. This bug fix stops the "Analyzing" label from showing on an expense created offline before Auto-categorize was turned on, and no article in docs/articles describes that label.


view run

@OSBotify

OSBotify commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/puneetlath in version: 9.5.4-3 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants