Skip to content

[CP Staging] fix: Floating RHP closes when clicking the top of the card - #102638

Merged
mountiny merged 1 commit into
Expensify:mainfrom
callstack-internal:gaborone/github-issue-102622
Sep 30, 2026
Merged

mountiny merged 1 commit into
Expensify:mainfrom
callstack-internal:gaborone/github-issue-102622

Conversation

@BartekObudzinski

@BartekObudzinski BartekObudzinski commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

#101093 added thin transparent overlay bands around the floating RHP card so clicks in the 12px gap close the RHP. The bands reuse BaseOverlay, which always renders a fixed 30px top pressable (the old Electron drag bar), and nothing clipped it, so it spilled 18px onto the top of the card. Clicking there closed the RHP. This adds overflowHidden to the BaseOverlay root so its pressables stay inside the overlay's own box. Full height overlays are unaffected.

Fixed Issues

$ #102622
PROPOSAL: N/A (deploy blocker)

Tests

  1. open app
  2. Go to workspace chat.
  3. Create an expense.
  4. Open the report.
  5. Click on the area above Submit button within the floating RHP.
  6. Verify the floating RHP does not close after clicking on the top area within the RHP.
  • Verify that no errors appear in the JS console

Offline tests

Same as tests, the change is layout only and doesn't depend on network.

QA Steps

Same as tests

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-09-30.at.11.19.11.mov

@codecov

codecov Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
...on/AppNavigator/Navigators/Overlay/BaseOverlay.tsx 0.00% <0.00%> (ø)
... and 8 files with indirect coverage changes

@BartekObudzinski
BartekObudzinski marked this pull request as ready for review September 30, 2026 09:24
@BartekObudzinski
BartekObudzinski requested review from a team as code owners September 30, 2026 09:24
@melvin-bot
melvin-bot Bot requested review from huult and removed request for a team September 30, 2026 09:24
@melvin-bot

melvin-bot Bot commented Sep 30, 2026

Copy link
Copy Markdown

@huult Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot requested review from dylanexpensify and removed request for a team September 30, 2026 09:24
@huult

huult commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Screen.Recording.2026-09-30.at.16.39.42.mov
Android: mWeb Chrome
Screen.Recording.2026-09-30.at.16.38.25.mov
iOS: HybridApp
Screen.Recording.2026-09-30.at.16.43.12.mov
iOS: mWeb Safari
Screen.Recording.2026-09-30.at.16.42.37.mov
MacOS: Chrome / Safari
Screen.Recording.2026-09-30.at.16.33.51.mov

@huult

huult commented Sep 30, 2026

Copy link
Copy Markdown
Contributor

@MelvinBot review this

@MelvinBot

Copy link
Copy Markdown
Contributor

Code review: looks good ✅

The fix is correct and minimal. I found no blocking issues.

Why it works and what I checked
  • Root cause confirmed: The top gap band is only 12px tall. It gets bottom = windowHeight - rhpFloatingCardMargin (RightModalNavigator.tsx:213, L577-L583). But BaseOverlay always renders the 30px draggableTopBar (styles/index.ts:5496). The extra 18px landed on top of the card.
  • Fix: overflowHidden on the root (BaseOverlay.tsx:65-66) clips the top bar to the band. On web, clipped content does not receive clicks.
  • Other overlays: Full-height overlays (main scrim, tertiary overlay, right gap band) are unaffected because their children already fit inside the box. The bottom band's top bar used to hang off-screen below the viewport. It is now clipped too, which is harmless.
  • Native: No impact. Overlay/index.native.tsx returns null, so BaseOverlay renders only on web.

Web test results are in the next comment.


view run

@MelvinBot

MelvinBot commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

🤖 Web test steps verification results: ✅ pass

On dev NewDot web at a 1280x900 desktop viewport, the expense report opens as a floating RHP with a 12px gap. Clicking near the card's top edge (y=18–28) does not close it, while clicking the gap above (y=5) or the dimmed area to the left both close it, confirming the fix.
Final state with floating RHP reopened

Step Status
Expense report opens in a floating RHP card with visible gap above/below/rightCard inset ~12px from top/right/bottom with dimmed workspace chat/LHN behind it, at 1280x900 viewport
Floating RHP card with visible gap and dimmed background
✅
Click near top edge inside card (700,22, ~y=18-28) does not close the RHPSnapshot and screenshot unchanged after the click; Expense Report content still visible
RHP still open after clicking near top edge inside the card
✅
Click in the 12px gap above the card (700,5) closes the RHPView navigated back to the workspace expense chat
RHP closed after clicking the gap above the card
✅
Click the dimmed area to the left of the RHP (200,400) closes the RHPView navigated back to the workspace expense chat
RHP closed after clicking the dimmed area to the left
✅
No new JS console errors during the flowNo error banners/toasts appeared in the UI across all steps; agent-device web has no console-log capture verb, so only UI-visible errors were checked
✅

view run · view recording

@huult huult left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@melvin-bot
melvin-bot Bot requested a review from mountiny September 30, 2026 10:19
@mountiny mountiny changed the title fix: Floating RHP closes when clicking the top of the card [CP Staging] fix: Floating RHP closes when clicking the top of the card Sep 30, 2026

@mountiny mountiny left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@mountiny
mountiny merged commit cde5052 into Expensify:main Sep 30, 2026
41 of 47 checks passed
@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions

Copy link
Copy Markdown
Contributor

🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here.

OSBotify pushed a commit that referenced this pull request Sep 30, 2026
…sue-102622

(cherry picked from commit cde5052)

(cherry-picked to staging by mountiny)
@OSBotify OSBotify added the CP Staging marks PRs that have been CP'd to staging label Sep 30, 2026
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.4.97-2 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 cancelled 🔪
🍎 iOS 🍎 cancelled 🔪

@MelvinBot

Copy link
Copy Markdown
Contributor

No help site update needed. This PR fixes a bug where clicking the top of the floating side panel closed it by mistake, so the app now does what users already expect.


view run

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.4.99-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor

No help site update needed. This PR is a layout-only bug fix: clicking the top edge of the floating side panel no longer closes it. That is how users already expect it to behave, so no article sentence becomes incorrect.


view run

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/Julesssss in version: 9.4.99-2 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@OSBotify

OSBotify commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.5.0-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor

No help site update is needed. This PR fixes a layout bug so that clicking the top of the floating right-hand panel no longer closes it, which is the behavior users already expect.


view run

@OSBotify

OSBotify commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/Julesssss in version: 9.5.0-5 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 failure ❌

Bundle Size Analysis (Sentry):

@grgia grgia mentioned this pull request Nov 16, 2026
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CP Staging marks PRs that have been CP'd to staging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants