Repository navigation
[CP Staging] fix: Floating RHP closes when clicking the top of the card - #102638
Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-09-30.at.16.39.42.movAndroid: mWeb ChromeScreen.Recording.2026-09-30.at.16.38.25.moviOS: HybridAppScreen.Recording.2026-09-30.at.16.43.12.moviOS: mWeb SafariScreen.Recording.2026-09-30.at.16.42.37.movMacOS: Chrome / SafariScreen.Recording.2026-09-30.at.16.33.51.mov |
|
@MelvinBot review this |
Code review: looks good ✅The fix is correct and minimal. I found no blocking issues. Why it works and what I checked
Web test results are in the next comment. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
…sue-102622 (cherry picked from commit cde5052) (cherry-picked to staging by mountiny)
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.4.97-2 🚀
|
|
No help site update needed. This PR fixes a bug where clicking the top of the floating side panel closed it by mistake, so the app now does what users already expect. |
|
🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.4.99-0 🚀
|
|
No help site update needed. This PR is a layout-only bug fix: clicking the top edge of the floating side panel no longer closes it. That is how users already expect it to behave, so no article sentence becomes incorrect. |
|
🚀 Deployed to production by https://github.com/Julesssss in version: 9.4.99-2 🚀
Bundle Size Analysis (Sentry): |
|
🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.5.0-0 🚀
|
|
No help site update is needed. This PR fixes a layout bug so that clicking the top of the floating right-hand panel no longer closes it, which is the behavior users already expect. |
|
🚀 Deployed to production by https://github.com/Julesssss in version: 9.5.0-5 🚀
Bundle Size Analysis (Sentry): |





Explanation of Change
#101093 added thin transparent overlay bands around the floating RHP card so clicks in the 12px gap close the RHP. The bands reuse
BaseOverlay, which always renders a fixed 30px top pressable (the old Electron drag bar), and nothing clipped it, so it spilled 18px onto the top of the card. Clicking there closed the RHP. This addsoverflowHiddento theBaseOverlayroot so its pressables stay inside the overlay's own box. Full height overlays are unaffected.Fixed Issues
$ #102622
PROPOSAL: N/A (deploy blocker)
Tests
Offline tests
Same as tests, the change is layout only and doesn't depend on network.
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-09-30.at.11.19.11.mov