Repository navigation
Conversation
|
new route is in staging, I think we can open this up for review. |
|
🚧 rlinoz has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
rlinoz
left a comment
There was a problem hiding this comment.
Looks good, and it is working!
| } | ||
|
|
||
| function loadPersonalDetails() { | ||
| // eslint-disable-next-line rulesdir/no-api-side-effects-method -- API.read waits for OpenApp; this must run in parallel |
There was a problem hiding this comment.
❌ CONSISTENCY-15 (docs)
Comments should read as plain, natural sentences. This justification joins two independent clauses with a semicolon (API.read waits for OpenApp; this must run in parallel), which CONSISTENCY-15 flags; a semicolon should be replaced with two separate sentences.
Rewrite it as two sentences, for example:
// eslint-disable-next-line rulesdir/no-api-side-effects-method -- API.read waits for OpenApp. This must run in parallel.Reviewed at: 38564e9 | Please rate this suggestion with 👍 or 👎 to help us improve! Reactions are used to monitor reviewer efficiency.
Reviewer Checklist
Screenshots/VideosMacOS: Chrome / SafariScreen.Recording.2026-10-02.at.14.25.07.mov |
dylanexpensify
left a comment
There was a problem hiding this comment.
Performance based, no product input needed
|
🚧 rlinoz has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/rlinoz in version: 9.5.2-0 🚀
|
|
No help site update needed. This PR only changes how the app loads personal details in the background (a new |
|
@TMisiukiewicz This PR is failing because of a regression issue #102957 The issue is reproducible in: Web Bug7277433_1791171948221!Crash.txt Bug7277433_1791171632699.App_crash.mp4 |
|
🚀 Deployed to production by https://github.com/Julesssss in version: 9.5.2-4 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
This adds a new
LoadPersonalDetailsrequest that loads personal details separately fromOpenApp.LoadPersonalDetailsis sent right afterOpenApp, and both requests run at the same time. It does not wait in the request queue behindOpenApp.ReconnectAppsendsLoadPersonalDetailsthe same way. An incremental reconnect does not.Fixed Issues
$ #102559
PROPOSAL:
Tests
LoadPersonalDetailsrequest is sent right afterOpenApp, without waiting forOpenAppto finish.Offline tests
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
🤖 Generated with Claude Code