Repository navigation
Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
JmillsExpensify
left a comment
There was a problem hiding this comment.
Testing steps look good to me.
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppUploading Screen Recording 2026-11-16 at 6.58.32 PM.mov… Android: mWeb ChromeScreen.Recording.2026-11-16.at.6.54.51.PM.moviOS: HybridAppUploading Screen Recording 2026-11-16 at 6.49.51 PM.mov… iOS: mWeb SafariScreen.Recording.2026-11-16.at.6.45.51.PM.movMacOS: Chrome / SafariScreen.Recording.2026-11-16.at.6.37.29.PM.mov |
|
sorry for the delay. @emkhalid can you have a look at the conflicts please? |
Done, thanks! |
|
The failure is also unrelated to our PR changes. |
|
Bug: Press enter on clear icon doesn't clear search text but switch account Screen.Recording.2026-10-13.at.11.19.49.PM.mov |
|
Bug: switch items with Tab and Enter doesn't work
Screen.Recording.2026-10-13.at.11.28.16.PM.mov |
|
@codex review VoiceOver issues |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b5a4318f9e
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Thanks for the review! Fixed this one: clear-resolved.mov |
Also resolved this one: switch-fix.mov |
@eh2077 Thanks for the thorough review. I addressed the confirmed keyboard-focus issues:
One behavior still needs your confirmation: when the search input is focused and no Arrow key has been pressed, should the first result already be active—so Enter selects it and Arrow Down moves to the second result—or should Enter do nothing and the first Arrow Down activate the first result? Screen.Recording.2026-11-06.at.10.14.59.PM.mov |
|
@eh2077 All fixes and related regression cases have now been tested on web, iOS, and Android, and everything works as expected. Could you please review again? Thanks! |
|
thanks for the update, will check again shortly |
|
We did not find an internal engineer to review this PR, trying to assign a random engineer to #96225 as well as to this PR... Please reach out for help on Slack if no one gets assigned! |
| innerContainerStyle={styles.pb0} | ||
| shouldUseScrollView | ||
| shouldUpdateFocusedIndex={false} | ||
| shouldUpdateFocusedIndex={shouldShowSearchInput} |
There was a problem hiding this comment.
This was set to false back in #48292, are we sure turning it on (when search shows) does not bring back whatever that was fixing on iOS?
|
@iwiznia Thanks! I kept the original native safeguard and made the focus update web-only. I tested on iOS, Android, and web—all passed. Ready for your review. |
|
Conflicts |
|
@iwiznia, Resolved the conflicts, thanks! |
|
🚧 iwiznia has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/iwiznia in version: 9.5.43-0 🚀
|
|
No help site update needed — this PR restores expected keyboard, touch, and screen-reader behavior in the existing account switcher without adding a workflow or making any existing article sentence incorrect. |
|
🚀 Deployed to staging by https://github.com/iwiznia in version: 9.5.47-0 🚀
|
|
🚀 Deployed to staging by https://github.com/iwiznia in version: 9.5.51-0 🚀
|
|
🚀 Deployed to production by https://github.com/marcaaron in version: 9.5.51-1 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Fixes keyboard interactions in the searchable Copilot account switcher:
Fixed Issues
$ #96225
$ #99964
$ #99974
PROPOSAL: #96225 (comment)
Tests
Precondition:
Native — first-tap handling:
Web — keyboard navigation:
Regression checks:
Offline tests
QA Steps
Same as Tests and Offline tests.
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
android.mov
Android: mWeb Chrome
android-web.mov
iOS: Native
ios-native.mov
iOS: mWeb Safari
ios-web.mov
MacOS: Chrome / Safari
web.mov