Repository navigation
Disable strict mode in Re.Pack to match Metro - #102681
Conversation
|
@Julesssss shall I review this? |
|
Closed bcoz revert pr is merged https://github.com/Expensify/Mobile-Expensify/pull/14148 |
|
Hi @suneox , If you want I can also raise it in other pr but as its your work here I think you might want to do it :) |
@elirangoshen I've reopened the PR |
thanks ! |
| } | ||
| : undefined, | ||
| module: {type: 'commonjs', lazy: false}, | ||
| // Metro's babel preset lowers node_modules with `strictMode: false`, so dependencies that rely on sloppy mode |
There was a problem hiding this comment.
This comment seems incomplete
There was a problem hiding this comment.
I've updated this to simplify matching the babel preset
There was a problem hiding this comment.
// Don't inject "use strict", matching Metro (@react-native/babel-preset sets `strictMode: false`).
// Some packages rely on sloppy-mode semantics, e.g. expo's FormData patch assigns to the
// getter-only `File.name`, which throws in strict mode and breaks file uploads.
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppab1.webm |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 roryabraham has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/roryabraham in version: 9.5.4-0 🚀
|
|
🚀 Deployed to production by https://github.com/puneetlath in version: 9.5.4-3 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Fixed Issues
$ #102623
PROPOSAL: #102623 (comment)
Tests
Verify: Tags are imported successfully
Offline tests
QA Steps
Same test section
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
az_recorder_20261001_013023.1.mp4
Android: mWeb Chrome
CleanShot.2026-10-01.at.01.35.52.mp4
iOS: Native
CleanShot.2026-10-01.at.01.33.52.3.mp4
iOS: mWeb Safari
CleanShot.2026-10-01.at.01.35.52.4.mp4
MacOS: Chrome / Safari
CleanShot.2026-10-01.at.01.24.23.2.mp4